Conversation
…p_message Simplify ensureAgentRunsIssue by directly assigning the result of generateFooterWithExpiration to parentBody, eliminating the unnecessary footer intermediate variable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Simplifies ensureAgentRunsIssue by removing a redundant intermediate variable when generating the issue body for the no-op runs parent issue.
Changes:
- Inline
generateFooterWithExpiration(...)result directly intoparentBody(removes unnecessaryfootervariable).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies code introduced in #23284 by removing an unnecessary intermediate variable.
Files Simplified
actions/setup/js/handle_noop_message.cjs— removedfooterintermediate variableImprovement Made
In
ensureAgentRunsIssue, thefootervariable was assigned fromgenerateFooterWithExpiration(...)and then immediately assigned toparentBody:This intermediate step adds no value. The simplification assigns directly to
parentBody:Changes Based On
Recent changes from:
Testing
make lint-cjs)make build)References: §23678839951