fix: correct serena-go.md import path to fix integration test failure#23452
Merged
fix: correct serena-go.md import path to fix integration test failure#23452
Conversation
…rena.md Agent-Logs-Url: https://github.com/github/gh-aw/sessions/e96b7e8e-69cf-431b-a414-160bac82edb7 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…rt fix Agent-Logs-Url: https://github.com/github/gh-aw/sessions/e96b7e8e-69cf-431b-a414-160bac82edb7 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
March 29, 2026 12:30
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an integration test/CI failure caused by an incorrect nested frontmatter import path in .github/workflows/shared/mcp/serena-go.md, and updates the integration test to fetch a commit that contains the corrected workflow content.
Changes:
- Correct
serena-go.mdto importserena.mdvia a path relative to its own directory. - Update the pinned
smoke-copilot.mdcommit SHA in the integration test to one that includes the workflow fix. - Minor cleanup in a remote workflow unit test (removes an extraneous blank line).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/shared/mcp/serena-go.md |
Fixes nested import path so recursive import resolution finds serena.md. |
pkg/cli/add_integration_test.go |
Pins integration test to a commit that contains the upstream workflow fix. |
pkg/cli/remote_workflow_test.go |
Removes a stray blank line (no behavior change). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CI failure: https://github.com/github/gh-aw/actions/runs/23708693837/job/69064735931#step:8:1
Root Cause
TestAddWorkflowWithDispatchWorkflowFromSharedImportwas failing becauseserena-go.md(at.github/workflows/shared/mcp/serena-go.md) importedshared/mcp/serena.md.When
fetchFrontmatterImportsRecursiveprocesses imports recursively, it resolves each import path relative to the importing file's directory. So when processingserena-go.md's imports:currentBaseDir=.github/workflows/shared/mcpshared/mcp/serena.md.github/workflows/shared/mcp/shared/mcp/serena.md❌ (doesn't exist → HTTP 404)The import path
shared/mcp/serena.mdwas written as if paths are always relative to.github/workflows/, but for nested imports the path is resolved relative to the importing file's directory.Fix
serena-go.mdimport fromshared/mcp/serena.md→serena.md(correct relative path since bothserena-go.mdandserena.mdlive in the sameshared/mcp/directory)TestAddWorkflowWithDispatchWorkflowFromSharedImportto pin to commit15af946which contains the fix (so the integration test fetches the correctedserena-go.mdfrom GitHub)Changes
.github/workflows/shared/mcp/serena-go.md: fix import pathpkg/cli/add_integration_test.go: update pinned commit SHA to15af946