[code-simplifier] refactor: simplify token usage parsing in parse_mcp_gateway_log.cjs

[github-actions]

Targeted simplification of the token usage parsing code added in #24029, improving clarity while preserving identical behavior.

Files Simplified

• actions/setup/js/parse_mcp_gateway_log.cjs — cleaned up newly added token usage functions

Improvements Made

1. Nullish assignment for model initialization (parseTokenUsageJsonl)

Replace verbose if (!x) x = {...} guard with ??= (logical nullish assignment):

// Before
if (!summary.byModel[model]) {
  summary.byModel[model] = { provider: ..., inputTokens: 0, ... };
}

// After
summary.byModel[model] ??= { provider: ..., inputTokens: 0, ... };

2. Removed redundant ternary (writeStepSummaryWithTokenUsage)

generateTokenUsageSummary() already handles null input (returns ""), so the ternary guard is unnecessary:

// Before
const summary = parseTokenUsageJsonl(content);
const markdown = summary ? generateTokenUsageSummary(summary) : "";

// After
const markdown = generateTokenUsageSummary(parseTokenUsageJsonl(content));

3. Optional chaining (writeStepSummaryWithTokenUsage)

// Before
if (content && content.trim()) {

// After
if (content?.trim()) {

Changes Based On

Recent changes from:

• feat: render token-usage.jsonl in the MCP gateway step summary #24029 — feat: render token-usage.jsonl in the MCP gateway step summary

Testing

• ✅ Inline validation tests pass (node runtime)
• ✅ Linting passes (make lint-cjs)
• ✅ No functional changes — behavior is identical

Review Focus

Please verify:

• Functionality is preserved
• ??= operator is available in Node.js 20+ (GitHub Actions runtime) ✅
• generateTokenUsageSummary(null) returns "" as expected ✅

---

Automated by Code Simplifier Agent — analyzing code from the last 24 hours

References:

• §23886476857

Generated by Code Simplifier · ◷

• expires on Apr 3, 2026, 6:11 AM UTC

[Copilot]

Pull request overview

Refactors the token usage parsing/rendering logic in parse_mcp_gateway_log.cjs to reduce verbosity while preserving existing behavior introduced in #24029.

Changes:

• Uses ??= to initialize per-model token usage buckets more concisely in parseTokenUsageJsonl.
• Simplifies token usage markdown generation by removing an unnecessary ternary guard.
• Replaces a verbose content check with content?.trim().

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.