Migrate pkg/repoutil tests to testify assertions#24085
Merged
Conversation
9 tasks
…sertions Agent-Logs-Url: https://github.com/github/gh-aw/sessions/b1855635-88a8-4aea-9a80-c6e36f576865 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve test quality in pkg/repoutil/repoutil_test.go
Migrate pkg/repoutil tests to testify assertions
Apr 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates pkg/repoutil unit tests to use testify assertions for more consistent style and clearer failure output.
Changes:
- Switched from manual
if err != nil/t.Errorfchecks torequire.NoError/require.Error. - Replaced manual field comparisons with
assert.Equaland improved failure messages. - Updated whitespace and idempotency tests to assert returned
owner/repovalues and to use subtests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/repoutil/repoutil_test.goused only the standardtestingpackage with manual error checks and value comparisons. Migrated to testify for consistent assertion style and clearer failure messages.Changes
testify/assertandtestify/requireif err == nil/!= nil { t.Errorf(...) }withrequire.Error/require.NoErrorassert.Equalincluding descriptive messagesTestSplitRepoSlug_Whitespace: AddedexpectedOwner/expectedRepofields to the test table — previously the function discarded the returned values entirelyTestSplitRepoSlug_Idempotent: Refactored bare loop intot.Runsubtests with testify assertionsBefore:
After: