Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/1f7b317e-40f4-4154-bc87-efae4a52a2d5 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 5, 2026 15:52
View session
Collaborator
|
@copilot only render summary of optl is enabled in the workflow |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the observability.job-summary opt-in and makes the “Generate observability summary” job-summary step render for every workflow run by default.
Changes:
- Compiler always emits the observability summary step (no mode gate / env var injection).
- Frontmatter types + JSON schema + editor autocomplete remove
observability.job-summary. - JS runtime + tests + goldens/lockfiles updated to reflect always-on summary generation.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/compiler_yaml_ai_execution.go | Removes opt-in gating and always emits the summary step (drops env var injection). |
| pkg/workflow/compiler_yaml_main_job.go | Updates main job step generation to always include observability summary. |
| actions/setup/js/generate_observability_summary.cjs | Removes env-var mode gate; summary is always generated and written. |
| actions/setup/js/generate_observability_summary.test.cjs | Updates tests to match always-on behavior. |
| pkg/workflow/frontmatter_types.go | Removes ObservabilityConfig.JobSummary from typed frontmatter config. |
| pkg/workflow/frontmatter_types_test.go | Updates observability parsing test to OTLP-only example. |
| pkg/parser/schemas/main_workflow_schema.json | Removes observability.job-summary from schema; keeps observability.otlp. |
| pkg/parser/schema_test.go | Removes schema test that validated the removed key. |
| pkg/workflow/observability_job_summary_test.go | Updates compile test to assert summary step is always present. |
| pkg/workflow/observability_otlp_test.go | Updates OTLP-related parsing tests to remove job-summary references. |
| docs/src/content/docs/reference/frontmatter-full.md | Removes job-summary docs; now shows empty observability example. |
| docs/public/editor/autocomplete-data.json | Removes job-summary autocomplete; observability now has no children. |
| .github/aw/github-agentic-workflows.md | Removes job-summary bullet from observability docs. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.golden | Golden updated to include the observability summary step. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.golden | Golden updated to include the observability summary step. |
| .github/workflows/ace-editor.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/agent-persona-explorer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/agent-performance-analyzer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/agentic-observability-kit.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/ai-moderator.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/archie.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/artifacts-summary.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/audit-workflows.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/auto-triage-issues.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/blog-auditor.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/bot-detection.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/breaking-change-checker.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/brave.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/changeset.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/ci-coach.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/ci-doctor.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/claude-code-user-docs-review.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/cli-consistency-checker.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/cli-version-checker.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/cloclo.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/code-scanning-fixer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/code-simplifier.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/codex-github-remote-mcp-test.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/commit-changes-analyzer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/contribution-check.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/copilot-agent-analysis.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/copilot-cli-deep-research.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/copilot-pr-merged-report.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/copilot-pr-nlp-analysis.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/copilot-pr-prompt-analysis.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/copilot-session-insights.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/copilot-token-audit.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/copilot-token-optimizer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/craft.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-architecture-diagram.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-assign-issue-to-user.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-choice-test.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-cli-performance.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-cli-tools-tester.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-code-metrics.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-community-attribution.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-compiler-quality.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-doc-healer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-doc-updater.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-fact.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-file-diet.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-firewall-report.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-function-namer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-integrity-analysis.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-issues-report.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-malicious-code-scan.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-mcp-concurrency-analysis.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-multi-device-docs-tester.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-news.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-observability-report.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-otel-instrumentation-advisor.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-performance-summary.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-regulatory.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-rendering-scripts-verifier.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-repo-chronicle.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-safe-output-integrator.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-safe-output-optimizer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-safe-outputs-conformance.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-secrets-analysis.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-security-red-team.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-semgrep-scan.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-syntax-error-quality.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-team-evolution-insights.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-team-status.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-testify-uber-super-expert.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/daily-workflow-updater.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/dead-code-remover.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/deep-report.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/delight.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/dependabot-burner.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/dependabot-go-checker.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/dev-hawk.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/dev.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/developer-docs-consolidator.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/dictation-prompt.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/discussion-task-miner.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/docs-noob-tester.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/draft-pr-cleanup.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/duplicate-code-detector.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/example-permissions-warning.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/example-workflow-analyzer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/firewall-escape.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/firewall.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/functional-pragmatist.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/github-mcp-structural-analysis.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/github-mcp-tools-report.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/github-remote-mcp-auth-test.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/glossary-maintainer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/go-fan.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/go-logger.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/go-pattern-detector.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/gpclean.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/grumpy-reviewer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/hourly-ci-cleaner.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/instructions-janitor.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/issue-arborist.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/issue-monster.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/issue-triage-agent.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/jsweep.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/layout-spec-maintainer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/lockfile-stats.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/mcp-inspector.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/mergefest.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/metrics-collector.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/notion-issue-summary.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/org-health-report.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/pdf-summary.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/plan.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/poem-bot.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/portfolio-analyst.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/pr-nitpick-reviewer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/pr-triage-agent.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/prompt-clustering-analysis.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/python-data-charts.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/q.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/refiner.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/release.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/repo-audit-analyzer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/repo-tree-map.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/repository-quality-improver.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/research.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/safe-output-health.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/schema-consistency-checker.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/schema-feature-coverage.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/scout.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/security-compliance.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/security-review.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/semantic-function-refactor.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/sergo.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/slide-deck-maintainer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-agent-all-merged.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-agent-all-none.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-agent-public-approved.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-agent-public-none.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-agent-scoped-approved.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-call-workflow.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-claude.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-codex.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-copilot-arm.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-copilot.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-create-cross-repo-pr.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-gemini.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-multi-pr.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-project.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-service-ports.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-temporary-id.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-test-tools.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-update-cross-repo-pr.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-workflow-call-with-inputs.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/smoke-workflow-call.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/stale-repo-identifier.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/static-analysis-report.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/step-name-alignment.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/sub-issue-closer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/super-linter.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/technical-doc-writer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/terminal-stylist.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/test-create-pr-error-handling.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/test-dispatcher.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/test-project-url-default.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/test-workflow.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/tidy.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/typist.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/ubuntu-image-analyzer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/unbloat-docs.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/update-astro.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/video-analyzer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/weekly-blog-post-writer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/weekly-editors-health-check.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/weekly-issue-summary.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/weekly-safe-outputs-spec-review.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/workflow-generator.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/workflow-health-manager.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/workflow-normalizer.lock.yml | Recompiled lockfile includes the observability summary step. |
| .github/workflows/workflow-skill-extractor.lock.yml | Recompiled lockfile includes the observability summary step. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
pkg/parser/schema_test.go:197
- The schema test that previously asserted
observability.job-summarywas allowed was removed, but there isn't a replacement assertion thatobservability.job-summaryis now rejected by schema validation. Adding a regression test for the new invalid/unknown-property behavior would help prevent accidental reintroduction of the deprecated key.
- Files reviewed: 196/196 changed files
- Comments generated: 4
Comment on lines
1646
to
1650
| "observability": { | ||
| "type": "object", | ||
| "desc": "Optional observability output settings for workflow runs.", | ||
| "children": { | ||
| "job-summary": { | ||
| "type": "string", | ||
| "desc": "If set to 'on', append a compact observability section to the GitHub Actions job summary.", | ||
| "enum": ["on", "off"], | ||
| "leaf": true | ||
| } | ||
| } | ||
| "children": {} | ||
| }, |
There was a problem hiding this comment.
observability autocomplete entries currently have an empty children object, which removes completion for the still-supported observability.otlp config (and its endpoint/headers). Please add otlp (and its subkeys) back to the autocomplete schema so editor suggestions match main_workflow_schema.json.
Contributor
There was a problem hiding this comment.
👋 Smoke test agent here — just verifying reply functionality works! Great catch on the autocomplete regression.
📰 BREAKING: Report filed by Smoke Copilot · ● 1.1M
Comment on lines
5906
to
5909
| # Optional observability output settings for workflow runs. | ||
| # (optional) | ||
| observability: | ||
| # If set to 'on', append a compact observability section to the GitHub Actions job | ||
| # summary. Defaults to off when omitted. | ||
| # (optional) | ||
| job-summary: "on" | ||
| observability: {} | ||
|
|
There was a problem hiding this comment.
The frontmatter-full.md reference now shows observability: {} which implies there are no configurable observability options. Since the schema still supports observability.otlp.endpoint/headers, this section should document those fields (similar to other nested objects) to avoid misleading readers.
Comment on lines
248
to
268
| @@ -261,8 +263,8 @@ func TestParseFrontmatterConfig(t *testing.T) { | |||
| t.Fatal("Observability should not be nil") | |||
| } | |||
|
|
|||
| if config.Observability.JobSummary != "on" { | |||
| t.Errorf("JobSummary = %q, want %q", config.Observability.JobSummary, "on") | |||
| if config.Observability.OTLP == nil { | |||
| t.Fatal("OTLP should not be nil") | |||
| } | |||
There was a problem hiding this comment.
This test was updated to use an OTLP example, but it only asserts config.Observability.OTLP != nil. To keep coverage for OTLP parsing behavior, please also assert the parsed values (e.g., endpoint and/or headers) match the input.
Comment on lines
40
to
46
| compiled := string(lockContent) | ||
| if !strings.Contains(compiled, "- name: Generate observability summary") { | ||
| t.Fatal("Expected observability summary step to be generated") | ||
| } | ||
| if !strings.Contains(compiled, "GH_AW_OBSERVABILITY_JOB_SUMMARY: \"on\"") { | ||
| t.Fatal("Expected observability summary mode env var to be set") | ||
| t.Fatal("Expected observability summary step to always be generated") | ||
| } | ||
| if !strings.Contains(compiled, "require('${{ runner.temp }}/gh-aw/actions/generate_observability_summary.cjs')") { | ||
| t.Fatal("Expected generated workflow to load generate_observability_summary.cjs") | ||
| } |
There was a problem hiding this comment.
Since the PR removes the GH_AW_OBSERVABILITY_JOB_SUMMARY env var injection, this test should also assert that the compiled workflow does not contain GH_AW_OBSERVABILITY_JOB_SUMMARY anymore. That would make the test fully cover the new always-on behavior and prevent regressions.
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/9e2b1894-ac37-4ad6-bd4b-ba80d512ff4a Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Done in 4ca6702. The observability summary step is now only emitted when Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Remove observability.job-summary opt-in, always render job summary
Remove observability.job-summary opt-in, render job summary when OTLP is enabled
Apr 5, 2026
Collaborator
|
@copilot check optl enabled based on full imported front matter |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/ac35e771-96e2-4c8f-b440-5722522a9291 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Done in 3256ac0. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Collaborator
|
@copilot Recon file and make sure it is admitted for work clothes that I have OPTL enabled |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/7dbb01f8-59d0-4ccb-8517-79c914d15023 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Done in 9b64fa2.
Added Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
Contributor
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... |
Contributor
|
✅ All tools validated successfully! Agent Container Smoke Test confirms agent container is ready. |
Contributor
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
Contributor
Agent Container Tool Check
Result: 12/12 tools available ✅ Overall Status: PASS
|
Contributor
|
🤖 Smoke test §24005782965 results for
Overall:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Smoke test review pass 🤖 — two minor inline observations left about the always-on observability summary: one about adding a clarifying comment in the JS runtime, and one about documenting the merge strategy for imported OTLP configs. Overall the change is clean and well-motivated.
📰 BREAKING: Report filed by Smoke Copilot · ● 1.1M
|
|
||
| const data = collectObservabilityData(); | ||
| const markdown = buildObservabilitySummary(data); | ||
| await core.summary.addRaw(markdown).write(); |
Contributor
There was a problem hiding this comment.
Nice simplification — removing the GH_AW_OBSERVABILITY_JOB_SUMMARY mode gate makes main() unconditionally run. Since this is now always-on, it might be worth adding a comment here (e.g., // Called only when OTLP is configured; see compiler_orchestrator_workflow.go) so future readers understand the guard moved to the compiler rather than the runtime.
| // Extract observability from imported file (first-wins: only set if not yet populated). | ||
| // This ensures an imported workflow's OTLP config is visible to injectOTLPConfig even | ||
| // when the main workflow's frontmatter does not contain an observability section. | ||
| if acc.observabilityBuilder.Len() == 0 { |
Contributor
There was a problem hiding this comment.
The new MergedObservability field extraction from imported workflows is a great improvement. Consider adding a comment explaining the merge strategy (e.g., last-write-wins vs deep merge) when multiple imports each define observability.otlp.endpoint, since conflicts could silently drop a configured endpoint.
Contributor
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Contributor
|
Smoke Test Results — Run 24005782960 Core: 1✅ 2✅ 3✅ 4✅ 5✅ 6❌(Tavily 429) 7✅ 8✅ 9✅ 10✅ 11✅ 12✅ Status: PARTIAL (Tavily rate-limited; 2 tests skipped)
|
Contributor
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
💥 [THE END] — Illustrated by Smoke Claude · ● 301.7K
| @@ -303,7 +303,6 @@ The YAML frontmatter supports these fields: | |||
| - **`otlp:`** - Export OpenTelemetry spans to any OTLP-compatible backend (Honeycomb, Grafana Tempo, Sentry, etc.) (object) | |||
Contributor
There was a problem hiding this comment.
The observability.otlp section and its endpoint/headers subkeys should still be documented here since they're still supported, even after removing job-summary. Consider adding them back with an example.
| @@ -114,12 +114,6 @@ function buildObservabilitySummary(data) { | |||
| } | |||
Contributor
There was a problem hiding this comment.
Good simplification — removing the GH_AW_OBSERVABILITY_JOB_SUMMARY mode gate makes the behavior cleaner. The summary is now always generated when called, which aligns with the new OTLP-gated invocation in the compiler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
observability.job-summaryopt-in field has been removed. The observability job summary step is now automatically emitted whenever OTLP is configured in the workflow (observability.otlp.endpointis set), and skipped otherwise. OTLP detection covers both the main workflow frontmatter and any imported workflows.Changes
getObservabilityJobSummaryMode(); addedisOTLPEnabled()helper (checks injectedOTEL_EXPORTER_OTLP_ENDPOINTenv var);generateObservabilitySummary()now emits the step only when OTLP is configuredobservabilityis now extracted from imported workflow files (import_field_extractor.go); stored inImportsResult.MergedObservability; merged intoRawFrontmatterbeforeinjectOTLPConfigruns so that an OTLP endpoint defined in an imported workflow triggers the summary stepJobSummaryfield fromObservabilityConfigjob-summaryproperty frommain_workflow_schema.jsonandautocomplete-data.jsonGH_AW_OBSERVABILITY_JOB_SUMMARYmode gate ingenerate_observability_summary.cjs;main()always generates and writes the summary when calledTestCompileWorkflow_IncludesObservabilitySummaryStepWhenOTLPEnabledViaImportto cover the import case end-to-endjob-summaryreferences fromfrontmatter-full.mdandgithub-agentic-workflows.md✨ PR Review Safe Output Test - Run 24005782960