Conversation
Enhances debugging coverage across 5 workflow package files: - compiler_yaml_step_generation: log entry points for generateSetupStep, generateRestoreActionsSetupStep, and generateSetRuntimePathsStep - mcp_config_playwright_renderer: log volume mount configuration and final render completion with entrypoint arg count - glob_validation: log rejected path prefixes and per-pattern error counts in runGlobValidation - permissions: log when IsGitHubAppOnlyScope detects an App-only scope - compiler_yaml_step_conversion: log unquoteUsesWithComments entry point Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds meaningful debug logging to 5 workflow package files that had a logger defined but minimal or no logging calls.
Files Enhanced
pkg/workflow/compiler_yaml_step_generation.gopkg/workflow/mcp_config_playwright_renderer.gopkg/workflow/glob_validation.gopkg/workflow/permissions.gopkg/workflow/compiler_yaml_step_conversion.goChanges
generateRestoreActionsSetupStep,generateSetupStep(with ref/destination/flags), andgenerateSetRuntimePathsStepisLastand entrypoint arg countvalidatePathGlob; log per-pattern error count inrunGlobValidationIsGitHubAppOnlyScopedetects a scope that requires a GitHub App tokenunquoteUsesWithCommentswith content sizeValidation
make buildpasses with no compilation errorsgo test ./pkg/workflow/... -run TestCompilepassesgo test ./pkg/workflow/... -run TestGlobpassesgo test ./pkg/parser/...passesAll logging calls follow the project guidelines:
compilerYamlStepGenerationLog,mcpPlaywrightLog,globValidationLog,permissionsLog,stepConversionLog)