Skip to content

[log] Add debug logging to workflow step generation and validation#24780

Merged
pelikhan merged 1 commit intomainfrom
add-debug-logging-step-generation-and-mcp-66680600e1868e80
Apr 5, 2026
Merged

[log] Add debug logging to workflow step generation and validation#24780
pelikhan merged 1 commit intomainfrom
add-debug-logging-step-generation-and-mcp-66680600e1868e80

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Apr 5, 2026

Adds meaningful debug logging to 5 workflow package files that had a logger defined but minimal or no logging calls.

Files Enhanced

File Lines Prior Calls Added
pkg/workflow/compiler_yaml_step_generation.go 188 1 3
pkg/workflow/mcp_config_playwright_renderer.go 174 2 2
pkg/workflow/glob_validation.go 251 3 2
pkg/workflow/permissions.go 281 1 1
pkg/workflow/compiler_yaml_step_conversion.go 181 3 1

Changes

  • compiler_yaml_step_generation: Log entry into generateRestoreActionsSetupStep, generateSetupStep (with ref/destination/flags), and generateSetRuntimePathsStep
  • mcp_config_playwright_renderer: Log volume mount configuration with guard policy count; log final render completion with isLast and entrypoint arg count
  • glob_validation: Log rejected path prefixes in validatePathGlob; log per-pattern error count in runGlobValidation
  • permissions: Log when IsGitHubAppOnlyScope detects a scope that requires a GitHub App token
  • compiler_yaml_step_conversion: Log entry into unquoteUsesWithComments with content size

Validation

  • make build passes with no compilation errors
  • go test ./pkg/workflow/... -run TestCompile passes
  • go test ./pkg/workflow/... -run TestGlob passes
  • go test ./pkg/parser/... passes

All logging calls follow the project guidelines:

  • No side effects in log arguments
  • Meaningful messages helpful for troubleshooting
  • Use existing package-level logger variables (compilerYamlStepGenerationLog, mcpPlaywrightLog, globValidationLog, permissionsLog, stepConversionLog)

Generated by Go Logger Enhancement · ● 1.2M ·

  • expires on Apr 7, 2026, 9:31 PM UTC

Enhances debugging coverage across 5 workflow package files:
- compiler_yaml_step_generation: log entry points for generateSetupStep,
  generateRestoreActionsSetupStep, and generateSetRuntimePathsStep
- mcp_config_playwright_renderer: log volume mount configuration and
  final render completion with entrypoint arg count
- glob_validation: log rejected path prefixes and per-pattern error counts
  in runGlobValidation
- permissions: log when IsGitHubAppOnlyScope detects an App-only scope
- compiler_yaml_step_conversion: log unquoteUsesWithComments entry point

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added automation enhancement New feature or request labels Apr 5, 2026
@pelikhan pelikhan merged commit 50907aa into main Apr 5, 2026
@pelikhan pelikhan deleted the add-debug-logging-step-generation-and-mcp-66680600e1868e80 branch April 5, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant