fix(lint): use require.NoError for error assertion in gitutil_test.go#24817
Merged
fix(lint): use require.NoError for error assertion in gitutil_test.go#24817
require.NoError for error assertion in gitutil_test.go#24817Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/7d0a9199-9a6f-4cc8-99cc-cb45d43b4a95 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 6, 2026 03:23
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates TestFindGitRoot to satisfy testifylint by using fatal assertions for error setup checks.
Changes:
- Replaced
assert.NoErrorwithrequire.NoErrorinTestFindGitRoot - Added the
github.com/stretchr/testify/requireimport
Show a summary per file
| File | Description |
|---|---|
| pkg/gitutil/gitutil_test.go | Switches the error assertion in TestFindGitRoot to require.NoError to align with testifylint’s setup-assertion expectations |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testifylintwas failing CI due to an error assertion usingassert.NoErrorinstead ofrequire.NoErrorinTestFindGitRoot.Change
pkg/gitutil/gitutil_test.go: replacedassert.NoError→require.NoErrorand added therequireimportrequirehalts the test immediately on failure, preventing subsequent assertions from running against a zero/nil value.