fix: add checks tool to MCP server tool tests#24818
Merged
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/aab709ce-ad03-4490-a920-6bdbf092e425 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 6, 2026 03:41
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates MCP server integration tests to account for the newly registered checks tool so tool listing and icon assertions match the server’s current tool set.
Changes:
- Added
checksto the expected tool name list inTestMCPServer_ListTools. - Added the expected
checksicon (✅) toTestMCPServer_ToolIcons.
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/mcp_server_tools_test.go | Aligns expected tool names and icon map with the MCP server’s registered tools (includes checks). |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
checkstool was added to the MCP server but the tests weren't updated, causingTestMCPServer_ToolIconsto fail withExpected 8 tools with icons, got 9 tools.Changes
mcp_server_tools_test.go: Added"checks"toexpectedToolsslice and"checks": "✅"toexpectedIconsmap to match the registered tool count and icon.