Conversation
…aily-syntax-error-quality - Add 'gh aw compile /tmp/syntax-error-tests/*.md' bash tool pattern so the agent can compile test files at absolute paths (fixes root cause of 84% wasted tokens: 64-turn source-code fallback when compile was blocked) - Remove unused 'github' toolset (saves ~130-260K tokens/run by not loading GitHub tool schemas into every turn's system prompt) - Update cp/cat patterns to use /tmp/syntax-error-tests/ subdirectory, consistent with the Phase 2 instructions in the prompt - Add explicit 'mkdir -p /tmp/syntax-error-tests' allowed bash command Addresses: https://github.com/github/gh-aw/issues/... Agent-Logs-Url: https://github.com/github/gh-aw/sessions/45651d47-88d4-4a14-a1e3-1f587a699977 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot use /tmp/gh-aw/... as a root for temp folder . Update prompt. |
Change temp directory from /tmp/syntax-error-tests to /tmp/gh-aw/syntax-error-tests in both the bash tool allow-list patterns and the prompt instructions. Agent-Logs-Url: https://github.com/github/gh-aw/sessions/0e153d47-75fe-4716-a0da-39512e826acc Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in bce4f1b. Updated all Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the daily-syntax-error-quality agentic workflow configuration to reduce token/turn cost by unblocking the compiler’s actual /tmp/gh-aw/... usage and removing unnecessary GitHub toolset configuration from the workflow frontmatter.
Changes:
- Allow
gh aw compileagainst/tmp/gh-aw/syntax-error-tests/*.mdand align temp-file operations under/tmp/gh-aw/syntax-error-tests/. - Remove the
tools.github.toolsets: [default]block from the workflow frontmatter to avoid loading unused GitHub tool schemas. - Regenerate the compiled lock workflow to reflect updated allow-listed shell commands.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/daily-syntax-error-quality.md | Updates tool allow-list and prompt instructions to use /tmp/gh-aw/syntax-error-tests/ and allow absolute-path compilation. |
| .github/workflows/daily-syntax-error-quality.lock.yml | Regenerates the rendered workflow and updates --allow-tool entries for the new /tmp/gh-aw/... paths. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 3
| cd /tmp/gh-aw/syntax-error-tests | ||
| gh aw compile test-1.md 2>&1 | tee test-1-output.txt |
There was a problem hiding this comment.
The instructions tell the agent to run cd /tmp/gh-aw/syntax-error-tests, but cd is not in the allowed bash tool list for this workflow (strict mode). This can cause tool denials if the agent follows the prompt; either add an allow-list entry for cd (e.g., cd /tmp/gh-aw/syntax-error-tests or cd*) or update the prompt to run gh aw compile using absolute paths without cd.
| cd /tmp/gh-aw/syntax-error-tests | |
| gh aw compile test-1.md 2>&1 | tee test-1-output.txt | |
| gh aw compile /tmp/gh-aw/syntax-error-tests/test-1.md 2>&1 | tee /tmp/gh-aw/syntax-error-tests/test-1-output.txt |
| - "head -n * .github/workflows/*.md" | ||
| - "cp .github/workflows/*.md /tmp/*.md" | ||
| - "cat /tmp/*.md" | ||
| - "cp .github/workflows/*.md /tmp/gh-aw/syntax-error-tests/*.md" |
There was a problem hiding this comment.
The allowed command pattern cp .github/workflows/*.md /tmp/gh-aw/syntax-error-tests/*.md is not a valid copy invocation if executed literally (multiple sources + a glob destination that likely doesn’t expand) and could fail with “target is not a directory”. Consider changing the allowed pattern to copy into the directory (e.g., /tmp/gh-aw/syntax-error-tests/) while still permitting the intended cp ... test-1.md usage.
| - "cp .github/workflows/*.md /tmp/gh-aw/syntax-error-tests/*.md" | |
| - "cp .github/workflows/*.md /tmp/gh-aw/syntax-error-tests/" |
| # --allow-tool shell(cat /tmp/gh-aw/syntax-error-tests/*.md) | ||
| # --allow-tool shell(cat) | ||
| # --allow-tool shell(cp .github/workflows/*.md /tmp/*.md) | ||
| # --allow-tool shell(cp .github/workflows/*.md /tmp/gh-aw/syntax-error-tests/*.md) | ||
| # --allow-tool shell(date) |
There was a problem hiding this comment.
The --allow-tool entry for cp .github/workflows/*.md /tmp/gh-aw/syntax-error-tests/*.md reflects a command that would fail if run verbatim (glob destination often won’t expand, and cp requires a directory when copying multiple sources). Prefer an allow pattern that is also a valid command (copy into /tmp/gh-aw/syntax-error-tests/) to avoid the agent selecting a broken allowed command.
The workflow was consuming ~9.3M tokens/run (~130 turns) because every
gh aw compileattempt was denied — the agent copies test files to/tmp/gh-aw/syntax-error-tests/and invokes the compiler with absolute paths, but only the relative globgh aw compile *was permitted. This triggered a 64-turn source-code reading fallback. Expected cost: ~15–20 turns (~1.1–1.4M tokens).Changes
/tmp/gh-awcompile path —"gh aw compile /tmp/gh-aw/syntax-error-tests/*.md"added to bash tool allow-list, unblocking the agent's actual compile workflowgithubtoolset — the workflow does purely local file ops + compile; thedefaulttoolset schema was loaded into every turn's system prompt for no reason (~130–260K tokens/run)cp/cat/mkdirpatterns — updated to use the/tmp/gh-aw/syntax-error-tests/subdirectory (project-standard/tmp/gh-aw/root) consistently with the Phase 2 prompt instructions; addedmkdir -p /tmp/gh-aw/syntax-error-testsas an explicit allowed command/tmp/gh-aw/syntax-error-tests/