chore: set AWFCliProxyMinVersion to v0.25.17#25411
Merged
Conversation
Lower the CLI proxy minimum version gate from v0.26.0 to v0.25.17, aligning it with the current DefaultFirewallVersion. Update version-gate tests to reflect the new minimum. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the CLI-proxy feature gate with the currently shipped default AWF (firewall) version by lowering AWFCliProxyMinVersion to v0.25.17, and updates the corresponding version-gate tests.
Changes:
- Lower
AWFCliProxyMinVersionfromv0.26.0tov0.25.17(matchingDefaultFirewallVersion). - Update
awfSupportsCliProxytest expectations for nil/empty configs to reflect default-version behavior. - Add an exact-minimum test case for
v0.25.17.
Show a summary per file
| File | Description |
|---|---|
| pkg/constants/version_constants.go | Lowers AWFCliProxyMinVersion to v0.25.17 to match DefaultFirewallVersion. |
| pkg/workflow/awf_helpers_test.go | Updates CLI proxy version-gate unit tests to reflect the new minimum and default behavior. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lowers
AWFCliProxyMinVersionfromv0.26.0tov0.25.17, aligning the CLI proxy version gate with the currentDefaultFirewallVersion(v0.25.17).Changes
pkg/constants/version_constants.go:AWFCliProxyMinVersion→v0.25.17pkg/workflow/awf_helpers_test.go: Updated version-gate tests to match new minimum (nil/empty configs now returntrue, addedv0.25.17exact-minimum test case)Testing
TestAWFSupportsCliProxy✅ (all 9 cases pass)TestBuildAWFArgsCliProxy✅ (all 4 cases pass)