[WIP] Fix invalid discussions permission in safe-outputs jobs#25473
Closed
[WIP] Fix invalid discussions permission in safe-outputs jobs#25473
Conversation
Copilot stopped work on behalf of
pelikhan due to an error
April 9, 2026 13:37
github-actions
Bot
deleted the
copilot/fix-invalid-discussions-permission
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildAddCommentPermissionsto NOT includediscussions:writeby default whenDiscussionsis nil (change from opt-out to opt-in)AddCommentsConfig.Discussionsfield comment to reflect the new defaultadd-comment.discussionsto say "Default: false"safe_outputs_permissions_test.go- removePermissionDiscussionsfrom add-comment default/pull-requests/issues test casescompile_outputs_comment_test.go- removediscussions: writefrom expected permissionsnotify_comment_test.go- removediscussions: writecheck for add-commentsafe_outputs_app_test.go- updateTestSafeOutputsAppTokenDiscussionsPermissionmake agent-finishand validate all tests pass