fix: correct test expectation for U+3000 ideographic space under NFKC normalization#25490
Merged
fix: correct test expectation for U+3000 ideographic space under NFKC normalization#25490
Conversation
…for U+3000 Agent-Logs-Url: https://github.com/github/gh-aw/sessions/31cc0933-ac86-4133-a0ec-54536bbadd4a Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 9, 2026 14:20
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an incorrect test expectation around Unicode normalization: under NFKC, the ideographic space U+3000 is normalized to a regular space U+0020, so it should not survive hardenUnicodeText.
Changes:
- Updated the expected output in the “fullwidth ASCII” test to use U+0020 instead of U+3000.
- Corrected the inline comment to reflect the actual NFKC behavior.
Show a summary per file
| File | Description |
|---|---|
| actions/setup/js/sanitize_title.test.cjs | Updates the test expectation/comment to match NFKC normalization behavior (U+3000 → U+0020). |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sanitize_title.test.cjshad a wrong expectation: it asserted that the ideographic space U+3000 () would survivehardenUnicodeText, but NFKC normalization (step 6) maps U+3000 → U+0020.Change
"should convert fullwidth ASCII to standard ASCII"test case from"Test 123"(U+3000) to"Test 123"(U+0020)