Conversation
Restores 4 template entries (Issue Triage, CI Doctor, Contribution Guidelines Checker, Daily Repo Status) as inline content in the SAMPLES object in docs/public/editor/editor.js. These were previously removed in c46362c when URL-based fetching was disabled for security, but the corresponding HTML <option> elements were left in place, breaking the template dropdown for all templates other than Hello World. Closes #25526 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the 4 missing template entries (Issue Triage, CI Doctor, Contribution Guidelines Checker, Daily Repo Status) as inline content in the
SAMPLESobject indocs/public/editor/editor.js.Root Cause
Commit
c46362c4c7removed the URL-based fetching fromeditor.jsfor security, and deleted the 4 non-hello-world template entries fromSAMPLES. However, the corresponding<option>elements were left inindex.html. WhenloadSample(key)is called for any key other thanhello-world,SAMPLES[key]returnsundefinedand the function returns early — leaving the editor unchanged.Fix
Restored the 4 templates as inline content in the
SAMPLESobject:issue-triageci-doctorcontribution-checkdaily-repo-statusNo changes to
index.html, event handlers, or deep-link logic — they already work correctly; they just neededSAMPLESdata populated.📝 Detailed Changes & References
Changes Made
SAMPLESindocs/public/editor/editor.jsas inline contentMerged PRs Referenced
None — this is a standalone doc bug fix.
Skipped Issues
patterns/workqueue-ops.mdandpatterns/batch-ops.mdexist.allowed-eventsfilter tosubmit-pull-request-review#25484 (allowed-eventsforsubmit-pull-request-review): Already documented in PR —safe-outputs.mdandfrontmatter-full.mdwere updated as part of that PR.Notes
Closes #25526