Conversation
- Add pkg/cli/workflows/test-copilot-upload-artifact.md: test workflow demonstrating the upload-artifact safe-output type with the Copilot engine - Add upload_artifact config test case to TestAddHandlerManagerConfigEnvVar in pkg/workflow/compiler_safe_outputs_config_test.go upload-artifact was the only safe-output type missing both a test workflow and a Go compiler test case in TestAddHandlerManagerConfigEnvVar. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pelikhan
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds test coverage for the
upload-artifactsafe-output type, which was the only type missing both a test workflow and a Go compiler test inTestAddHandlerManagerConfigEnvVar.Coverage Gap Found
Scanned all safe-output types from
SafeOutputsConfiginpkg/workflow/compiler_types.goagainst:pkg/cli/workflows/(checking frontmatter forupload-artifact:key)pkg/workflow/compiler_safe_outputs_config_test.goResult:
upload-artifactwas the only type with zero coverage in both places.Changes
New Test Workflow
pkg/cli/workflows/test-copilot-upload-artifact.md— minimal workflow demonstrating theupload_artifactsafe-output type with Copilot engine, usingmax-uploads: 1andallowed-paths: ["output/**"]New Go Compiler Test
upload_artifact configtest case toTestAddHandlerManagerConfigEnvVarinpkg/workflow/compiler_safe_outputs_config_test.goUploadArtifactConfigwithMaxUploads: 1,MaxSizeBytes: 104857600(100 MB), andAllowedPaths: ["output/**"]GH_AW_SAFE_OUTPUTS_HANDLER_CONFIGenv var with anupload_artifactkey in the JSONAll Other Types Were Already Covered
All 40+ other safe-output types already had at least one test workflow and one Go test case. This PR completes the coverage.
References: