fix: update golden test files for Copilot CLI bump to 1.0.21#25692
fix: update golden test files for Copilot CLI bump to 1.0.21#25692
Conversation
v1.0.20 crashes silently (exitCode=1, 0B output) in the v0.67.4+ runtime. v1.0.21 was the last confirmed working version before v1.0.22 introduced a startup hang (fixed in v1.0.23). Pinning to v1.0.21 to unblock Copilot-engine workflows while we validate whether v1.0.23 is safe for broader adoption. Refs #25680 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…o 1.0.21 Agent-Logs-Url: https://github.com/github/gh-aw/sessions/f756f5d2-7541-402c-bf01-dba5b76cf718 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates pinned GitHub Copilot CLI version references from 1.0.20 to 1.0.21 across golden test fixtures and locked workflow YAMLs to align with the bumped default Copilot CLI version and fix failing wasm golden tests.
Changes:
- Bump
DefaultCopilotVersionto1.0.21. - Refresh wasm golden fixtures to reflect
1.0.21(env metadata + install step). - Update multiple locked workflow YAMLs to install/report Copilot CLI
1.0.21.
Show a summary per file
| File | Description |
|---|---|
| pkg/constants/version_constants.go | Bumps the default Copilot CLI version constant to 1.0.21. |
| pkg/workflow/test-yaml-import.lock.yml | Updates pinned Copilot CLI install version to 1.0.21 in YAML import lock test data. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.golden | Updates wasm compile-fixture golden output to 1.0.21. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/smoke-copilot.golden | Updates wasm compile-fixture golden output to 1.0.21. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.golden | Updates wasm compile-fixture golden output to 1.0.21. |
| pkg/workflow/testdata/wasm_golden/WasmBinary/basic-copilot.golden | Updates wasm binary golden output to 1.0.21. |
| pkg/workflow/testdata/wasm_golden/WasmBinary/with-imports.golden | Updates wasm binary golden output to 1.0.21. |
| .github/workflows/ace-editor.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/agent-performance-analyzer.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/agent-persona-explorer.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/agentic-observability-kit.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/archie.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/architecture-guardian.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/artifacts-summary.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/auto-triage-issues.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/bot-detection.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/brave.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/breaking-change-checker.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/ci-coach.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/cli-consistency-checker.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/code-scanning-fixer.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/code-simplifier.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/contribution-check.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/constraint-solving-potd.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/copilot-cli-deep-research.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/copilot-pr-merged-report.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/copilot-pr-nlp-analysis.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/copilot-pr-prompt-analysis.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/copilot-token-audit.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/copilot-token-optimizer.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/craft.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-architecture-diagram.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-assign-issue-to-user.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-cli-performance.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-cli-tools-tester.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-community-attribution.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-compiler-quality.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-file-diet.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-firewall-report.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-integrity-analysis.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-issues-report.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-malicious-code-scan.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-mcp-concurrency-analysis.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-news.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-performance-summary.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-regulatory.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-repo-chronicle.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-safe-output-integrator.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-secrets-analysis.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-semgrep-scan.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-syntax-error-quality.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-team-status.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-testify-uber-super-expert.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/daily-workflow-updater.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/dead-code-remover.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/delight.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/dependabot-burner.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/dependabot-go-checker.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/dev-hawk.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/dev.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/dictation-prompt.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/discussion-task-miner.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/docs-noob-tester.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/draft-pr-cleanup.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/example-permissions-warning.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/firewall-escape.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/firewall.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/functional-pragmatist.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/github-remote-mcp-auth-test.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/glossary-maintainer.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/gpclean.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/issue-monster.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/issue-triage-agent.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/jsweep.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/layout-spec-maintainer.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/mcp-inspector.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/mergefest.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/metrics-collector.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/notion-issue-summary.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/org-health-report.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/pdf-summary.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/plan.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/poem-bot.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/portfolio-analyst.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/pr-nitpick-reviewer.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/pr-triage-agent.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/python-data-charts.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/q.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/refactoring-cadence.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/refiner.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/release.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/repo-audit-analyzer.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/repo-tree-map.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/repository-quality-improver.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/research.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/security-compliance.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/security-review.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/slide-deck-maintainer.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/smoke-copilot-arm.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/smoke-copilot.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/smoke-create-cross-repo-pr.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/smoke-multi-pr.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/smoke-project.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/smoke-service-ports.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/smoke-temporary-id.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/smoke-test-tools.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/smoke-update-cross-repo-pr.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/smoke-workflow-call-with-inputs.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/smoke-workflow-call.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/stale-repo-identifier.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/sub-issue-closer.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/super-linter.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/technical-doc-writer.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/terminal-stylist.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/test-dispatcher.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/test-project-url-default.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/test-quality-sentinel.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/test-workflow.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/tidy.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/ubuntu-image-analyzer.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/update-astro.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/video-analyzer.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/weekly-blog-post-writer.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/weekly-editors-health-check.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/weekly-issue-summary.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/weekly-safe-outputs-spec-review.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/workflow-generator.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/workflow-health-manager.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/workflow-normalizer.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
| .github/workflows/workflow-skill-extractor.lock.yml | Updates pinned Copilot CLI version metadata/install to 1.0.21 in locked workflow. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 130/130 changed files
- Comments generated: 2
| // | ||
| // When unpinning or upgrading this version, verify: | ||
| // - MCPs are not blocked from loading (tools.mcp configuration still works end-to-end) | ||
| // - /models does not silently fail on PATs (check that model listing works with PAT auth) | ||
| const DefaultCopilotVersion Version = "1.0.20" | ||
| const DefaultCopilotVersion Version = "1.0.21" |
There was a problem hiding this comment.
This bumps DefaultCopilotVersion to 1.0.21, but there are existing changeset notes indicating Copilot CLI was intentionally pinned to 1.0.20 due to a silent startup crash in 1.0.21 (see .changeset/patch-bump-claude-copilot-default-versions.md:5 and .changeset/patch-bump-cli-versions-2026-04-10.md:5). Please reconcile this (confirm the crash is resolved / safe to bump, and update or remove the stale changeset notes). Also note there is still at least one workflow lock file pinning 1.0.20 (pkg/cli/workflows/example-blocked-domains.lock.yml), which may need to be updated for consistency if 1.0.21 is now the supported default.
| GH_AW_INFO_ENGINE_ID: "copilot" | ||
| GH_AW_INFO_ENGINE_NAME: "GitHub Copilot CLI" | ||
| GH_AW_INFO_MODEL: ${{ vars.GH_AW_MODEL_AGENT_COPILOT || 'auto' }} | ||
| GH_AW_INFO_VERSION: "1.0.20" | ||
| GH_AW_INFO_AGENT_VERSION: "1.0.20" | ||
| GH_AW_INFO_VERSION: "1.0.21" | ||
| GH_AW_INFO_AGENT_VERSION: "1.0.21" |
There was a problem hiding this comment.
The PR description lists only a handful of golden/lock files being updated, but this change also updates many .github/workflows/*.lock.yml files (and bumps DefaultCopilotVersion). Please update the PR description/change list to reflect the full scope so reviewers and release notes consumers aren’t surprised by the breadth of workflow lockfile updates.
Summary
Fixes the failing
TestWasmGolden_CompileFixturestests caused by a stale version reference in golden files after bumping Copilot CLI from1.0.20to1.0.21.Root Cause
The golden test files and
test-yaml-import.lock.ymlstill referenced the old Copilot CLI version1.0.20, while the code was updated to install version1.0.21. This caused the wasm golden tests to fail with a diff like:Changes
Updated version string from
1.0.20→1.0.21in:pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.goldenpkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.goldenpkg/workflow/testdata/TestWasmGolden_CompileFixtures/smoke-copilot.goldenpkg/workflow/testdata/wasm_golden/WasmBinary/basic-copilot.goldenpkg/workflow/testdata/wasm_golden/WasmBinary/with-imports.goldenpkg/workflow/test-yaml-import.lock.ymlCloses #70835248152