Conversation
Add three new checks and enhance CI-002 to close gaps between the Safe Outputs spec (v1.16.0, added in d1c210e) and the conformance script: - CI-002: Add CI9 check — verify setup script aborts and exits non-zero on merge failure, not just that 'git merge' is present (Section 11.6) - MCE-003 (new): MCE5 — verify constraint limits (65536/10/50) in comment_limit_helpers.cjs match those in safe_outputs_tools.json to catch silent limit drift between tool descriptions and enforcement (Section 8.3 MCE5) - CI-003 (new): CI3+CI4 — verify cache_integrity.go uses crypto/sha256 for policy hash computation and declares the 'nopolicy' sentinel for workflows without a guard policy (Section 11.4) - CI-004 (new): CI5 — verify .git directory is excluded from cache memory file validation steps (Section 11.5) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Hey Checklist summary:
Verdict: 🟢 Aligned — all contribution guidelines met. The PR targets a single file (
|
pelikhan
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Safe Outputs conformance checker script to close gaps identified after reviewing the Safe Outputs specification (v1.16.0) added in d1c210e.
Specification Changes Reviewed
d1c210eaddeddocs/src/content/docs/reference/safe-outputs-specification.md(v1.16.0) andscripts/check-safe-outputs-conformance.shtogether. Gap analysis against the 4,794-line W3C-style spec revealed four missing checks.📋 Script Updates & Testing Details
Script Updates
Checks Enhanced
git merge. Previously only checked for the presence of merge commands.New Checks Added
MCE-003: Validates MCE5 (Constraint Configuration Consistency, Section 8.3). Verifies that the comment constraint limits declared in
comment_limit_helpers.cjs(65536 chars, 10 mentions, 50 links) match those documented insafe_outputs_tools.json. Inconsistent limits between the two layers would silently allow the MCP server and safe output processor to enforce different values.CI-003: Validates CI3 + CI4 (Section 11.4). Verifies that
cache_integrity.gousescrypto/sha256for the policy hash and declares thenopolicysentinel string for workflows without a guard policy. These are security-critical properties ensuring cache isolation across integrity levels.CI-004: Validates CI5 (Section 11.5). Verifies that the cache memory setup script references
.gitexclusion logic. The spec requires file validation steps to skip the.gitdirectory because it contains binary/extension-less files not managed by the agent.Testing
All new checks pass against the current implementation. No pre-existing failures introduced.
Related Files
docs/src/content/docs/reference/safe-outputs-specification.mdscripts/check-safe-outputs-conformance.sh