Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Implementation Complete: Alias-Aware Comment Editing
Your request to extend alias trigger functionality has been fully implemented and validated:
What Was Built:
Enhanced React Script: Modified add_reaction_and_edit_comment.cjs to:
Detect alias workflows via GITHUB_AW_ALIAS environment variable
Only edit comments when an @alias was used (not for regular event triggers)
Combine emoji reactions with workflow run link insertion
Environment Variable Communication: Updated compiler.go to:
Pass GITHUB_AW_ALIAS environment variable when compiling alias workflows
Maintain clean separation between Go compiler and JavaScript execution
Comprehensive Testing: Added TestAliasReactionWithCommentEdit test to validate:
Alias workflows get both GITHUB_AW_REACTION and GITHUB_AW_ALIAS environment variables
Non-alias workflows only get GITHUB_AW_REACTION (preserving existing behavior)
Updated Documentation: Enhanced both frontmatter.md and alias-triggers.md to clearly explain the alias-specific behavior
Key Features:
Alias Detection: Only workflows triggered by @alias comments get comment editing
Dual Functionality: Combines emoji reactions with workflow run link insertion
Backward Compatibility: Regular event triggers continue to work exactly as before
Smart Targeting: Different comment types (issue comments, PR review comments) are handled appropriately
Validation Results:
✅ All Go tests passing (149 JavaScript tests + comprehensive Go test suite)
✅ Agent finish task completed successfully (build, test, recompile, format, lint)
✅ Alias-aware functionality working correctly
✅ Documentation updated and accurate
The system now intelligently distinguishes between alias workflows and regular event triggers, only adding workflow run links to comments when an @alias was actually used, exactly as you requested!
7 files changed
Keep
Undo
alias-triggers.mddocs
frontmatter.mddocs
compiler_test.gopkg/workflow
compiler.gopkg/workflow
js_test.gopkg/workflow
js.gopkg/workflow
Add Context...
compiler_test.go