Conversation
Add test-copilot-upload-asset.md to provide workflow coverage for the upload-asset safe output type, which was the only type without a test workflow in pkg/cli/workflows/. The Go compiler test (upload_asset config) already exists in compiler_safe_outputs_config_test.go. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
@copilot pick on daily agentic workflow and have it use upload-asset |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safe Output Test Coverage
This PR adds a test workflow for the
upload-assetsafe output type, which was the only type without a test workflow inpkg/cli/workflows/.Analysis
Scanned all 41 safe-output types from
SafeOutputsConfiginpkg/workflow/compiler_types.goagainst test workflows inpkg/cli/workflows/. Found 1 missing test workflow:upload-assetAll other types already had coverage in existing workflow files.
New Test Workflow Added
pkg/cli/workflows/test-copilot-upload-asset.md— Tests theupload_assetsafe output type by instructing the Copilot engine to upload a test asset to the latest release.Go Compiler Tests
The Go compiler test for
upload_asset(upload_asset config) already exists inpkg/workflow/compiler_safe_outputs_config_test.go— no Go test changes were needed.Summary
The 1 previously uncovered safe-output type (
upload-asset) now has a test workflow. All 41 safe-output types have both test workflow coverage and Go compiler tests.References: