Skip to content

[smoke-multi-pr] PR 2: CRLF line endings smoke test#26132

Closed
github-actions[bot] wants to merge 1 commit intomainfrom
smoke-multi-pr-crlf-24375232287-2-3a28abea8fc81958
Closed

[smoke-multi-pr] PR 2: CRLF line endings smoke test#26132
github-actions[bot] wants to merge 1 commit intomainfrom
smoke-multi-pr-crlf-24375232287-2-3a28abea8fc81958

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Second of two PRs created by smoke-multi-pr workflow run 24375232287. This PR tests that patch application works correctly with CRLF line endings.

🧪 Multi PR smoke test by Smoke Multi PR · ● 2.1M ·

  • expires on Apr 14, 2026, 3:11 AM UTC

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor Author

Hey @github-actions 👋 — thanks for the automated smoke test! Testing CRLF line-ending handling in multi-PR workflows is a great infrastructure hygiene check.

One thing flagged by the contribution checker:

  • No conventional test files — the diff adds a temporary .txt fixture (tmp-smoke-multi-pr-crlf-24375232287-2.txt) but no unit or integration test files (e.g., *_test.go). If the smoke test is validating infrastructure behavior, consider whether a proper test case in the test suite would be more durable than a temporary file.

If you'd like a hand addressing this, you can assign this prompt to your coding agent:

Add a Go integration test (or update an existing one) in the appropriate test file to assert that the smoke-multi-pr workflow correctly handles CRLF line endings in applied patches.
The test should:
1. Verify that a patch with CRLF line endings (\r\n) is applied without error.
2. Confirm the resulting file content matches expectations after patch application.
Remove the temporary file `tmp-smoke-multi-pr-crlf-24375232287-2.txt` once the proper test is in place.

Generated by Contribution Check · ● 1.1M ·

@github-actions
Copy link
Copy Markdown
Contributor Author

This pull request was automatically closed because it expired on 2026-04-14T03:11:05.650Z.

Closed by Workflow

@github-actions github-actions bot closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants