fix: propagate context through all CLI subprocess calls for Ctrl-C cancellation

[dsyme]

Problem

Pressing Ctrl-C during long-running gh aw commands (e.g. audit, logs, update) would register the interrupt but background operations — artifact downloads, log fetches, workflow file downloads, git operations — would continue printing output long after the user had returned to the prompt.

The root cause: signal.NotifyContext in main.go sets up context cancellation correctly, but many functions deep in pkg/cli/ called workflow.RunGH / RunGHCombined (non-context variants) or bare exec.Command (no context), so the cancellation signal never reached those subprocesses.

Changes

Thread context.Context through the full call chain for all gh CLI subprocess invocations and git operations:

• pkg/workflow/github_cli.go — add RunGHCombinedContext
• pkg/cli/download_workflow.go — add ctx to downloadWorkflowContent, downloadWorkflowContentViaGit, downloadWorkflowContentViaGitClone; all exec.Command → exec.CommandContext
• pkg/cli/update_workflows.go — pass ctx to all downloadWorkflowContent calls
• pkg/cli/update_actions.go — exec.Command("git", "ls-remote", ...) → exec.CommandContext
• pkg/cli/audit.go — add ctx to fetchWorkflowRunMetadata, resolveWorkflowDisplayName, renderAuditReport
• pkg/cli/audit_comparison.go — add ctx to findPreviousSuccessfulWorkflowRuns, buildAuditComparisonForRun
• pkg/cli/audit_diff.go — add ctx to loadRunSummaryForDiff
• pkg/cli/audit_diff_command.go — pass ctx to loadRunSummaryForDiff calls
• pkg/cli/logs_download.go — add ctx to downloadWorkflowRunLogs, listRunArtifactNames, downloadArtifactsByName, retryCriticalArtifacts, downloadRunArtifacts; use ExecGHContext / RunGHContext
• pkg/cli/logs_orchestrator.go — pass ctx to downloadRunArtifacts in the concurrent pool goroutine
• pkg/cli/trial_runner.go — add ctx to getCurrentGitHubUsername
• All affected test files updated accordingly

This is a continuation of the earlier fix that threaded context through the update command pipeline (update_actions.go, update_workflows.go, update_command.go, upgrade_command.go).

[Copilot]

Pull request overview

This PR ensures Ctrl-C cancellation propagates through the full CLI call chain by threading context.Context into gh/git subprocess execution paths, preventing background operations from continuing after an interrupt.

Changes:

• Added context-aware gh helpers (e.g., RunGHCombinedContext) and updated call sites to use *Context variants.
• Threaded context.Context through workflow update, audit, logs download, and trial execution code paths.
• Updated unit tests to match the new context-aware function signatures.

Show a summary per file

File	Description
pkg/workflow/github_cli.go	Adds RunGHCombinedContext to support cancelable combined-output gh calls with spinner.
pkg/cli/upgrade_command.go	Passes ctx into action update pipeline during upgrade.
pkg/cli/update_workflows.go	Threads ctx through workflow update resolution and gh api calls.
pkg/cli/download_workflow.go	Converts git subprocesses to exec.CommandContext and threads ctx through download helpers.
pkg/cli/update_command.go	Passes ctx into workflow/action update steps.
pkg/cli/update_actions.go	Adds ctx to action update + action-ref rewriting pipelines; uses context-aware gh/git subprocess calls.
pkg/cli/trial_runner.go	Threads ctx into gh api user lookup for default trial repo selection.
pkg/cli/logs_orchestrator.go	Passes ctx into concurrent artifact download tasks.
pkg/cli/logs_download.go	Threads ctx through log/artifact download helpers; uses ExecGHContext / RunGHContext.
pkg/cli/audit.go	Threads ctx through metadata fetch, display-name resolution, and report rendering.
pkg/cli/audit_comparison.go	Adds ctx to comparison discovery and baseline processing paths.
pkg/cli/audit_diff.go	Threads ctx through run-summary loading (artifact download path).
pkg/cli/audit_diff_command.go	Passes ctx into diff summary loading calls.
pkg/cli/update_workflows_test.go	Updates tests for context-aware releases API stub + resolver signatures.
pkg/cli/update_actions_test.go	Updates tests for context-aware action-release/tag resolution stubs and call sites.
pkg/cli/update_command_test.go	Updates tests for context-aware action/workflow resolution helpers.
pkg/cli/logs_download_test.go	Updates tests for context-aware retry helper signature.
pkg/cli/audit_test.go	Updates tests for context-aware audit helpers.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 19/19 changed files
• Comments generated: 2

[github-actions]

Hey @dsyme 👋 — great work threading context.Context through the full CLI subprocess call chain to fix Ctrl-C cancellation! This is exactly the kind of focused, well-scoped fix the project needs, and the comprehensive coverage across audit, logs, update, and download_workflow code paths is thorough.

The PR looks solid — it's well-described, includes test updates across all affected files, and doesn't introduce any new dependencies. This looks ready for maintainer review! 🎉

Generated by Contribution Check · ● 1.5M · ◷