Fix template injection vulnerability in git config user.name#2640
Merged
Conversation
Replace user-controllable github.workflow expression with static "github-actions[bot]" string to prevent template injection attacks. This matches the email pattern and eliminates the security risk. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update generated code to avoid using github.workflow as a user name
Fix template injection vulnerability in git config user.name
Oct 27, 2025
Contributor
|
Agentic Changeset Generator triggered by this pull request. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a template injection security vulnerability in GitHub Actions workflow files by replacing the user-controllable ${{ github.workflow }} expression with a static string for git configuration.
Key Changes:
- Updated the Go code generator to use a hardcoded bot username instead of a dynamic workflow name
- Regenerated all 56 affected workflow lock files with the secure configuration
Reviewed Changes
Copilot reviewed 58 out of 58 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/workflow/yaml_generation.go | Modified generator to output static "github-actions[bot]" username instead of ${{ github.workflow }} expression |
| .github/workflows/go.mod | Added empty require block to go.mod structure |
| .github/workflows/*.lock.yml (56 files) | Regenerated workflow files with fixed git config using static username |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The git configuration step used
${{ github.workflow }}for user.name, which is user-controllable via workflow filenames and enables template injection attacks.Changes
pkg/workflow/yaml_generation.go: Replace${{ github.workflow }}with static string"github-actions[bot]".github/workflows/*.lock.yml: Regenerate 56 workflow files with fixed configurationBefore/After
The username now matches the email pattern (
github-actions[bot]@users.noreply.github.com) and eliminates the injection vector.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.