Rename `NewWorkflow` → `CreateWorkflowMarkdownFile` by Copilot · Pull Request #26425 · github/gh-aw

Copilot · 2026-04-15T13:10:04Z

NewWorkflow violates Go convention where New* signals a constructor returning an in-memory object — this function writes a file to disk and returns error. AI agents searching for "create workflow file" logic may incorrectly skip it.

Changes

pkg/cli/commands.go — rename function definition
cmd/gh-aw/main.go — update call site
pkg/cli/commands_test.go — rename test and internal call
pkg/cli/README.md — update API reference table

// Before
func NewWorkflow(workflowName string, verbose bool, force bool, engine string) error

// After
func CreateWorkflowMarkdownFile(workflowName string, verbose bool, force bool, engine string) error

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/graphql
- Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw k/gh-aw/gh-aw/pkrev-parse ache/go/1.25.8/x--show-toplevel git rev-�� --show-toplevel ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /usr/bin/git /tmp/go-build489git -trimpath 6404235/b208/vet--show-toplevel git (http block)
https://api.github.com/orgs/test-owner/actions/secrets
- Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
- Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha --git-dir x_amd64/link /usr/bin/git rtcfg .cfg 64/pkg/tool/linu--show-toplevel /usr/bin/git conf�� --get-regexp ^remote\..*\.gh-resolved$ /usr/bin/git rtcfg GO111MODULE 64/pkg/tool/linu--show-toplevel git (http block)
https://api.github.com/repos/actions/checkout/git/ref/tags/v3
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha --show-toplevel (http block)
https://api.github.com/repos/actions/checkout/git/ref/tags/v5
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha se 6404235/b052/vet.cfg .cfg GOSUMDB GOWORK 64/bin/go ache/go/1.25.8/x^remote\..*\.gh-resolved$ -o 435196/b202/importcfg -trimpath ache/go/1.25.8/x64/pkg/tool/linu-nolocalimports -p internal/godebugrev-parse -lang=go1.25 ache/go/1.25.8/x64/pkg/tool/linu/tmp/go-build1626404235/b438/_testmain.go (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git 435196/b196/_pkggit HJpH/bR5uMPu5Fr3rev-parse x_amd64/compile git rev-�� it/ref/tags/v4 x_amd64/compile /usr/bin/git se 6404235/b037/vetrev-parse .cfg git (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha --show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /usr/bin/git licyBlockedUsersgit 6404235/b393/_terev-parse /opt/hostedtoolc--show-toplevel git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/link otOrdering3505378078/001/go/1.25.0/x64/bin/go /tmp/go-build162git -importcfg /usr/bin/git git (http block)
https://api.github.com/repos/actions/github-script/git/ref/tags/v8
- Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha --show-toplevel ache/go/1.25.8/x64/pkg/tool/linu--jq /usr/bin/git se 6404235/b065/vetinit .cfg git rev-�� --show-toplevel ache/go/1.25.8/x^remote\..*\.gh-resolved$ /usr/bin/git 1710-32393/test-git 6404235/b226/vetrev-parse ache/go/1.25.8/x--show-toplevel git (http block)
https://api.github.com/repos/actions/github-script/git/ref/tags/v9
- Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq .object.sha -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json x86.go x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq .object.sha -json 2/compile.go x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq .object.sha -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/vet GOINSECURE GOMOD sm_wasm.s x_amd64/vet (http block)
https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
- Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha /home/REDACTED/work/gh-aw/gh-aw/.github/workflows/agent-performance-analyzer.md x_amd64/vet /usr/bin/git 8/001 GO111MODULE x_amd64/link git rev-�� --show-toplevel x_amd64/link /usr/bin/git -json GO111MODULE 64/pkg/tool/linu--show-toplevel git (http block)
https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
- Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha /home/REDACTED/work/gh-aw/gh-aw/.github/workflows/ace-editor.md x_amd64/vet /usr/bin/git 994259/001 GO111MODULE x_amd64/vet git rev-�� --show-toplevel x_amd64/vet /usr/bin/git t5smDhwOz GO111MODULE 64/pkg/tool/linu--show-toplevel git (http block)
https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v4
- Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq .object.sha 6404235/b432/_pkg_.a -test.v=true 6404235/b432=> -test.timeout=10git -test.run=^Test -test.short=true--show-toplevel infocmp -1 ons-test1716862235 x_amd64/compile /usr/bin/git -json GO111MODULE x_amd64/compile git (http block)
https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v7
- Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v7 --jq .object.sha 5052/001/stabilitest-logs/run-4 6404235/b205/vet.cfg .cfg -p internal/poll -lang=go1.25 ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet -o 1710-32393/test-2532556821/.github/workflows -trimpath /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/compile -p golang.org/x/texrev-parse -lang=go1.25 /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v7 --jq .object.sha se 6404235/b262/vet.cfg g_.a -p github.com/modelrev-parse -lang=go1.25 6404235/b070/gh-aw.test e=/t�� t0 /tmp/go-build1626404235/b019/vet.cfg (http block)
- Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v7 --jq .object.sha 1710-32393/test-668405126 -trimpath 6404235/b170/vet.cfg -p net/http/internarev-parse -lang=go1.25 /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet -ato�� architecture-guardian.md -buildtags kflows/test.lock.yml -errorsas -ifaceassert -nilfunc /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0.1.2
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq .object.sha --get remote.myorg.url /usr/bin/git rity1205592973/0git GO111MODULE nch,headSha,disp--show-toplevel git rev-�� --show-toplevel x_amd64/vet 6404235/b451/vet.cfg gk88dzu3u GO111MODULE 64/pkg/tool/linu--show-toplevel git (http block)
https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.0.0
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq .object.sha /tmp/go-build1626404235/b412/_pkg_.a -trimpath ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet -p main -lang=go1.25 ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet rev-�� --show-toplevel -dwarf=false /usr/bin/git go1.25.8 -c=4 -nolocalimports git (http block)
https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.2.3
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq .object.sha --show-toplevel -tests /usr/bin/git -json GO111MODULE x_amd64/asm git rev-�� ons-test1716862235 x_amd64/asm ow-without-reaction.lock.yml -json GO111MODULE x_amd64/compile git (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
- Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 2143782843 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE g/x/text/unicoderev-parse 435196/b092/syma--show-toplevel 64/pkg/tool/linux_amd64/vet (http block)
- Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD 435196/b007/syma--show-toplevel 64/pkg/tool/linux_amd64/vet ache�� edcfg 7Ps3/Xuna8G_bMUX3GMM57Ps3 ache/go/1.25.8/x64/pkg/tool/linu-lang=go1.25 GOINSECURE g/x/net/http/httrev-parse GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linurev-parse (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
- Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE l/buffer GOMODCACHE 64/pkg/tool/linux_amd64/vet env thub/workflows o 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linuorigin (http block)
- Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 .cfg 64/pkg/tool/linu-nolocalimports GOINSECURE fips140deps/godeconfig GOMODCACHE 64/pkg/tool/linutest@example.com env 2348660077 V4ci/NWzImF-917Hk3aRqV4ci ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE g/x/crypto/chachconfig GOMODCACHE ache/go/1.25.8/xremote.origin.url (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
- Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name .cfg 64/pkg/tool/linu-importcfg GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linu/home/REDACTED/work/gh-aw/gh-aw/pkg/styles/theme.go env thub/workflows l_test.go ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE fips140/ecdsa GOMODCACHE ache/go/1.25.8/xTest User (http block)
- Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linuTest User env 435196/b178/_pkg_.a QuTc/8J1aAAdvjhK6D-KwQuTc .cfg GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/xremote.origin.url (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
- Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name .cfg 64/pkg/tool/linu-importcfg GOINSECURE fips140/sha256 GOMODCACHE 64/pkg/tool/linu/home/REDACTED/work/gh-aw/gh-aw/pkg/timeutil/format_test.go env 435196/b220/_pkg_.a t2Bi/LbyKJAzlPTfrrG8ct2Bi ache/go/1.25.8/x64/pkg/tool/linux_amd64/link GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/link (http block)
- Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 rg/x/text@v0.36.0/internal/language/common.go 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD 435196/b013/syma--show-toplevel 64/pkg/tool/linux_amd64/vet env 2532556821 r73k/ZR15bOYtzO_sNGC5r73k k GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
- Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE fips140 GOMODCACHE 64/pkg/tool/linux_amd64/vet env 435196/b219/_pkg_.a go ache/go/1.25.8/x64/pkg/tool/linux_amd64/link GOINSECURE g/x/text/unicoderev-parse GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-trimpath (http block)
- Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD 435196/b007/syma--show-toplevel 64/pkg/tool/linux_amd64/vet env 435196/b221/_pkg_.a 435196/b007/importcfg eutil.test GOINSECURE g/x/net/http/httrev-parse GOMODCACHE eutil.test (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
- Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 2143782843 .cfg x_amd64/link GOINSECURE hpke GOMODCACHE x_amd64/link (http block)
- Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 2532556821/.github/workflows GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE t/internal/langurev-parse GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
- Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE fips140/sha3 GOMODCACHE 64/pkg/tool/linuTest User env 435196/b222/_pkg_.a Ldjv/q8rDzC5dO2KyVIFwLdjv .cfg GOINSECURE g/x/net/http2/hprev-parse GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linurev-parse (http block)
- Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 tFbR/0ecu5sPzUYfZW5eqtFbR 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 435196/b252/_pkg_.a fWCy/na03iXLzDBM34i--fWCy .cfg GOINSECURE b/gh-aw/pkg/giturev-parse GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linuremote (http block)
https://api.github.com/repos/github/gh-aw/actions/workflows
- Triggering command: /usr/bin/gh gh workflow list --json name,state,path -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD cpu/cpu.s x_amd64/compile (http block)
- Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 GOMOD GOMODCACHE x_amd64/vet env json ]; then \ cp .github/aw/ac-errorsas GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
- Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 435196/b011/ GOMODCACHE 64/pkg/tool/linuremote2 env 435196/b177/_pkg_.a .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE fips140/edwards2rev-parse ache/go/1.25.8/x--show-toplevel 64/pkg/tool/linux_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/git/ref/tags/v0.47.4
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq .object.sha --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git GgAk/DJ3JnFq1XLtgit .cfg x_amd64/compile git rev-�� 078/001/go/1.25.0/x64"; export PATH="$(find "/tmp/TestGetNpmBinPathSetup_GorootOrdering350537807git x_amd64/compile /usr/bin/git efaultBranchFromgit efaultBranchFromrev-list ache/go/1.25.8/x--count git (http block)
https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha edOutput542262183/001 .cfg x_amd64/vet GOINSECURE fips140/rsa GOMODCACHE x_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.2.3
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq .object.sha -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet env flags="-w -s" -o gh-aw.wasm ./cm-errorsas GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/git/ref/tags/v2.0.0
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq .object.sha -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet env -json at.go x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq .object.sha -json GO111MODULE x_amd64/vet GOINSECURE mcpgodebug GOMODCACHE x_amd64/vet env -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE iE8t3kR/vbNrLVZ2rev-parse (http block)
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq .object.sha adata/main.go GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env Gitmain_branch1542725380/001' Gitmain_branch1542725380/001' x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
https://api.github.com/repos/github/gh-aw/git/ref/tags/v3.0.0
- Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq .object.sha -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet env -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999
- Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha 435196/b170/_pkg_.a .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD 435196/b011/symauser.email 64/pkg/tool/linutest@example.com (http block)
https://api.github.com/repos/nonexistent/repo/actions/runs/12345
- Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE boring GOMODCACHE 64/pkg/tool/linux_amd64/vet env 435196/b141/_pkg_.a 3NxN/fOrMapTM_SttVIFB3NxN ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE contextprotocol/rev-parse GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-importcfg (http block)
https://api.github.com/repos/owner/repo/actions/workflows
- Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
https://api.github.com/repos/owner/repo/contents/file.md
- Triggering command: /tmp/go-build1626404235/b397/cli.test /tmp/go-build1626404235/b397/cli.test -test.testlogfile=/tmp/go-build1626404235/b397/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
https://api.github.com/repos/test-owner/test-repo/actions/secrets
- Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/de690d8b-e59d-4c19-8973-8cecbd0a79c0 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

Renames the exported workflow-template creation helper to better match Go naming conventions and clarify that it writes a file to disk.

Changes:

Renamed NewWorkflow → CreateWorkflowMarkdownFile in pkg/cli.
Updated the CLI call site to use the new function name.
Renamed the corresponding unit test and updated the API reference table in docs.

Show a summary per file

File	Description
`pkg/cli/commands.go`	Renames the exported function to reflect file-creation side effects.
`cmd/gh-aw/main.go`	Updates `gh aw new` to call `CreateWorkflowMarkdownFile`.
`pkg/cli/commands_test.go`	Renames the test and updates the invocation to the new API.
`pkg/cli/README.md`	Updates the public API reference table entry.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 4/4 changed files
Comments generated: 0

github-actions · 2026-04-15T13:31:01Z

Hey @Copilot 👋 — great catch on the Go naming convention! Renaming NewWorkflow → CreateWorkflowMarkdownFile is a clear improvement: the New* prefix carries a strong semantic contract in Go (in-memory constructor, no side effects), and this function writes to disk and returns error, so the old name was genuinely misleading.

The PR is tightly scoped — all four affected sites (implementation, call site, test, and README API table) are updated consistently, no dependency changes, tests are included, and the description clearly explains both the what and the why.

This PR looks ready for maintainer review. ✅

Generated by Contribution Check · ● 1.6M · ◷

github-actions · 2026-04-15T13:32:34Z

🧪 Test Quality Sentinel Report

Test Quality Score: 100/100

✅ Excellent test quality

Metric	Value
New/modified tests analyzed	1
✅ Design tests (behavioral contracts)	1 (100%)
⚠️ Implementation tests (low value)	0 (0%)
Tests with error/edge cases	1 (100%)
Duplicate test clusters	0
Test inflation detected	No
🚨 Coding-guideline violations	None

Test Classification Details

Test	File	Classification	Issues Detected
`TestCreateWorkflowMarkdownFile`	`pkg/cli/commands_test.go:408`	✅ Design	None — well-structured integration test

Analysis Notes

This PR is a pure rename refactoring: NewWorkflow → CreateWorkflowMarkdownFile. The only test change is renaming the test function and the function call inside it to match the production rename. No test logic was added or removed.

The test itself is high-quality:

✅ Build tag: //go:build integration (correct for integration test)
✅ Table-driven: 4 scenarios via t.Run() — happy path, no-force overwrite error, force overwrite, .md extension normalization
✅ Error coverage: Includes an expectedError: true row and verifies both error and non-error paths
✅ Behavioral contract: Verifies observable file-system outcomes (file existence, content) — not just that internal functions were called
✅ No mocks: Uses real file-system via os.MkdirTemp and os.Chdir
✅ Test inflation: 1:1 ratio — test file +2/-2, production file +2/-2

Score Breakdown

Component	Score	Notes
Behavioral Coverage (40 pts)	40/40	Test verifies file creation outcomes
Error/Edge Case Coverage (30 pts)	30/30	Includes error and edge cases
Low Duplication (20 pts)	20/20	No duplicate patterns
Proportional Growth (10 pts)	10/10	1:1 ratio, no inflation

Language Support

Tests analyzed:

🐹 Go (*_test.go): 1 test — integration (//go:build integration)

Verdict

✅ Check passed. 0% of new tests are implementation tests (threshold: 30%). This rename PR correctly updates the test function name and function call to match the production code rename, with no reduction in test quality.

📖 Understanding Test Classifications

Design Tests (High Value) verify what the system does:

Assert on observable outputs, return values, or state changes
Cover error paths and boundary conditions
Would catch a behavioral regression if deleted
Remain valid even after internal refactoring

Implementation Tests (Low Value) verify how the system does it:

Assert on internal function calls (mocking internals)
Only test the happy path with typical inputs
Break during legitimate refactoring even when behavior is correct
Give false assurance: they pass even when the system is wrong

Goal: Shift toward tests that describe the system's behavioral contract — the promises it makes to its users and collaborators.

References: §24457203666

🧪 Test quality analysis by Test Quality Sentinel · ● 614.9K · ◷

github-actions

✅ Test Quality Sentinel: 100/100. Test quality is excellent — 0% of new tests are implementation tests (threshold: 30%). This rename PR correctly tracks the production code rename with a well-structured integration test that verifies behavioral contracts.

Initial plan

d8ad2f7

Copilot AI assigned Copilot and pelikhan Apr 15, 2026

Copilot started work on behalf of pelikhan April 15, 2026 13:10 View session

Copilot AI linked an issue Apr 15, 2026 that may be closed by this pull request

[function-namer] Go function rename plan: codemod_timeout_minutes.go, codemod_upload_assets.go, codespace.go, commands.go, compile_batch_operatio [Content truncated due to length] #26402

Closed

10 tasks

rename NewWorkflow to CreateWorkflowMarkdownFile in pkg/cli

a5ed89a

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/de690d8b-e59d-4c19-8973-8cecbd0a79c0 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Refactor function names in CLI files for clarity~~ Rename NewWorkflow → CreateWorkflowMarkdownFile Apr 15, 2026

Copilot finished work on behalf of pelikhan April 15, 2026 13:23

Copilot AI requested a review from pelikhan April 15, 2026 13:23

pelikhan marked this pull request as ready for review April 15, 2026 13:27

Copilot AI review requested due to automatic review settings April 15, 2026 13:27

pelikhan merged commit 99cdb0e into main Apr 15, 2026
54 checks passed

pelikhan deleted the copilot/rename-functions-in-cli branch April 15, 2026 13:27

Copilot started reviewing on behalf of pelikhan April 15, 2026 13:28 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

This was referenced Apr 15, 2026

[aw] No-Op Runs #25214

Open

[Contribution Check Report] Contribution Check — 2026-04-15 #26376

Open

github-actions bot approved these changes Apr 15, 2026

View reviewed changes

This was referenced Apr 15, 2026

Smoke Test: Codex - 24462380478 #26460

Closed

fix: use absolute node path in AWF command to fix node: command not found on GPU runners + regenerate stale lock files #26427

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename `NewWorkflow` → `CreateWorkflowMarkdownFile`#26425

Rename `NewWorkflow` → `CreateWorkflowMarkdownFile`#26425
pelikhan merged 2 commits intomainfrom
copilot/rename-functions-in-cli

Copilot AI commented Apr 15, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

🧪 Test Quality Sentinel Report

Test Quality Score: 100/100

Test Classification Details

Analysis Notes

Score Breakdown

Language Support

Verdict

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 15, 2026 •

edited

Loading