Skip to content

Rename toolset to toolsets in GitHub tool configuration#2648

Merged
pelikhan merged 2 commits into
mainfrom
copilot/rename-toolset-to-toolsets
Oct 28, 2025
Merged

Rename toolset to toolsets in GitHub tool configuration#2648
pelikhan merged 2 commits into
mainfrom
copilot/rename-toolset-to-toolsets

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Oct 28, 2025

Aligns field naming with the GitHub MCP server's --toolsets flag and GITHUB_TOOLSETS environment variable convention.

Changes

Schema

  • Renamed toolsettoolsets in main_workflow_schema.json property definition and examples

Go code

  • mcp_servers.go: Updated getGitHubToolsets() to read toolsets field
  • mcp-config.go: Updated knownToolFields validation map

Tests

  • Updated all test cases and integration tests to use toolsets

Documentation & workflows

  • Updated field references in instructions and glossary
  • Updated 13 workflow files to use new field name

Migration

Old syntax is rejected with helpful error:

tools:
  github:
    toolset: [repos, issues]  # ❌ Error: Unknown property: toolset. Did you mean: toolsets

New syntax:

tools:
  github:
    toolsets: [repos, issues, pull_requests]  # ✅ Generates GITHUB_TOOLSETS=repos,issues,pull_requests

Reference: https://github.com/github/github-mcp-server#available-toolsets

Original prompt

Rename "tools: github: toolset:" to "tools: github: toolsets:" to align with the name in github mcp server (change the schema too) https://github.com/github/github-mcp-server?tab=readme-ov-file#available-toolsets


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

- Updated JSON schema: Changed "toolset" to "toolsets" in main_workflow_schema.json
- Updated Go code: Changed field reference in mcp_servers.go and mcp-config.go
- Updated all test files: Changed test cases to use "toolsets"
- Updated documentation: Changed .md files in .github/instructions/
- Updated workflow files: Changed all workflow .md files
- All tests passing
- Binary rebuilt with embedded schema

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Copilot AI changed the title [WIP] Rename toolset to toolsets in schema Rename toolset to toolsets in GitHub tool configuration Oct 28, 2025
Copilot AI requested a review from Mossaka October 28, 2025 00:30
@pelikhan pelikhan marked this pull request as ready for review October 28, 2025 00:33
Copilot AI review requested due to automatic review settings October 28, 2025 00:33
@github-actions
Copy link
Copy Markdown
Contributor

Agentic Changeset Generator triggered by this pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the toolset field to toolsets in GitHub tool configuration to align with the GitHub MCP server's naming conventions (--toolsets flag and GITHUB_TOOLSETS environment variable).

Key Changes:

  • Updated JSON schema property definition from toolset to toolsets
  • Modified Go code to read and validate the new field name
  • Updated all test cases and integration tests to use toolsets
  • Updated documentation and 13 workflow files to use the new field name

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/workflow/mcp_servers.go Changed field lookup from toolset to toolsets in getGitHubToolsets()
pkg/workflow/mcp-config.go Updated known field validation map to recognize toolsets
pkg/workflow/github_toolset_test.go Updated all unit test cases to use toolsets field
pkg/workflow/github_toolset_integration_test.go Updated integration test workflows to use toolsets field
pkg/parser/schemas/main_workflow_schema.json Renamed schema property and updated all examples
docs/src/content/docs/reference/frontmatter-full.md Updated documentation reference
.github/workflows/*.md Updated 13 workflow files to use new field name
.github/instructions/*.instructions.md Updated instructional content and glossary entries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pelikhan pelikhan merged commit 0047c09 into main Oct 28, 2025
52 of 53 checks passed
@pelikhan pelikhan deleted the copilot/rename-toolset-to-toolsets branch October 28, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants