Skip to content

Resolve CI golangci-lint failure in workflow action pin helpers#26531

Merged
pelikhan merged 1 commit intomainfrom
copilot/lint-go-fix-build-workflows
Apr 16, 2026
Merged

Resolve CI golangci-lint failure in workflow action pin helpers#26531
pelikhan merged 1 commit intomainfrom
copilot/lint-go-fix-build-workflows

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 16, 2026

The CI workflow failed in the Go lint step due to an unused helper in pkg/workflow/action_pins.go, which blocked build workflow completion. This update removes the dead wrapper to restore lint-clean execution.

  • Problem

    • golangci-lint reported getActionPinsByRepo as unused in the workflow action pin helper layer.
  • Change

    • Removed the unused package-private wrapper getActionPinsByRepo(repo string) []ActionPin.
    • Kept the rest of the action pin API surface unchanged to avoid behavioral impact.
  • Code delta (representative)

    // Removed unused wrapper:
    // func getActionPinsByRepo(repo string) []ActionPin {
    //     return actionpins.GetActionPinsByRepo(repo)
    // }

@pelikhan pelikhan marked this pull request as ready for review April 16, 2026 00:28
Copilot AI review requested due to automatic review settings April 16, 2026 00:28
@pelikhan pelikhan merged commit cb3de4e into main Apr 16, 2026
51 of 53 checks passed
@pelikhan pelikhan deleted the copilot/lint-go-fix-build-workflows branch April 16, 2026 00:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an unused package-private helper in pkg/workflow/action_pins.go to resolve a CI golangci-lint failure (unused function) without changing the public/internal action pinning behavior.

Changes:

  • Deleted the unused wrapper getActionPinsByRepo(repo string) []ActionPin that delegated to actionpins.GetActionPinsByRepo.
  • Left the remaining action pin helper/API surface in pkg/workflow unchanged.
Show a summary per file
File Description
pkg/workflow/action_pins.go Removes a dead wrapper function to restore lint-clean CI runs.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions github-actions bot mentioned this pull request Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants