Conversation
5 tasks
… lockfiles Agent-Logs-Url: https://github.com/github/gh-aw/sessions/87e804d1-7b3e-49b7-abf4-2ea07aff1cfe Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/87e804d1-7b3e-49b7-abf4-2ea07aff1cfe Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update static analysis report for 2026-04-15 findings
Suppress new poutine Apr 16, 2026
untrusted_checkout_exec findings in workflow_call smoke lockfiles
Collaborator
|
@copilot update the compiler code that generates those steps |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/c8f7005c-21c3-4652-a120-3ef8ddb95f74 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/c8f7005c-21c3-4652-a120-3ef8ddb95f74 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Updated to generate this in compiler code: added Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Suppress new poutine
Generate poutine Apr 16, 2026
untrusted_checkout_exec findings in workflow_call smoke lockfilesuntrusted_checkout_exec suppression for workflow_call save-base steps
pelikhan
approved these changes
Apr 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes newly reported poutine static-analysis untrusted_checkout_exec findings by ensuring the workflow compiler consistently emits an explicit suppression comment for the “save base GitHub folders” step that runs a trusted setup script from ${RUNNER_TEMP}/gh-aw/actions/.
Changes:
- Updated the workflow compiler to generate
# poutine:ignore untrusted_checkout_execimmediately before runningsave_base_github_folders.sh. - Recompiled the affected
workflow_callsmoke workflow lockfiles so the generated suppression is present. - Updated workflow compiler golden fixtures to match the newly generated YAML.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/pr.go |
Adds generation of the poutine suppression comment for the save-base step. |
.github/workflows/smoke-workflow-call.lock.yml |
Regenerated lockfile to include the suppression on the relevant step. |
.github/workflows/smoke-workflow-call-with-inputs.lock.yml |
Regenerated lockfile to include the suppression on the relevant step. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.golden |
Updates golden output to reflect the new generated suppression line. |
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.golden |
Updates golden output to reflect the new generated suppression line. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 0
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily static analysis reported new
poutineuntrusted_checkout_execfindings in the two workflow_call smoke workflows. The flagged executions were trusted setup scripts under${RUNNER_TEMP}/gh-aw/actions/but were missing explicit suppressions on one step in each lockfile.Problem context
untrusted_checkout_execfindings in:.github/workflows/smoke-workflow-call.lock.yml.github/workflows/smoke-workflow-call-with-inputs.lock.ymlChange made
pkg/workflow/pr.goingenerateSaveBaseGitHubFoldersStepto emit:# poutine:ignore untrusted_checkout_exec.github/workflows/smoke-workflow-call.lock.yml.github/workflows/smoke-workflow-call-with-inputs.lock.ymlpkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.goldenpkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.goldenWhy this location
save_base_github_folders.shfrom${RUNNER_TEMP}/gh-aw/actions/, populated by the trusted setup action in the same job, matching the intended suppression criteria from the report.