docs: clarify MCP gateway API key is leaked by design#26695
Merged
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/249a0e4a-598d-40a1-b6e6-8584bce9d02b Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/249a0e4a-598d-40a1-b6e6-8584bce9d02b Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 16, 2026 17:18
View session
Collaborator
pelikhan
approved these changes
Apr 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates documentation to clarify that the MCP Gateway API key available inside the agent container is not a strong security boundary and should be assumed compromised (“leaked by design”), aligning guidance with the security model discussed in #26584.
Changes:
- Add a warning to the MCP Gateway authentication reference noting the API key should not be treated as a secure lock against in-container code.
- Add a corresponding warning in the architecture/security overview describing the same limitation and recommended defense-in-depth controls.
Show a summary per file
| File | Description |
|---|---|
| docs/src/content/docs/reference/mcp-gateway.md | Adds a warning in the authentication section clarifying the gateway API key is not a strong boundary once code runs in-container. |
| docs/src/content/docs/introduction/architecture.mdx | Adds an architecture warning reinforcing “leaked by design” framing and pointing readers to isolation/network policy/permission staging as primary controls. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make build-docsand verify successful buildmake agent-finishbefore commit (fails on pre-existing unrelated testifylint issues inpkg/stats/spec_test.goandpkg/testutil/spec_test.go)