Merged
Conversation
- pkg/workflow/mcp_cli_mount.go: Add mcpCLIMountLog to trace MCP server selection decisions (feature flag checks, server list, mount step generation) - pkg/workflow/mcp_property_validation.go: Add mcpPropertyValidationLog to trace MCP type validation (explicit vs inferred type, per-tool validation entry) - pkg/workflow/build_input_schema.go: Add buildInputSchemaLog to trace input schema generation (per-input type/required, final property counts) - pkg/cli/gateway_logs_mcp.go: Reuse existing gatewayLogsLog to trace MCP tool usage extraction (log source selection, tool call counts, summary stats) - pkg/cli/logs_report_firewall.go: Add firewallReportLog to trace domain aggregation across runs (run count, final allowed/blocked domain counts) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds meaningful debug logging to 5 Go files that previously had no logging, improving troubleshooting capability when
DEBUG=*orDEBUG=workflow:*is set.Files changed
pkg/workflow/mcp_cli_mount.goworkflow:mcp_cli_mountpkg/workflow/mcp_property_validation.goworkflow:mcp_property_validationpkg/workflow/build_input_schema.goworkflow:build_input_schemapkg/cli/gateway_logs_mcp.gocli:gateway_logspkg/cli/logs_report_firewall.gocli:logs_report_firewallDesign notes
pkg:filenamenaming conventiongateway_logs_mcp.goreuses the package-levelgatewayLogsLogfromgateway_logs_types.go(no new logger needed)Test plan
make build— no compilation errorsgo test ./pkg/workflow/... ./pkg/cli/... -run 'Test[^W]')main)DEBUG=workflow:mcp_cli_mount,workflow:build_input_schema,workflow:mcp_property_validationorDEBUG=*🤖 Generated with [Claude Code]((claude.com/redacted)