[log] Add debug logging to 5 key Go files#2681
Merged
Conversation
This commit enhances the codebase with debug logging in 5 files that would benefit from better observability during development and troubleshooting. Files enhanced: - pkg/cli/logs.go: Added logging for job status checking, workflow log downloads, and concurrent download operations - pkg/cli/interactive.go: Added logging for interactive workflow creation and file generation steps - pkg/cli/workflows.go: Added logging for GitHub workflow fetching and status operations - pkg/cli/secrets.go: Added logging for secret extraction and validation operations - pkg/workflow/docker.go: Added logging for Docker image collection and validation operations All logging follows the project's guidelines from AGENTS.md: - Uses proper logger naming convention (pkg:filename) - No side effects in log arguments - Meaningful messages for debugging - Logs at function entry and important state changes These changes improve visibility when running with DEBUG=* environment variable, making it easier to diagnose issues and understand the execution flow during development. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
pelikhan
approved these changes
Oct 28, 2025
Copilot AI
added a commit
that referenced
this pull request
Oct 28, 2025
- Add ShortenCommand() to pkg/workflow/strings.go - Add comprehensive unit tests for ShortenCommand() - Update ClaudeEngine to use shared ShortenCommand() - Update CodexEngine to use shared ShortenCommand() - Remove duplicate implementations (7 lines per engine, 14 total) Fixes #2681 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the codebase with debug logging in 5 files that would benefit from better observability during development and troubleshooting. All changes follow the logging guidelines from
AGENTS.md.Files Enhanced
1.
pkg/cli/logs.go(2791 lines)logsLog = logger.New("cli:logs")2.
pkg/cli/interactive.go(488 lines)interactiveLog = logger.New("cli:interactive")3.
pkg/cli/workflows.go(148 lines)workflowsLog = logger.New("cli:workflows")4.
pkg/cli/secrets.go(142 lines)secretsLog = logger.New("cli:secrets")5.
pkg/workflow/docker.go(130 lines)dockerLog = logger.New("workflow:docker")Testing
✅ Build validation:
make buildcompleted successfully✅ Debug logging test: Ran
DEBUG=* ./gh-aw compile devand verified logging output from all enhanced filesExample debug output:
Logging Guidelines Compliance
All logging follows the project's guidelines from
AGENTS.md:pkg:filenamepattern (e.g.,cli:logs,workflow:docker)Benefits
DEBUG=*is setConstraints Met
🤖 Generated with Claude Code