Skip to content

[WIP] Fix failing GitHub Actions workflow lint-go#26912

Merged
pelikhan merged 2 commits intomainfrom
copilot/fix-lint-go-workflow-failure
Apr 17, 2026
Merged

[WIP] Fix failing GitHub Actions workflow lint-go#26912
pelikhan merged 2 commits intomainfrom
copilot/fix-lint-go-workflow-failure

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 17, 2026

  • Investigate CI failure details from GitHub Actions run 24575058718 (job 71858092536)
  • Identify root cause from lint-go logs
  • Reproduce current repository validation state locally before making changes
  • Apply minimal fix for testifylint expected/actual assertion order in affected test
  • Run targeted tests/lint plus required full pre-commit validation (make agent-finish)
  • Run parallel validation and report final status

@pelikhan pelikhan marked this pull request as ready for review April 17, 2026 17:03
Copilot AI review requested due to automatic review settings April 17, 2026 17:03
@pelikhan pelikhan merged commit b26ea40 into main Apr 17, 2026
64 of 66 checks passed
@pelikhan pelikhan deleted the copilot/fix-lint-go-workflow-failure branch April 17, 2026 17:03
Copilot stopped work on behalf of pelikhan due to an error April 17, 2026 17:03
Copilot AI requested a review from pelikhan April 17, 2026 17:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the failing lint-go GitHub Actions workflow by addressing testifylint assertion ordering in Go tests.

Changes:

  • Updated assert.Equal argument ordering in pkg/constants/spec_test.go for formatting constant assertions.
Show a summary per file
File Description
pkg/constants/spec_test.go Adjusts assertion argument ordering for documented constant-value checks (currently reversed vs Testify’s expected, actual signature).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

pkg/constants/spec_test.go:198

  • Same issue as above: assert.Equal arguments are reversed. Please use assert.Equal(t, expected, actual, ...) so constants.LineLength(100) is the expected value and constants.ExpressionBreakThreshold is the actual value (consistent with other tests like pkg/constants/spec_test.go:235 and pkg/workflow/mcp_gateway_config_test.go:32).
	assert.Equal(t, constants.ExpressionBreakThreshold, constants.LineLength(100),
		"ExpressionBreakThreshold should be 100 as documented")
  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment on lines +193 to 194
assert.Equal(t, constants.MaxExpressionLineLength, constants.LineLength(120),
"MaxExpressionLineLength should be 120 as documented")
@github-actions github-actions bot mentioned this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants