[WIP] Fix failing GitHub Actions workflow lint-go#26912
Merged
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/4555129e-2fd2-43e9-877d-a6deccc2ec2b Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot stopped work on behalf of
pelikhan due to an error
April 17, 2026 17:03
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the failing lint-go GitHub Actions workflow by addressing testifylint assertion ordering in Go tests.
Changes:
- Updated
assert.Equalargument ordering inpkg/constants/spec_test.gofor formatting constant assertions.
Show a summary per file
| File | Description |
|---|---|
| pkg/constants/spec_test.go | Adjusts assertion argument ordering for documented constant-value checks (currently reversed vs Testify’s expected, actual signature). |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
pkg/constants/spec_test.go:198
- Same issue as above:
assert.Equalarguments are reversed. Please useassert.Equal(t, expected, actual, ...)soconstants.LineLength(100)is the expected value andconstants.ExpressionBreakThresholdis the actual value (consistent with other tests like pkg/constants/spec_test.go:235 and pkg/workflow/mcp_gateway_config_test.go:32).
assert.Equal(t, constants.ExpressionBreakThreshold, constants.LineLength(100),
"ExpressionBreakThreshold should be 100 as documented")
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+193
to
194
| assert.Equal(t, constants.MaxExpressionLineLength, constants.LineLength(120), | ||
| "MaxExpressionLineLength should be 120 as documented") |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make agent-finish)