Nest gh-aw.job.agent under conclusion span in OTLP traces#26951
Merged
Nest gh-aw.job.agent under conclusion span in OTLP traces#26951
gh-aw.job.agent under conclusion span in OTLP traces#26951Conversation
8 tasks
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/2633eed9-30c2-4a4c-8498-f9cee16fe9b9 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix agent span parent hierarchy for OTel improvement
Nest Apr 17, 2026
gh-aw.job.agent under conclusion span in OTLP traces
Collaborator
|
@copilot only generate for agent job |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/f5b33ad3-0c8c-477e-baaf-c2cd3747a4cc Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This reverts commit 9ad7b31. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts OTLP trace span parenting so the job agent span (gh-aw.<job>.agent) is nested under the job conclusion span, reflecting the true execution hierarchy and improving latency attribution queries.
Changes:
- Pre-generates a conclusion
spanIdand uses it as theparentSpanIdfor the agent span (actions/setup/js/send_otlp_span.cjs). - Updates the agent-span unit test to assert
agent.parentSpanId === conclusion.spanIdand that conclusion remains parented by the setup span (actions/setup/js/send_otlp_span.test.cjs). - Regenerates multiple workflow lockfiles to add/adjust Safe Outputs validation schemas (notably adding
create_pull_request.fields.base, and in one case adjustingadd_reviewervalidation).
Show a summary per file
| File | Description |
|---|---|
| actions/setup/js/send_otlp_span.cjs | Pre-generates conclusion spanId and parents agent span under conclusion. |
| actions/setup/js/send_otlp_span.test.cjs | Updates assertions to validate the new parent/child relationship. |
| .github/workflows/weekly-safe-outputs-spec-review.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/weekly-editors-health-check.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/weekly-blog-post-writer.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/update-astro.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/unbloat-docs.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/ubuntu-image-analyzer.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/tidy.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/test-create-pr-error-handling.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/technical-doc-writer.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/spec-extractor.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/spec-enforcer.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/smoke-project.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/smoke-multi-pr.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/smoke-create-cross-repo-pr.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/smoke-claude.lock.yml | Adjusts add_reviewer validation (adds team_reviewers + custom validation). |
| .github/workflows/slide-deck-maintainer.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/schema-feature-coverage.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/refiner.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/q.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/poem-bot.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/layout-spec-maintainer.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/jsweep.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/instructions-janitor.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/hourly-ci-cleaner.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/go-logger.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/glossary-maintainer.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/github-mcp-tools-report.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/functional-pragmatist.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/dictation-prompt.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/developer-docs-consolidator.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/dead-code-remover.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/daily-workflow-updater.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/daily-safe-output-integrator.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/daily-rendering-scripts-verifier.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/daily-doc-updater.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/daily-doc-healer.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/daily-community-attribution.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/daily-architecture-diagram.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/code-simplifier.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/code-scanning-fixer.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/cloclo.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
| .github/workflows/ci-coach.lock.yml | Adds create_pull_request.fields.base validation schema in lockfile. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 44/44 changed files
- Comments generated: 2
Comment on lines
+420
to
+424
| "base": { | ||
| "type": "string", | ||
| "sanitize": true, | ||
| "maxLength": 128 | ||
| }, |
Comment on lines
1068
to
1082
| "reviewers": { | ||
| "required": true, | ||
| "type": "array", | ||
| "itemType": "string", | ||
| "itemSanitize": true, | ||
| "itemMaxLength": 39 | ||
| }, | ||
| "team_reviewers": { | ||
| "type": "array", | ||
| "itemType": "string", | ||
| "itemSanitize": true, | ||
| "itemMaxLength": 100 | ||
| } | ||
| } | ||
| }, | ||
| "customValidation": "requiresOneOf:reviewers,team_reviewers" | ||
| }, |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/f5b33ad3-0c8c-477e-baaf-c2cd3747a4cc Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/f5b33ad3-0c8c-477e-baaf-c2cd3747a4cc Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Updated: dedicated Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-aw.job.agentwas emitted as a sibling ofgh-aw.job.conclusion, even though its timing is contained within the conclusion window. This PR adjusts span parenting so trace waterfalls represent execution structure correctly (setup → conclusion → agent) and make latency attribution directly queryable.Span hierarchy correction (
actions/setup/js/send_otlp_span.cjs)conclusionSpanIdinsendJobConclusionSpan.parentSpanId: conclusionSpanId.conclusionSpanId.GITHUB_AW_OTEL_PARENT_SPAN_ID(setup span), preserving top-level trace linkage.gh-aw.<job>.agentspan only whenINPUT_JOB_NAME === "agent".Behavioral assertion update (
actions/setup/js/send_otlp_span.test.cjs)agent.parentSpanId === conclusion.spanIdconclusion.parentSpanId === setupSpanIdagent_output.jsonis present), and only the conclusion span is emitted.