[code-simplifier] test: remove duplicate benchmark and dead code in test files

[github-actions]

This PR simplifies recently modified test files to remove redundant code while preserving all functionality.

Files Simplified

• pkg/repoutil/repoutil_test.go — Remove duplicate BenchmarkSplitRepoSlug
• pkg/constants/constants_test.go — Remove dead-code variable block

Improvements Made

Removed Duplicate Benchmark

BenchmarkSplitRepoSlug (added alongside the new repoutil package) was an exact duplicate of BenchmarkSplitRepoSlug_Valid. Both functions benchmarked the identical valid slug "github/gh-aw" with the same loop body:

// Removed (duplicate of BenchmarkSplitRepoSlug_Valid)
func BenchmarkSplitRepoSlug(b *testing.B) {
    slug := "github/gh-aw"
    for b.Loop() {
        _, _, _ = SplitRepoSlug(slug)
    }
}

The _Valid / _Invalid naming pair is more expressive and self-documenting.

Removed Dead-Code Variables

TestTypeSafetyBetweenSemanticTypes in constants_test.go contained a block that assigned variables and immediately discarded them with _ = — making no assertions and providing no coverage:

// Removed: no assertions, no test value
jobStr := string(AgentJobName)
stepStr := string(CheckMembershipStepID)
_ = jobStr  // Used for demonstration
_ = stepStr // Used for demonstration
// Different semantic types prevent accidental mixing...

String conversion is already verified by the assertions directly above this block, and more thoroughly in TestHelperMethods and TestSpec_SemanticTypes_StringAndIsValid.

Changes Based On

Recent changes from:

• Refactor duplicated SHA/workflow-spec helpers into shared parser and gitutil APIs #27108 — Refactor duplicated SHA/workflow-spec helpers into shared parser and gitutil APIs (introduced pkg/repoutil)
• docs(constants): sync README with newly exported guard-policy, BYOK, and AWF version constants #27111 — docs(constants): sync README with newly exported guard-policy, BYOK, and AWF version constants

Testing

• ✅ All tests pass (go test ./pkg/repoutil/ ./pkg/constants/)
• ✅ Build succeeds (make build)
• ✅ No functional changes — behavior is identical

Review Focus

Please verify:

• The removed benchmark was truly redundant (same slug, same body as _Valid variant)
• The removed dead-code block had no hidden intent worth preserving

References: §24622549455

Note

🔒 Integrity filter blocked 5 items

The following items were blocked because they don't meet the GitHub integrity level.

• Refactor duplicated SHA/workflow-spec helpers into shared parser and gitutil APIs #27108 pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• Improve anomaly detector test clarity and boundary coverage in pkg/agentdrain #27107 pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• Reduce Copilot Token Usage Optimizer overhead via lean toolset, cli-proxy path, pre-aggregation, and prompt compaction #27114 pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• Ensure Smoke CI emits a safe output on non-PR runs #27106 pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• docs(constants): sync README with newly exported guard-policy, BYOK, and AWF version constants #27111 pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by Code Simplifier · ● 2.3M · ◷

• expires on Apr 20, 2026, 6:19 AM UTC

[Copilot]

Pull request overview

This PR simplifies test code by removing redundant benchmark coverage and eliminating a dead-code block in a semantic-type test, without changing behavior.

Changes:

• Removed a duplicate BenchmarkSplitRepoSlug benchmark in pkg/repoutil/repoutil_test.go (keeps _Valid / _Invalid benchmarks).
• Removed a dead-code variable assignment/discard block in TestTypeSafetyBetweenSemanticTypes in pkg/constants/constants_test.go.

Show a summary per file

File	Description
pkg/repoutil/repoutil_test.go	Deletes a redundant benchmark, retaining the meaningful valid/invalid benchmarks.
pkg/constants/constants_test.go	Removes non-asserting dead code from a test, keeping only the assertions that provide coverage.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0

[github-actions]

🧪 Test Quality Sentinel Report

Test Quality Score: N/A (cleanup-only PR)

✅ No new tests introduced — pure dead code removal

Metric	Value
New/modified tests analyzed	0 new tests (2 files modified)
✅ Design tests (behavioral contracts)	—
⚠️ Implementation tests (low value)	—
Tests with error/edge cases	—
Duplicate test clusters	0
Test inflation detected	No (only deletions: −8 lines, −7 lines)
🚨 Coding-guideline violations	None

---

What Changed

File	Change
pkg/constants/constants_test.go	Removed dead code: unused jobStr/stepStr variables (blank-identifier sink _ = x) inside TestTypeSafetyBetweenSemanticTypes. No assertions were removed.
pkg/repoutil/repoutil_test.go	Removed BenchmarkSplitRepoSlug — a duplicate/unnecessary benchmark with no behavioral assertions.

Both modified files retain their //go:build !integration build tag ✅

---

Verdict

✅ Check passed. This PR contains zero new or modified test functions — it only removes dead code and a benchmark. No implementation tests were introduced, no coding-guideline violations detected. The deletions improve test-file clarity without reducing behavioral coverage.

---

📖 Understanding Test Classifications

Design Tests (High Value) verify what the system does:

• Assert on observable outputs, return values, or state changes
• Cover error paths and boundary conditions
• Would catch a behavioral regression if deleted
• Remain valid even after internal refactoring

Implementation Tests (Low Value) verify how the system does it:

• Assert on internal function calls (mocking internals)
• Only test the happy path with typical inputs
• Break during legitimate refactoring even when behavior is correct
• Give false assurance: they pass even when the system is wrong

Goal: Shift toward tests that describe the system's behavioral contract — the promises it makes to its users and collaborators.

References: §24622917721

🧪 Test quality analysis by Test Quality Sentinel · ● 462K · ◷

[github-actions]

✅ Test Quality Sentinel: N/A score (cleanup-only PR). No new tests introduced — only dead code and a duplicate benchmark removed. 0% implementation tests (threshold: 30%). No coding-guideline violations detected.