Skip to content

Reduce DDUw Step 1c false “unaddressed” matches for spec-librarian closures #27192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Apr 19, 2026
+19 −12
Merged

Reduce DDUw Step 1c false “unaddressed” matches for spec-librarian closures #27192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a53c89
Initial plan
Copilot Apr 19, 2026
8d56c0f
chore: outline plan for dduw issue-reference improvement
Copilot Apr 19, 2026
98c9765
docs: improve DDUw closed-issue matching for spec-fix PRs
Copilot Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions .github/workflows/copilot-token-optimizer.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion .github/workflows/daily-doc-updater.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,13 @@ repo:${{ github.repository }} is:issue is:closed label:documentation closed:>=YY
```

For each closed issue:
- **closed as completed**: Check whether a `[docs]` PR references it. If no such PR exists, also search for any merged PR that closes or fixes the issue by number (e.g. `closes #NNN`, `fixes #NNN`, `resolves #NNN` in the PR body). If such a PR is found and its documentation change is complete, skip the issue. Otherwise, treat it as an unaddressed gap and follow the normal Step 2 flow.
- **closed as completed**: Check whether a `[docs]` PR references it. If no such PR exists, also search for any merged PR that closes or fixes the issue by number (e.g. `closes #NNN`, `fixes #NNN`, `resolves #NNN` in the PR body). If such a PR is found and its documentation change is complete, skip the issue.
- If no explicit issue-reference PR is found, run a fallback heuristic for likely spec-librarian/copilot fix PRs that omit issue numbers:
1. Infer the package from the issue title/body (for example `pkg/constants`).
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In step 1, the example says to infer the package as pkg/constants, but steps 2–3 use the placeholder pkg/<package>/README.md. If <package> is filled with pkg/constants, the resulting path becomes pkg/pkg/constants/README.md. Please clarify whether the inferred value should be just the package directory name (e.g. constants) or update the subsequent examples/placeholders to match the pkg/<name> form consistently.

Suggested change
1. Infer the package from the issue title/body (for example `pkg/constants`).
1. Infer the package directory name from the issue title/body (for example `constants`).

Copilot uses AI. Check for mistakes.
2. Search for merged PRs in a tight window around issue closure (prefer ±60 minutes) that modify `pkg/<package>/README.md`.
3. Example query: `repo:${{ github.repository }} is:pr is:merged merged:>=<issue_closed_at-60m> merged:<=<issue_closed_at+60m> path:pkg/<package>/README.md`.
4. If such a PR exists and the README change fully resolves the issue gap, treat the issue as already addressed and skip it.
- Otherwise, treat it as an unaddressed gap and follow the normal Step 2 flow.
- **closed as not_planned**: Do not create documentation based solely on this issue. Instead, cross-reference the issue's subject matter against commits from the same 7-day window (Step 2). If a related code change is found, treat it as a new documentation gap (independent of the original issue decision) and follow the normal Step 2 flow for that code change.

### 1d. Scan Cookie-Labeled Automation Issues
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/spec-librarian.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ The following specifications are outdated:
- [ ] Update stale specifications for N packages (use spec-extractor)
- [ ] Resolve N cross-package inconsistencies
- [ ] Review N spec-implementation mismatches
- [ ] When opening a fix PR for this issue, include `Closes #<this issue number>` (or `Fixes`/`Resolves`) in the PR description.
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This checklist item uses the placeholder Closes #<this issue number>, but other workflow guidance in this repo consistently uses Closes #NNN. Consider switching to the same placeholder format here for consistency and to make it easier for authors/agents to follow the instruction.

Suggested change
- [ ] When opening a fix PR for this issue, include `Closes #<this issue number>` (or `Fixes`/`Resolves`) in the PR description.
- [ ] When opening a fix PR for this issue, include `Closes #NNN` (or `Fixes`/`Resolves`) in the PR description.

Copilot uses AI. Check for mistakes.

---

Expand Down
Loading