Skip to content

[q] fix: exclude cancelled create_discussion results from error export (#27185) #27210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Apr 19, 2026
+6 −4
Merged

[q] fix: exclude cancelled create_discussion results from error export (#27185) #27210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f536c8
fix: exclude cancelled create_discussion results from error export
github-actions[bot] Apr 19, 2026
f1d7e1f
fix: apply prettier formatting for create_discussion error count filter
Copilot Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions actions/setup/js/safe_output_handler_manager.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1241,18 +1241,20 @@ async function main() {
}

// Export create_discussion errors for conclusion job
// Exclude cancelled results (cancelled == the discussion was skipped because a code-push
// operation failed earlier in the same run; that failure is already reported separately).
const createDiscussionErrors = processingResult.results
.filter(r => r.type === "create_discussion" && !r.success && !r.deferred && !r.skipped)
.filter(r => r.type === "create_discussion" && !r.success && !r.deferred && !r.skipped && !r.cancelled)
.map((r, index) => {
const message = agentOutput.items[r.messageIndex];
const title = message?.title || "Discussion";
const repo = message?.repo || "unknown";
const errorMsg = r.error || "Unknown error";
const repo = message?.repo || process.env.GITHUB_REPOSITORY || "unknown";
const errorMsg = r.error || r.reason || "Unknown error";
return `discussion:${index}:${repo}:${title}:${errorMsg}`;
})
.join("\n");

const createDiscussionErrorCount = processingResult.results.filter(r => r.type === "create_discussion" && !r.success && !r.deferred && !r.skipped).length;
const createDiscussionErrorCount = processingResult.results.filter(r => r.type === "create_discussion" && !r.success && !r.deferred && !r.skipped && !r.cancelled).length;

core.setOutput("create_discussion_errors", createDiscussionErrors);
core.setOutput("create_discussion_error_count", createDiscussionErrorCount.toString());
Expand Down
Loading