Skip to content

Fix copilot_driver.cjs append callback typing mismatch in TypeScript checks #27236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Apr 19, 2026
+5 −13
Merged

Fix copilot_driver.cjs append callback typing mismatch in TypeScript checks #27236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ee2b7f
Initial plan
Copilot Apr 19, 2026
0b673cf
fix(js): make copilot driver appendFileSync typing Node-compatible
Copilot Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions actions/setup/js/copilot_driver.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,7 @@ const MODEL_NOT_SUPPORTED_PATTERN = /The requested model is not supported/;
const NO_AUTH_INFO_PATTERN = /No authentication information found/;

/**
* @typedef {(path: import("node:fs").PathOrFileDescriptor, data: string | Uint8Array, options?: import("node:fs").WriteFileOptions) => void} NodeAppendFileSync
*/

/**
* @typedef {(path: string, data: string, encoding: string) => void} StringAppendLineWriter
*/

/**
* @typedef {NodeAppendFileSync | StringAppendLineWriter} AppendFileSyncLike
* @typedef {(path: import("node:fs").PathOrFileDescriptor, data: string | Uint8Array, options?: import("node:fs").WriteFileOptions) => void} AppendFileSyncLike
*/

/**
Expand Down Expand Up @@ -154,7 +146,7 @@ function buildInfrastructureIncompletePayload(details) {
* @param {string} payload
*/
function appendSafeOutputLine(appendFileSync, safeOutputsPath, payload) {
appendFileSync(safeOutputsPath, payload + "\n", "utf8");
appendFileSync(safeOutputsPath, payload + "\n", { encoding: "utf8" });
}

/**
Expand Down
6 changes: 3 additions & 3 deletions actions/setup/js/copilot_driver.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,17 +151,17 @@ describe("copilot_driver.cjs", () => {

it("appends one JSONL line through appendSafeOutputLine", () => {
const writes = [];
const appendStub = (file, data, encoding) => writes.push({ file, data, encoding });
const appendStub = (file, data, options) => writes.push({ file, data, options });
appendSafeOutputLine(appendStub, "/tmp/safeoutputs.jsonl", '{"type":"report_incomplete"}');
expect(writes).toEqual([{ file: "/tmp/safeoutputs.jsonl", data: '{"type":"report_incomplete"}\n', encoding: "utf8" }]);
expect(writes).toEqual([{ file: "/tmp/safeoutputs.jsonl", data: '{"type":"report_incomplete"}\n', options: { encoding: "utf8" } }]);
});

it("emitInfrastructureIncomplete writes payload when path is configured", () => {
const writes = [];
const logs = [];
emitInfrastructureIncomplete("temporary outage", {
safeOutputsPath: "/tmp/safeoutputs.jsonl",
appendFileSync: (file, data, encoding) => writes.push({ file, data, encoding }),
appendFileSync: (file, data, options) => writes.push({ file, data, options }),
logger: message => logs.push(message),
});
expect(writes).toHaveLength(1);
Expand Down
Loading