Conversation
The byok-copilot flag bundles four compiler behaviors, not three. The fourth — setting COPILOT_MODEL with a non-empty claude-sonnet-4.6 fallback — was added to fix bug #26565 but never reflected in the user-facing reference docs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the features.byok-copilot reference documentation to reflect the compiler’s actual BYOK wiring behavior, including the non-empty COPILOT_MODEL fallback added for bug #26565.
Changes:
- Expands the
features.byok-copilotsection from three to four required behaviors. - Documents the default
COPILOT_MODELexpression and its fallback (claude-sonnet-4.6) whenGH_AW_MODEL_AGENT_COPILOTis unset. - Adds guidance for overriding the model via the
GH_AW_MODEL_AGENT_COPILOTGitHub Actions variable.
Show a summary per file
| File | Description |
|---|---|
| docs/src/content/docs/reference/frontmatter.md | Updates BYOK Copilot feature-flag docs to include the COPILOT_MODEL default/fallback behavior and override mechanism. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Healing Documentation Fixes
This PR was automatically created by the Daily Documentation Healer workflow.
Gaps Fixed
features.byok-copilotindocs/src/content/docs/reference/frontmatter.mddescribed "three required behaviors" but the compiler actually implements four. The fourth behavior — settingCOPILOT_MODELto$\{\{ vars.GH_AW_MODEL_AGENT_COPILOT || 'claude-sonnet-4.6' }}— was added to fix bug bug: byok-copilot feature generates empty COPILOT_MODEL fallback, breaking BYOK mode #26565 (Copilot BYOK providers require a non-empty model), but was never reflected in the user-facing reference docs. The section now lists all four behaviors explicitly and documents how to override the model via theGH_AW_MODEL_AGENT_COPILOTrepository variable.Root Cause
DDUw skipped this gap twice:
CopilotBYOKDefaultModel = "claude-sonnet-4.6"was inpkg/constants/engine_constants.go), so this deferral was incorrect.💡 DDUw Improvement Suggestions
DDUw Improvement Suggestions
Problem: DDUw deferred an already-fixed documentation gap by citing "API surface not yet stable" when in fact
CopilotBYOKDefaultModelwas committed and stable inpkg/constants/engine_constants.go.Suggested heuristic to add to Step 1c or Step 2 in
.github/workflows/daily-doc-updater.md:Specifically: when a closed issue references a constants change (
CopilotBYOK*), DDUw should cross-check whether the public-facing section that owns that feature (herefeatures.byok-copilot) lists all compiler behaviors coded inpkg/workflow/copilot_engine_execution.go.Related Issues
References: