Skip to content

Refactor MCP setup generation into focused helper units#27368

Closed
Copilot wants to merge 2 commits intomainfrom
copilot/fix-architecture-violations
Closed

Refactor MCP setup generation into focused helper units#27368
Copilot wants to merge 2 commits intomainfrom
copilot/fix-architecture-violations

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 20, 2026 •
edited
Loading

Architecture Guardian flagged generateMCPSetup in pkg/workflow/mcp_setup_generator.go as a top-priority oversized function (~849 lines), making ownership and change isolation difficult. This PR reduces that hotspot by turning the function into a dispatcher and moving major setup phases into focused helpers.

  • Refactor: generateMCPSetup becomes orchestrator

    • Kept tool discovery, ordering, and top-level flow in generateMCPSetup(...).
    • Delegated phase-specific rendering to helper methods to reduce function complexity.

  • Extracted helper modules (same package, behavior-preserving)

    • Added pkg/workflow/mcp_setup_generator_helpers.go with:
      • hasSharedGhAwImport(...)
      • generateGhAwExtensionInstallStep(...)
      • (*Compiler).generateSafeOutputsMCPSetup(...)
      • (*Compiler).generateMCPScriptsMCPSetup(...)
      • (*Compiler).generateMCPGatewaySetup(...)
    • Moved existing logic blocks without changing generation semantics or output contract.

  • Code organization impact

    • Main function now reads as phase orchestration (collect → install-if-needed → safe-outputs setup → mcp-scripts setup → gateway setup).
    • Detailed YAML emission logic remains intact but is isolated by concern for easier follow-on refactors.
// generateMCPSetup now delegates by phase instead of inlining all setup logic.
if hasAgenticWorkflows {
	if hasSharedGhAwImport(workflowData.ImportedFiles) {
		mcpSetupGeneratorLog.Print("Skipping gh-aw extension installation step (provided by shared/mcp/gh-aw.md import)")
	} else {
		generateGhAwExtensionInstallStep(yaml)
	}
}

if err := c.generateSafeOutputsMCPSetup(yaml, workflowData, safeOutputConfig); err != nil {
	return err
}
if err := c.generateMCPScriptsMCPSetup(yaml, workflowData); err != nil {
	return err
}
return c.generateMCPGatewaySetup(yaml, tools, engine, workflowData, mcpTools, hasAgenticWorkflows)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name w.test GOINSECURE 631049/b011/preeconfig mpile w.test 5407�� se 073562/b020/vet.cfg cfg GOINSECURE GOMOD t pkg/mod/golang.org/toolchain@v0.--jq (http block)
    • Triggering command: /usr/bin/gh gh repo view owner/repo env 631049/b226/_pkg_.a cfg cfg GOINSECURE l mpile pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.lin--initial-branch=my-default (http block)
    • Triggering command: /usr/bin/gh gh repo view owner/repo env 631049/b230/_pkg_.a mpile (http block)
  • https://api.github.com/orgs/test-owner/actions/secrets
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name -json arm.go ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ux-amd64/pkg/too-buildtags env -json o ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ux-amd64/pkg/too-trimpath (http block)
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name go1.25.8 -c=4 -nolocalimports -importcfg /tmp/go-build1352562520/b070/importcfg -pack /tmp/go-build1352562520/b070/_testmain.go env -json GO111MODULE ux-amd64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq [.object.sha, .object.type] | @tsv --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts /usr/bin/infocmp .artifacts[].namgit cfg rg/toolchain@v0.--show-toplevel infocmp -1 xterm-color rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/too-buildtags /usr/bin/git 631049/b219/_pkggit mpile l/linux_amd64/ve--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq [.object.sha, .object.type] | @tsv -v go /usr/bin/gh -json GO111MODULE pkg/mod/golang.o--show-toplevel gh --ve�� GOMODCACHE go /usr/bin/git -json GO111MODULE pkg/mod/golang.o--show-toplevel git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv /tmp/go-build754073562/b449/styles.test -importcfg /usr/bin/git -s -w -buildmode=exe git rev-�� --show-toplevel -extld=gcc /home/REDACTED/work/_temp/ghcca-node/node/bin/node -json GO111MODULE 0.1-go1.25.8.lin--show-toplevel node (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv thImports3045421867/001 l /usr/bin/gh ted-objects.md GO111MODULE 0.1-go1.25.8.lin--show-toplevel gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq /usr/bin/git tions-lock.json git GO111MODULE 0.1-go1.25.8.lin--show-toplevel git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v5
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv 631049/b175/impo--workflow t rg/toolchain@v0.--limit -p strings t rg/toolchain@v0.0.1-go1.25.8.linremote.origin.url -o _.a t 073562/b416/envutil.test -p eutil t 073562/b416/envutil.test (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv --show-toplevel ole.test /usr/bin/git 2324/001/stabiligit 073562/b052/vet.rev-parse pkg/mod/golang.o--show-toplevel git rev-�� --show-toplevel pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.linremote /usr/bin/git ons/secrets 073562/b108/vet.rev-parse erutil.test git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv --show-toplevel /home/REDACTED/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.lin-importcfg /usr/bin/git k/gh-aw/gh-aw/.ggit -trimpath /bin/sh git rev-�� --show-toplevel /bin/sh /usr/bin/git git-upload-pack git l /usr/bin/git git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv ErrorFormatting2590101296/001 -dwarf=false k/_temp/ghcca-node/node/bin/node l -c=4 -nolocalimports k/_temp/ghcca-node/node/bin/node 3206�� y 073562/b461/_testmain.go /home/REDACTED/go/pkg/mod/golang.org/toolchain@v0.new (upstream) 01 GO111MODULE l/linux_amd64/co--show-toplevel /home/REDACTED/go/pkg/mod/golang.org/toolchain@v0./tmp/gh-aw-merge-2927146261/new.md (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv git-receive-pack '/tmp/TestParseDefaultBranchFro.artifacts[].name git-receive-pack '/tmp/TestParseDefaultBranchFromLsRemoteWithRealGitbranch_with_hyphen1881036860rev-parse .test -json GO111MODULE ux-amd64/bin/go .test lope�� --show-toplevel go /usr/bin/git -json GO111MODULE ux-amd64/bin/go git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v8
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv --show-toplevel Wo/bJFsyISU_LIYuVgol9MA/VXEcZK8zxALa-u5qnCFC /usr/bin/git i.go ntifiers.go pkg/mod/golang.oHEAD git rev-�� --show-toplevel pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/too-buildtags /usr/bin/git 5934-73870/test-git t res.lock.yml git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv --show-toplevel go /usr/bin/git -json GO111MODULE /home/REDACTED/go/HEAD git rev-�� --show-toplevel go /usr/bin/git -1832020695 GO111MODULE pkg/mod/golang.o--show-toplevel git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v9
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ux-amd64/pkg/too-buildtags env -json GO111MODULE ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ux-amd64/pkg/too-buildtags (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ux-amd64/pkg/too-buildtags env -json GO111MODULE ux-amd64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ux-amd64/pkg/toogit-upload-pack '/tmp/TestParseDefaultBranchFromLsRemoteWithRealGitbranch_with_hyphen2359857211/001' (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv 01 GO111MODULE ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD 0.1-go1.25.8.lin/tmp/gh-aw-add-gitattributes-test428059160/.github/workflows ux-amd64/pkg/tooconfig env -json GO111MODULE 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 0.1-go1.25.8.linremote (http block)
  • https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv user.email test@example.com /usr/bin/infocmp -json cfg rg/toolchain@v0.--show-toplevel infocmp -1 xterm-color rg/toolchain@v0.--jq /usr/bin/infocmp -json GO111MODULE rg/toolchain@v0.--show-toplevel infocmp (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel go /usr/bin/git -json GO111MODULE /usr/bin/go git rev-�� --show-toplevel go /usr/bin/git -json GO111MODULE pkg/mod/golang.o--show-toplevel git (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv vars.MY_VAR 0.1-go1.25.8.lin-test.v=true /usr/bin/git -json cfg rg/toolchain@v0.--show-toplevel git rev-�� --show-toplevel rg/toolchain@v0.remote /usr/bin/git -json cfg rg/toolchain@v0.--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --git-dir go /usr/bin/git ty-test.md GO111MODULE pkg/mod/golang.o--show-toplevel git rev-�� --show-toplevel go /usr/bin/git -json GO111MODULE pkg/mod/golang.o--show-toplevel git (http block)
  • https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --pack_header=2,3 -q om/testowner/testrepo.git go1.25.8 -c=4 t git -C /tmp/compile-instructions-test-2451803292/.github/workflows s/1/artifacts /usr/bin/git -json 2/compile.go ux-amd64/pkg/too--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv for-each-ref --format=%(objectname) /usr/bin/git -json GO111MODULE 0.1-go1.25.8.lin--show-toplevel git -C /tmp/gh-aw-test-runs/20260420-151330-120117/test-1999108841/.github/workflows rev-parse /usr/bin/git yphen1881036860/git yphen1881036860/rev-parse 0.1-go1.25.8.lin--show-toplevel git (http block)
  • https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b
    • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq [.object.sha, .object.type] | @tsv run 68b50171 $name) { hasDiscussionsEnabled } } --detach -test k/gh-aw/gh-aw/no-x git k/gh�� -- st/suppress-warnings.cjs 1/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/node -b auth-cleanup-fai-C .extraheader st/dist/workers/config (http block)
    • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq [.object.sha, .object.type] | @tsv -d 68b50171 1/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/git user.email test@test.com k/_temp/ghcca-no--show-toplevel git k/gh�� -- st/suppress-warnings.cjs bin/node -b auth-cleanup-faiapi modules/@npmcli/graphql st/dist/workers/-f (http block)
    • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq [.object.sha, .object.type] | @tsv full2.txt 86e384ae $name) { hasDiscussionsEnabled } } /tmp/bare-incremgit . odules/npm/node_user.name git k/gh�� --verify 86e384ae (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0.1.2
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq [.object.sha, .object.type] | @tsv --show-toplevel 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet /usr/bin/git _.a GO111MODULE rg/toolchain@v0.--show-toplevel git rev-�� --show-toplevel rg/toolchain@v0.0.1-go1.25.8.linconfig /usr/bin/docker dfWiE9R6S g/console/accessrev-parse rg/toolchain@v0.--show-toplevel docker (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq [.object.sha, .object.type] | @tsv --show-toplevel l/linux_amd64/vet /usr/bin/git -json GO111MODULE 0.1-go1.25.8.lin--show-toplevel git rev-�� --git-dir 0.1-go1.25.8.linremote.origin.url /usr/bin/docker -json GO111MODULE pkg/mod/golang.o--show-toplevel docker (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv xterm-color l /home/REDACTED/work/_temp/ghcca-node/node/bin/node -json x86.go ux-amd64/pkg/too--show-toplevel node /tmp�� /tmp/TestHashConsistency_GoAndJavaScript3957141443/001/test-simple-frontmatter.md ux-amd64/pkg/too-buildtags /usr/bin/git -json GO111MODULE ux-amd64/pkg/too--show-toplevel /usr/bin/git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv for-each-ref --format=%(objectname) /usr/bin/git -json GO111MODULE 0.1-go1.25.8.lin--show-toplevel git rev-�� --show-toplevel go /usr/bin/git -json GO111MODULE 0.1-go1.25.8.lin--show-toplevel git (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv xterm-color ux-amd64/pkg/too/tmp/go-build754073562/b101/vet.cfg om/testorg/testrepo.git -json GO111MODULE ux-amd64/pkg/too--show-toplevel /home/REDACTED/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.linremote.myorg.url -o /tmp/go-build754073562/b443/_pkg_.a -trimpath /home/REDACTED/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/li--show-toplevel -p main -lang=go1.25 /home/REDACTED/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.lintest@example.com (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv --pack_header=2,3 l /home/REDACTED/work/_temp/ghcca-node/node/bin/node--limit -json GO111MODULE 0.1-go1.25.8.lin--show-toplevel node /tmp�� /tmp/TestHashConsistency_GoAndJavaScript15165188remote.origin.url go /usr/bin/git -json GO111MODULE 0.1-go1.25.8.lin--show-toplevel git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name om/yosida95/uritemplate/v3@v3.0.2/compile.go rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE (http block)
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 cfg rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE ntio/asm/ascii GOMODCACHE rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/too-trimpath env 631049/b247/_pkg_.a cfg 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/compile GOINSECURE t/internal t 0.1-go1.25.8.linux-amd64/pkg/tooorigin (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name GO111MODULE rg/toolchain@v0.0.1-go1.25.8.linux-amd64/bin/go GOINSECURE GOMOD GOMODCACHE go env mpiledOutput3280133779/001 GO111MODULE /home/REDACTED/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.linGOMODCACHE GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name mpile rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD mpile rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/too-buildtags env ithub/workflows mpile cfg GOINSECURE g/x/net/http2/hp/tmp/test-import-175615199.js mpile pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.lin--auto (http block)
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 mpile rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD mpile rg/toolchain@v0.test@example.com env 631049/b206/_pkg_.a mpile 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE hpke mpile 0.1-go1.25.8.linremote.origin.url (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name mLsRemoteWithRealGitcustom_branch2712495895/001' pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.linGOMODCACHE GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.linGOMODCACHE GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name cfg rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE randutil mpile rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/too-buildtags env 631049/b219/_pkg_.a mpile rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE g/x/text/unicodeconfig mpile rg/toolchain@v0.test@example.com (http block)
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 m (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name GO111MODULE rg/toolchain@v0.0.1-go1.25.8.linux-amd64/bin/go GOINSECURE GOMOD GOMODCACHE go env y_with_repos=public_3631654382/001 GO111MODULE /home/REDACTED/go/pkg/mod/golang.org/toolchain@v0.GOMODCACHE GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name m rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE sysrand mpile rg/toolchain@v0.0.1-go1.25.8.lin-test.v=true pkg/�� 2439945833 mpile (http block)
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 cfg rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE boring pkg/mod/golang.o--show-toplevel rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/too-trimpath env 631049/b246/_pkg_.a 3NxN/fOrMapTM_SttVIFB3NxN k GOINSECURE t/message/catalorev-parse t pkg/mod/golang.org/toolchain@v0.remote.origin.url (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name GO111MODULE (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name m rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD mpile rg/toolchain@v0.0.1-go1.25.8.linremote rtcf�� 631049/b232/_pkg_.a tmain.go 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/link GOINSECURE contextprotocol/config GOMODCACHE 0.1-go1.25.8.linTest User (http block)
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 cfg rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD 631049/b036/symauser.name rg/toolchain@v0.Test User env 2173506605/.github/workflows 7gve/JS7DQw3o9RuNG8R67gve pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.lin-buildmode=exe GOINSECURE t/message t pkg/mod/golang.org/toolchain@v0.remote.origin.url (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name GO111MODULE rg/toolchain@v0.0.1-go1.25.8.linux-amd64/bin/go GOINSECURE GOMOD GOMODCACHE go env mpiledOutput3280133779/001 GO111MODULE rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE rg/toolchain@v0.origin (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name cfg rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD mpile rg/toolchain@v0.0.1-go1.25.8.linrev-parse env 631049/b233/_pkg_.a mpile pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.lin-lang=go1.25 GOINSECURE a95/uritemplate/init GOMODCACHE pkg/mod/golang.org/toolchain@v0.origin (http block)
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 cfg rg/toolchain@v0.0.1-go1.25.8.lin-lang=go1.25 GOINSECURE ntio/asm/keyset GOMODCACHE rg/toolchain@v0.0.1-go1.25.8.lin-dwarf=false env 631049/b244/_pkg_.a GO111MODULE 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE t/internal/numberev-parse t 0.1-go1.25.8.linux-amd64/pkg/tooTest User (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name GO111MODULE rg/toolchain@v0.0.1-go1.25.8.linux-amd64/bin/go GOINSECURE GOMOD GOMODCACHE go env edOutput2693604269/001 GO111MODULE rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/cgo GOINSECURE GOMOD GOMODCACHE rg/toolchain@v0.test@example.com (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name om/modelcontextprotocol/go-sdk@v1.5.0/jsonrpc/js-ifaceassert rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE ntio/asm/base64 mpile rg/toolchain@v0.0.1-go1.25.8.lin-test.v=true env 2439945833 mpile cfg GOINSECURE GOMOD GOMODCACHE pkg/mod/golang.otest@example.com (http block)
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 cfg 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE 631049/b021/atom/tmp/test-expr-2279720418.js pkg/mod/golang.osecrets.TOKEN 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet env 631049/b239/_pkg_.a DUdE/2oEXO76xEThYfB4YDUdE pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE t/internal/catmsinit t pkg/mod/golang.org/toolchain@v0.test@example.com (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name mLsRemoteWithRealGitbranch_with_hyphen1881036860/001' pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.linGOMODCACHE GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/asm GOINSECURE GOMOD GOMODCACHE rg/toolchain@v0.Test User (http block)
  • https://api.github.com/repos/github/gh-aw/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path -c=4 -nolocalimports -importcfg /tmp/go-build754073562/b422/importcfg -pack /home/REDACTED/work/gh-aw/gh-aw/pkg/gitutil/gitutil.go /home/REDACTED/work/gh-aw/gh-aw/pkg/gitutil/gitutil_test.go env -json GO111MODULE ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ux-amd64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 GOMOD GOMODCACHE ux-amd64/pkg/tool/linux_amd64/link env _.a tants.go 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 9B8vwjI/T9BZMVkQM_1X2RCSycXq (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 GOMOD mpile 0.1-go1.25.8.linremote.origin.url env 631049/b156/_pkg_.a mpile til.test GOINSECURE contextprotocol/rev-parse mpile til.test (http block)
  • https://api.github.com/repos/github/gh-aw/contents/.github/workflows/shared/reporting.md
    • Triggering command: /tmp/go-build754073562/b403/cli.test /tmp/go-build754073562/b403/cli.test -test.testlogfile=/tmp/go-build754073562/b403/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true GOINSECURE GOMOD GOMODCACHE ux-amd64/pkg/too-buildtags env -json o ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ux-amd64/pkg/too/tmp/go-build754073562/b211/vet.cfg (http block)
    • Triggering command: /tmp/go-build1352562520/b403/cli.test /tmp/go-build1352562520/b403/cli.test -test.testlogfile=/tmp/go-build1352562520/b403/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE ux-amd64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v0.47.4
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq [.object.sha, .object.type] | @tsv --show-toplevel pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.linconfig /usr/bin/git 9R6S/LibFNih3wtfgit t pkg/mod/golang.o--show-toplevel git rev-�� --show-toplevel pkg/mod/golang.org/toolchain@v0.origin /usr/bin/git ApprovalLabelsCols 073562/b263/vet.-lh pkg/mod/golang.o/tmp/gh-aw/aw-feature-branch.patch git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq [.object.sha, .object.type] | @tsv --show-toplevel go /usr/bin/git agent-performancgit GO111MODULE pkg/mod/golang.o--show-toplevel git rev-�� --show-toplevel go /usr/bin/git -json GO111MODULE pkg/mod/golang.o/tmp/gh-aw/aw-feature-branch.patch git (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv 43/001/test-frontmatter-with-arrays.md cfg 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/compile GOINSECURE 631049/b133/aritrev-parse t 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/compile ranc�� se 073562/b002/vet.cfg pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet -p log/slog/interna-1 t pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.linrev-parse (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv -json @v1.1.3/internal/unsafebytes/uns-c=4 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 0.1-go1.25.8.linremote env 119998723/001 119998723/002/work 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE obyte/asn1 GOMODCACHE 0.1-go1.25.8.linremote (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv tions-lock.json -errorsas GO111MODULE 0.1-go1.25.8.lin-nilfunc GOINSECURE GOMOD GOMODCACHE go _bra�� -json GO111MODULE 0.1-go1.25.8.linux-amd64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v2.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv 0.1-go1.25.8.linux-amd64/src/rungo1.25.8 0.1-go1.25.8.linux-amd64/src/run-c=4 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 0.1-go1.25.8.linremote env _.a rotocol/go-sdk@v1.5.0/internal/json/json.go 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 0.1-go1.25.8.linux-amd64/pkg/too-buildtags (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE 0.1-go1.25.8.lin--quiet GOINSECURE GOMOD GOMODCACHE 0.1-go1.25.8.linremote env phen2359857211/001 phen2359857211/002/work 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 0.1-go1.25.8.lin-trimpath (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv -json eutil.go 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 0.1-go1.25.8.linrev-parse phen�� _.a GO111MODULE 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 0.1-go1.25.8.linux-amd64/pkg/too/tmp/go-build754073562/b375/vet.cfg (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v3.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv led-with-env-template-expressions-in-body.md GO111MODULE 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 0.1-go1.25.8.linconfig om_b�� -json GO111MODULE 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 0.1-go1.25.8.linremote (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE rg/toolchain@v0.0.1-go1.25.8.linGOMODCACHE GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE rg/toolchain@v0.0.1-go1.25.8.linGOMODCACHE GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq [.object.sha, .object.type] | @tsv O3Wj/97dV1WNIals-obugO3Wj cfg pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.lin-lang=go1.25 GOINSECURE GOMOD GOMODCACHE M2/2rd54d-9cdbu-SqAYBLY/FfjsUOys/tmp/file-tracker-test3673508355/test2.lock.yml 6310�� /tmp/go-build744631049/b120/_pkg_.a pkg/mod/github.com/segmentio/encoding@v0.5.4/jso-nolocalimports pkg/mod/golang.org/toolchain@v0.0.1-go1.25.8.lin-importcfg -p github.com/githuarchive t pkg/mod/golang.ov1.0.0 (http block)
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq [.object.sha, .object.type] | @tsv thub/workflows GO111MODULE (http block)
  • https://api.github.com/repos/nonexistent/repo/actions/runs/12345
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE /go-yaml/parser mpile 0.1-go1.25.8.linux-amd64/pkg/too-importcfg env 1J_w/Er3tOjWufLWXMdlm1J_w mpile pkg/mod/golang.org/toolchain@v0.-buildmode=exe GOINSECURE GOMOD t pkg/mod/golang.org/toolchain@v0.remote (http block)
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE GOMOD GOMODCACHE go env thub/workflows GO111MODULE (http block)
  • https://api.github.com/repos/owner/repo/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ux-amd64/pkg/too-buildtags env -json GO111MODULE ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ux-amd64/pkg/tootest@example.com (http block)
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ux-amd64/pkg/too-buildtags env -json age.go ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ux-amd64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh workflow list --repo owner/repo --json name,path,state (http block)
  • https://api.github.com/repos/test-owner/test-repo/actions/secrets
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name -json GO111MODULE ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE PDfWQI9Bjviy env -json age/common.go ux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD 0.1-go1.25.8.lin-test.paniconexit0 ux-amd64/pkg/too-test.v=true (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name -json GO111MODULE ux-amd64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE ux-amd64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/test/repo
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch 631049/b247/_pkg_.a cfg 0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/compile GOINSECURE t/internal t 0.1-go1.25.8.linux-amd64/pkg/tooorigin (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch -json GO111MODULE rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE rg/toolchain@v0.0.1-go1.25.8.linremote.origin.url env -json GO111MODULE rg/toolchain@v0.0.1-go1.25.8.linux-amd64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE rg/toolchain@v0.5 (http block)
  • invalid.example.invalid
    • Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin https://invalid.example.invalid/nonexistent-repo.git git chec�� -b main /home/REDACTED/work/gh-aw/node_modules/.bin/git file3.txt git ules/.bin/git git comm�� -m Auth cleanup base commit nfig/composer/vendor/bin/git user.name Test User git git (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue Apr 20, 2026 that may be closed by this pull request
Architecture Violations Detected — 2026-04-20 #27367
Closed
7 tasks
Copilot AI changed the title [WIP] Fix architecture violations detected in CJS files Refactor MCP setup generation into focused helper units Apr 20, 2026
Copilot AI requested a review from pelikhan April 20, 2026 15:21
@pelikhan pelikhan closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pelikhan pelikhan Awaiting requested review from pelikhan

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@pelikhan pelikhan

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Architecture Violations Detected — 2026-04-20

2 participants

@pelikhan