Conversation
Add missing test coverage for the merge-pull-request safe output type: - New test workflow: pkg/cli/workflows/test-copilot-merge-pull-request.md - New Go test case: merge_pull_request config in compiler_safe_outputs_config_test.go Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safe Output Test Coverage
This PR adds test coverage for the one safe-output type that was missing test artifacts:
merge-pull-request.Analysis
All 40 safe-output types were checked against:
pkg/cli/workflows/pkg/workflow/compiler_safe_outputs_config_test.goOnly
merge-pull-requestwas missing from both.New Test Workflow Added
pkg/cli/workflows/test-copilot-merge-pull-request.md— Demonstratesmerge-pull-requestusage withrequired-labelsandallowed-branchesconstraints, using the Copilot engine.Go Test Added
"merge_pull_request config"test case toTestAddHandlerManagerConfigEnvVarinpkg/workflow/compiler_safe_outputs_config_test.goMergePullRequestConfigwithRequiredLabelsandAllowedBranchesfieldsGH_AW_SAFE_OUTPUTS_HANDLER_CONFIGwith keymerge_pull_requestSummary
All 40 safe-output types now have test workflows in
pkg/cli/workflows/and Go compiler tests incompiler_safe_outputs_config_test.go. Coverage is complete.References: §24694880685