Add comment_memory safe output support with editable file workflow integration#27479
Merged
Add comment_memory safe output support with editable file workflow integration#27479
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/7a86331a-2d62-45b3-b52d-8bd4b8ec8b01 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/7a86331a-2d62-45b3-b52d-8bd4b8ec8b01 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 21, 2026 02:57
View session
pelikhan
reviewed
Apr 21, 2026
| if (!/^[a-zA-Z0-9_-]+$/.test(memoryID)) { | ||
| throw new Error("memory_id must contain only alphanumeric characters, hyphens, and underscores"); | ||
| } | ||
| let body = `<comment-memory id="${memoryID}">\n${sanitizeContent(rawBody)}\n</comment-memory>`; |
| } | ||
|
|
||
| async function findManagedComment(github, owner, repo, itemNumber, memoryID) { | ||
| const marker = `<comment-memory id="${memoryID}">`; |
Collaborator
There was a problem hiding this comment.
@copilot use gh-aw-comment-memory (refactor id in constant)
Contributor
Author
There was a problem hiding this comment.
Implemented in 59628d0. Refactored marker usage to shared constants (COMMENT_MEMORY_TAG) and reused it for both body generation and lookup matching.
| const marker = `<comment-memory id="${memoryID}">`; | ||
| let page = 1; | ||
| const perPage = 100; | ||
| while (true) { |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/27e277b0-1803-4347-afdc-28261f19684b Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This reverts commit c54ab39. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/27e277b0-1803-4347-afdc-28261f19684b Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Implemented in 59628d0. Added extensive Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Collaborator
|
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/8f6cfa44-79b4-46b5-96ab-081eb8dcc7b7 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This reverts commit 766afef. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/8f6cfa44-79b4-46b5-96ab-081eb8dcc7b7 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/8f6cfa44-79b4-46b5-96ab-081eb8dcc7b7 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/8f6cfa44-79b4-46b5-96ab-081eb8dcc7b7 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Implemented in a2c0451 (core feature commits: 11a9c42, cda8351). Added a pre-agent JS setup step that materializes Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Add comment_memory safe output type support
Add comment_memory safe output support with editable file workflow integration
Apr 21, 2026
pelikhan
reviewed
Apr 21, 2026
| const COMMENT_MEMORY_TAG = "gh-aw-comment-memory"; | ||
| const COMMENT_MEMORY_MAX_SCAN_PAGES = 50; | ||
|
|
||
| function logInfo(message) { |
Contributor
Author
| } | ||
| } | ||
|
|
||
| function logWarning(message) { |
Contributor
Author
Contributor
There was a problem hiding this comment.
Smoke test agent confirming this thread — the bounded pagination approach with COMMENT_MEMORY_MAX_SCAN_PAGES is a solid safeguard! ✅
📰 BREAKING: Report filed by Smoke Copilot · ● 998.2K
| const path = require("path"); | ||
| const { getErrorMessage } = require("./error_helpers.cjs"); | ||
|
|
||
| const COMMENT_MEMORY_TAG = "gh-aw-comment-memory"; |
Collaborator
There was a problem hiding this comment.
@copilot refactor parsing and constant in helper file
Contributor
Author
| } | ||
| }, | ||
| { | ||
| "name": "comment_memory", |
Collaborator
There was a problem hiding this comment.
@copilot this tool is not needed, the agent should just edit the comment memory files directly.
Contributor
Author
There was a problem hiding this comment.
Implemented in 18bdc3a. Removed comment_memory from safe-output tool definitions/prompts; the agent now edits /tmp/gh-aw/comment-memory/*.md directly and the handler manager auto-syncs those files into managed comment memory. UI screenshot: N/A (no UI changes).
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/b01eb4b0-28aa-4b71-81ea-83ef827f360e Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This reverts commit 91d752b. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
|
|
Contributor
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
Contributor
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... |
Contributor
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
Contributor
|
🚀 Smoke OpenCode MISSION COMPLETE! OpenCode delivered. 🔥 |
Contributor
|
|
Contributor
Agent Container Tool Check
Result: 12/12 tools available ✅ Overall Status: PASS
|
Contributor
|
Smoke Test 24735013467 | PR #27479 |
Overall: ✅ PASS (14/14)
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Reviewed the new comment_memory.cjs module. The implementation is well-structured with proper validation and bounded pagination. Minor suggestions: use debug level for rejected memory IDs, and add inline comments explaining the provenance marker requirement.
📰 BREAKING: Report filed by Smoke Copilot · ● 998.2K
| // Require provenance marker to avoid accidentally updating user-authored comments | ||
| // that happen to contain a matching comment-memory tag. | ||
| const MANAGED_COMMENT_PROVENANCE_MARKER = "<!-- gh-aw-agentic-workflow:"; | ||
|
|
Contributor
There was a problem hiding this comment.
The MANAGED_COMMENT_PROVENANCE_MARKER guard is a good defensive check — it ensures only workflow-managed comments are updated. Consider adding a comment explaining why this marker is required for future readers.
| core.info(`comment_memory: rejected invalid memory_id '${normalized}'`); | ||
| return null; | ||
| } | ||
| return normalized; |
Contributor
There was a problem hiding this comment.
The sanitizeMemoryID function correctly validates memory_id format, but consider logging the rejected value at debug level rather than info to avoid noise in non-debug runs.
Contributor
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Contributor
Smoke Test Results — Run §24735013438Core Tests #1–12: ✅✅✅✅✅✅✅✅✅❌✅✅ Overall: PARTIAL (17✅ · 1❌ · 2
|
Contributor
There was a problem hiding this comment.
💥 Automated smoke test review — Claude engine nominal! All systems tested and functional. Run 24735013438.
💥 [THE END] — Illustrated by Smoke Claude · ● 251.7K
| <safe-output-tools> | ||
| Tools: add_comment(max:10), create_issue(max:5), create_discussion(max:2), missing_tool, missing_data, noop | ||
| GH_AW_PROMPT_e8efe57977b9f20b_EOF | ||
| cat "${RUNNER_TEMP}/gh-aw/prompts/safe_outputs_comment_memory.md" |
Contributor
There was a problem hiding this comment.
🤖 Smoke test review comment — The comment memory prompt injection is correctly placed here, sandwiched between the EOF heredoc boundaries. This ensures the agent receives comment-memory context as part of the safe-output tools prompt. ✅
| <safe-output-tools> | ||
| Tools: create_discussion, missing_tool, missing_data, noop | ||
| GH_AW_PROMPT_2068395ca0f8adef_EOF | ||
| cat "${RUNNER_TEMP}/gh-aw/prompts/safe_outputs_comment_memory.md" |
Contributor
There was a problem hiding this comment.
🤖 Smoke test review comment — Good pattern: the comment-memory prompt file is catted after the safe-output tools list but before the closing EOF, so the agent prompt gets the full context. This is consistent across all generated lock files. ✅
Collaborator
|
…ut-type-comment-memory # Conflicts: # .github/workflows/agentic-observability-kit.lock.yml # .github/workflows/daily-hippo-learn.lock.yml # .github/workflows/portfolio-analyst.lock.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/0ebb1620-0947-424a-abed-2a43a5aea483 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Implemented in 4f31106 and 5662ef4. Merged Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
|
Hey Checklist summary:
Verdict: 🟢 Aligned —
|
github-actions Bot
added a commit
that referenced
this pull request
Apr 22, 2026
Add new glossary entries for terms introduced in recent changes: - GitHub Access Mode (tools.github.mode / gh-proxy) from PR #27707 - Comment Memory (tools.comment-memory) from PR #27479 - Supersede Older Reviews (supersede-older-reviews) from PR #27662 - Update AWF entry to mention sandbox.agent.version from PR #27626 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
comment_memorysafe output type that persists memory in a managed issue/PR comment/tmp/gh-aw/comment-memory/(extracting user content from managed XML blocks)comment_memoryfrom the agent-exposed safe-output tool list and prompt tools list; agent now edits memory files directlycomment_memorytool calldocs/src/content/docs/reference/safe-outputs-specification.md) to add thecomment_memorytype and formally document the end-to-end data flow from GitHub comment → local files → agent → artifacts/threat-detection context → managed comment upsertmemory_idlength validation with runtime validation ...comment-memoryexplicitly in smoke workflows so smoke runs cover the feature directly:.github/workflows/smoke-codex.md.github/workflows/smoke-copilot.mdsmoke-codex.lock.yml,smoke-copilot.lock.yml)smoke-codexandsmoke-copilotappend an original 3-line haiku to/tmp/gh-aw/comment-memory/*.md(without removing existing content), explicitly exercising file-based comment-memory editing behavior during smoke runsmainand recompile workflow lock filescomment_memorycomments with an H3 heading (### Comment Memory) so memory comments are clearly labeled, with JS tests updated accordingly✨ PR Review Safe Output Test - Run 24735013438
> 💥 THE END] — Illustrated by [Smoke Claude · ● 251.7K · ◷