Conversation
…meutil - gitutil: add missing IsValidFullSHA documentation; fix IsRateLimitError to include 'secondary rate limit' pattern - logger: document ACTIONS_RUNNER_DEBUG=true enables all loggers - stringutil: fix NormalizeWhitespace description (trims trailing whitespace per-line, not collapse to single space); fix IsPositiveInteger description (must be > 0, no leading zeros); fix NormalizeSafeOutputIdentifier to document period replacement in addition to dash replacement - timeutil: fix FormatDurationNs example (2_500_000_000ns rounds to 3s not 2s due to Go's away-from-zero rounding) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package Specification Updates
This PR fixes inaccuracies found during the spec-extractor round-robin run for 4 packages.
gitutilIsValidFullSHA; fixedIsRateLimitErrordescriptionloggerACTIONS_RUNNER_DEBUG=truebehaviorstringutiltimeutilFormatDurationNsexampleWhat Changed
pkg/gitutil/README.mdIsRateLimitError: description now includes all 3 matched patterns ("api rate limit exceeded", "rate limit exceeded", "secondary rate limit") — the "secondary rate limit" case was previously undocumentedIsValidFullSHA: added missing documentation for this exported function (validates 40-character lowercase hex SHAs)pkg/logger/README.mdACTIONS_RUNNER_DEBUG=truebehavior: when this env var is set (as in GitHub Actions debug runs) andDEBUGis not explicitly set, all loggers are enabled automatically (equivalent toDEBUG=*)pkg/stringutil/README.mdNormalizeWhitespace: previous description said it "collapses multiple consecutive whitespace characters into a single space" — this was completely wrong. The function trims trailing whitespace from each line and ensures exactly one trailing newlineIsPositiveInteger: previous description said "non-empty string containing only digit characters" — this was incomplete. The function actually requires strictly positive integers (no zero, no leading zeros, must parse to > 0)NormalizeSafeOutputIdentifier: previous description said it only converts dashes to underscores — it also converts periods (required because MCP tool names cannot contain periods)pkg/timeutil/README.mdFormatDurationNsexample:FormatDurationNs(2_500_000_000)documented as returning"2s"but Go'stime.Duration.Round(time.Second)rounds half-away from zero, so 2.5s rounds to"3s". Fixed example to use2_000_000_000(exactly 2 billion nanoseconds = 2s)Extraction Method
SPEC_MISMATCHfor the timeutil issue)Round-Robin State
Auto-generated by Package Specification Extractor workflow §24717864418