fix(cli): remove duplicate checkmark in upgrade extension output#27669
Merged
fix(cli): remove duplicate checkmark in upgrade extension output#27669
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/a380e757-aa4f-47f8-b7a3-cf5e7cd2315e Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 21, 2026 20:51
View session
pelikhan
approved these changes
Apr 21, 2026
Copilot stopped work on behalf of
pelikhan due to an error
April 21, 2026 20:52
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes duplicated success checkmarks in gh aw upgrade output by relying solely on console.FormatSuccessMessage(...) to render the checkmark prefix.
Changes:
- Removed hardcoded
✓prefixes from “up to date” and “upgraded to …” success messages in the extension upgrade check path. - Ensured success output uses a single formatting source (
console.FormatSuccessMessage) for consistent rendering.
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/update_extension_check.go | Removes hardcoded checkmarks from success messages to avoid double-prefixing with console.FormatSuccessMessage. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the duplicate checkmark shown by
gh aw upgradewhen extension upgrade succeeds.Changes
✓prefixes from success messages inpkg/cli/update_extension_check.goconsole.FormatSuccessMessage(...)so output renders a single checkmarkValidation
go test -v -run "TestUpgradeExtensionIfOutdated|TestFirstAttemptWriter|TestNeedsRenameWorkaround|TestRenamePathForUpgrade|TestRestoreExecutableBackup|TestCleanupExecutableBackup|TestIsWindowsLockError" ./pkg/cli/passedmake agent-finishwas run and failed on pre-existingsecurity-gosecfindings outside this changeparallel_validationcompleted with no review comments and no CodeQL alerts for changed code