Skip to content

Fix Integration “Workflow Misc Part 2” failures by removing deprecated network.firewall test fixtures#27676

Merged
pelikhan merged 2 commits intomainfrom
copilot/fix-github-actions-workflow-failure
Apr 21, 2026
Merged

Fix Integration “Workflow Misc Part 2” failures by removing deprecated network.firewall test fixtures#27676
pelikhan merged 2 commits intomainfrom
copilot/fix-github-actions-workflow-failure

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 21, 2026

Integration: Workflow Misc Part 2 was failing because several integration test fixtures still used network.firewall, which is no longer accepted by frontmatter schema (network now allows only allowed and blocked). This PR updates those fixtures to current config semantics so the misc integration slice can compile and run.

  • Root cause alignment

    • Replaced legacy network.firewall usage in integration fixtures that are exercised by the Workflow Misc Part 2 CI matrix group.
    • Kept test intent intact (firewall-on default behavior vs explicit firewall-off behavior).
  • Fixture updates by test area

    • pkg/workflow/aw_info_steps_test.go
      • Removed network.firewall: true in the enabled case (relies on current default behavior).
      • Switched the disabled case from network.firewall: false to sandbox.agent: false.
    • pkg/workflow/blocked_domains_integration_test.go
      • Removed network.firewall: true from blocked-domain fixtures; retained allowed/blocked assertions.
    • pkg/workflow/step_summary_test.go
      • Removed network.firewall: true from workflow overview fixture.
  • Config migration pattern used

# before
network:
  firewall: false

# after
sandbox:
  agent: false

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD 6419654/b011/sym--show-toplevel 64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh repo view owner/repo env 1701053854 aMu6/n6X7R7Av3bGkLZAPaMu6 util.test GOINSECURE g/x/net/idna GOMODCACHE util.test 4637�� 3787163/b395/_pkg_.a zLU2/r48K25Cv2sXeJpt1zLU2 .cfg -n1 --format=format:run --end-of-optionsdownload ache/go/1.25.8/x12346 (http block)
    • Triggering command: /usr/bin/gh gh repo view owner/repo env 1701053854 qrnP/bIu9B-2Kyy25-yTJqrnP .cfg GOINSECURE a95/uritemplate/rev-parse GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-buildtags (http block)
  • https://api.github.com/orgs/test-owner/actions/secrets
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json o x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE node (http block)
  • https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq [.object.sha, .object.type] | @tsv download 2 /usr/bin/gh test-logs/run-2 .cfg 64/pkg/tool/linu--show-toplevel gh repo�� view owner/test-repo /usr/bin/git 6419654/b239/_pknode jA_S/QIf0Y67oe1T/opt/hostedtoolcache/node/24.14.1/x64/bin/npm ache/go/1.25.8/xinstall git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq [.object.sha, .object.type] | @tsv --show-toplevel go /usr/bin/git -json GO111MODULE 64/bin/go git rev-�� --show-toplevel go /usr/bin/git -json GO111MODULE ache/go/1.25.8/xinstall git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv k/gh-aw/gh-aw/.github/workflows/ace-editor.md x_amd64/compile /usr/bin/git -json GO111MODULE x_amd64/vet git remo�� GOMODCACHE x_amd64/vet /usr/bin/git -json irent.go x_amd64/vet git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv GOMODCACHE go /usr/bin/git -json GO111MODULE 64/bin/go git init�� GOMODCACHE stat /usr/bin/git --format=%T /sys/fs/cgroup 64/bin/go git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv ithub/workflows rev-parse l -- st/suppress-warn[:lower:] k/node_modules/.[:upper:] git -C k/gh-aw/gh-aw/.github/workflows config r-merged-report.lock.yml remote.origin.urgit --quiet 1/x64/bin/node infocmp (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v5
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv 1053-33589/test-1525498247/.github/workflows o ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet -p reflect -lang=go1.25 ache/go/1.25.8/x--repo -o /tmp/go-build291--json -trimpath /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet -p net/http/internarev-parse -lang=go1.25 /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv --show-toplevel conntrack /usr/bin/git INVALID,NEW -j DROP git rev-�� --show-toplevel x_amd64/vet /usr/bin/git rdian.md 3787163/b218/vetrev-parse ache/go/1.25.8/x--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv --show-toplevel infocmp /usr/bin/git ithub/workflows/git -tests (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv --show-toplevel x_amd64/asm /usr/bin/git -json GO111MODULE x_amd64/compile git -C /tmp/gh-aw-test-runs/20260421-211053-33589/test-1244121129/custom/workflows l /usr/bin/git remote.origin.urgit GO111MODULE x_amd64/vet git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv git-upload-pack '/tmp/TestParseDefaultBranchFromLsRemoteWithRealGitmaster_branchremote.origin.urgit l /usr/bin/git -json GO111MODULE 64/bin/go git -C /tmp/gh-aw-test-runs/20260421-211904-66305/test-1346144590/.github/workflows config /opt/hostedtoolcache/node/24.14.1/x64/bin/node remote.origin.urgit GO111MODULE 64/bin/go node (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v8
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv --show-toplevel ache/go/1.25.8/x^remote\..*\.gh-resolved$ /usr/bin/git ExpressionCompilgit 3787163/b288/vetcheckout ache/go/1.25.8/x-b git rev-�� --show-toplevel ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /usr/bin/git -unreachable=falgit /tmp/go-build346rev-parse 1/x64/bin/node git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv --get-regexp ^remote\..*\.gh-resolved$ /usr/bin/git SameOutput205357git GO111MODULE .cfg git rev-�� --show-toplevel go /usr/bin/git 190579848/.githugit GO111MODULE /opt/hostedtoolc--show-toplevel git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v9
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/asm GOINSECURE GOMOD GOMODCACHE x_amd64/asm env -json 4/arm64.go x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv -json age/common.go x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv -json nal.go x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
  • https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel x_amd64/compile /opt/hostedtoolcache/node/24.14.1/x64/bin/node y-frontmatter.mdgit .cfg x_amd64/link /opt/hostedtoolcache/node/24.14.1/x64/bin/node /tmp�� github.token x_amd64/link /usr/bin/git ortcfg .cfg 64/pkg/tool/linu--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv git git /usr/bin/git -json GO111MODULE x_amd64/vet git rev-�� --show-toplevel x_amd64/vet /usr/bin/git -json GO111MODULE 64/bin/go git (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel x_amd64/vet /opt/hostedtoolcache/node/24.14.1/x64/bin/node -json .cfg 64/pkg/tool/linu--show-toplevel /opt/hostedtoolcache/node/24.14.1/x64/bin/node /tmp�� secrets.TOKEN 64/pkg/tool/linux_amd64/vet /usr/bin/git ty-test.md .cfg 64/pkg/tool/linu--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel go /usr/bin/git -json GO111MODULE 64/bin/go git rev-�� --show-toplevel go /usr/bin/git 93/001/test-emptgit GO111MODULE 64/bin/go git (http block)
  • https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel -extld=gcc /usr/bin/git ntent.md GO111MODULE x_amd64/compile git -C s/test.md rev-parse /usr/bin/git -json g.go x_amd64/compile git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv k/gh-aw/gh-aw/.github/workflows/archie.md -buildtags /opt/hostedtoolcache/node/24.14.1/x64/bin/node -errorsas -ifaceassert -nilfunc node /tmp�� ons-test2169362854 -tests /usr/bin/git l k 64/bin/go git (http block)
  • https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b
    • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq [.object.sha, .object.type] | @tsv --count 0c49b377..HEAD $name) { hasDiscussionsEnabled } } README.md ion-test..token-config es/.bin/git git rev-�� HEAD 0c49b377..HEAD 1/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/node token-test.txt ings.cjs e_modules/.bin/g/home/REDACTED/work/gh-aw/gh-aw/.github/workflows git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq [.object.sha, .object.type] | @tsv 0c49b377..HEAD --stdout ache/uv/0.11.7/x86_64/git ion-test..token-/bin/sh git odules/npm/node_git commit -m 'Initial commit' git rev-�� HEAD 0c49b377..HEAD tions/setup/js/node_modules/.bin/node -m (http block)
    • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq [.object.sha, .object.type] | @tsv --count st/suppress-warnings.cjs $name) { hasDiscussionsEnabled } } README.md ion-test..token---experimental-import-meta-resolve tions/setup/js/n--require st/dist/workers//home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/suppress-warnings.cjs show�� --verify b08ff512 tions/setup/nodedevelopment token-test.txt (http block)
  • https://api.github.com/repos/github/gh-aw
    • Triggering command: /tmp/go-build1353670171/b001/workflow.test /tmp/go-build1353670171/b001/workflow.test -test.testlogfile=/tmp/go-build1353670171/b001/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=8 -test.timeout=10m0s -test.skip=TestCompile|TestWorkflow|TestGenerate|TestParse|TestMCP|TestTool|TestSkill|TestPlaywright|TestFirewall|TestValidat|TestLock|TestError|TestWarning|SafeOutputs|CreatePullRequest|OutputLabel|HasSafeOutputs|GitHub|Git|PushToPullRequest|BuildFromAll kflows/daily-security-red-team.lock.yml -d ings.cjs k/gh-aw/node_modules/.bin/git git -C ithub/workflows config (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0.1.2
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq [.object.sha, .object.type] | @tsv --show-toplevel x_amd64/vet /usr/bin/git -json .cfg 64/pkg/tool/linu--show-toplevel git rev-�� --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git ortcfg .cfg 64/pkg/tool/linu--show-toplevel /usr/bin/git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq [.object.sha, .object.type] | @tsv --show-toplevel go /usr/bin/git -json GO111MODULE x_amd64/vet git rev-�� --show-toplevel x_amd64/vet /usr/bin/git -json GO111MODULE 64/bin/go git (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv ons-test2240471267 config /usr/bin/git remote.origin.urgit GO111MODULE x_amd64/compile git rev-�� --show-toplevel x_amd64/compile 64/pkg/tool/linux_amd64/compile -json GO111MODULE 64/bin/go 64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv /tmp/TestParseDefaultBranchFromLsRemoteWithRealGitmain_branch1426295229/001 /tmp/TestParseDefaultBranchFromLsRemoteWithRealGitmain_branch1426295229/002/work /usr/bin/git GOSUMDB GOWORK 64/bin/go git -C /tmp/gh-aw-test-runs/20260421-211904-66305/test-2065675952/.github/workflows l /usr/bin/git 7469423/b434/_pkgit GO111MODULE 64/bin/go git (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv --show-toplevel x_amd64/asm /usr/bin/git -json GO111MODULE x_amd64/compile git -C /tmp/gh-aw-test-runs/20260421-211053-33589/test-1701053854 config /usr/bin/git remote.origin.urgit GO111MODULE 64/bin/go git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv --show-toplevel GOPROXY /usr/bin/git GOSUMDB GOWORK 64/bin/go git -C /tmp/gh-aw-test-runs/20260421-211904-66305/test-2065675952/.github/workflows remote /usr/bin/git 2352450542/001' 2352450542/001' 64/bin/go git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name g/semverutil/semverutil.go 64/pkg/tool/linux_amd64/vet GOINSECURE (http block)
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE ntio/asm/cpu/armrev-parse GOMODCACHE 64/pkg/tool/linux_amd64/vet env 1244121129 GO111MODULE ache/go/1.25.8/x64/pkg/tool/linu-test.short=true GOINSECURE contextprotocol/rev-parse GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name GO111MODULE .cfg GOINSECURE GOMOD GOMODCACHE go env CompiledOutput1150470933/001 GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE fips140 GOMODCACHE 64/pkg/tool/linuTest User env 1858848426 i2Jk/kxQktkbJrdZm0O72i2Jk .cfg GOINSECURE contextprotocol/init GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 1701053854 aMu6/n6X7R7Av3bGkLZAPaMu6 util.test GOINSECURE g/x/net/idna GOMODCACHE util.test (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name GO111MODULE g_.a GOINSECURE GOMOD GOMODCACHE go env 1904-66305/test-4273487650/.github/workflows GO111MODULE 1/x64/bin/node GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 1858848426 3cxW/IBlaqeSprCJhOYFQ3cxW .cfg GOINSECURE l/ascii GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 GO111MODULE 64/pkg/tool/linux_amd64/vet GOINSECURE fips140/check GOMODCACHE 64/pkg/tool/linux_amd64/vet ortc�� 1701053854 stmain.go .cfg GOINSECURE contextprotocol/init GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-trimpath (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name GO111MODULE 1/x64/bin/node GOINSECURE GOMOD GOMODCACHE go t-ha�� Imports252745338/001/inlined-b.md GO111MODULE ache/go/1.25.8/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 1327050833/.github/workflows 7Ps3/Xuna8G_bMUX3GMM57Ps3 ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE /semver GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name GO111MODULE .cfg GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linuorigin (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 1327050833/.github/workflows taK6/ikh7gQ1RReQdq87ptaK6 64/pkg/tool/linux_amd64/vet GOINSECURE g/x/net/http/httrev-parse GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE boring GOMODCACHE 64/pkg/tool/linux_amd64/vet env 1244121129/custom/workflows 3NxN/fOrMapTM_SttVIFB3NxN ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE th2/internal GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linushow (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name GO111MODULE .cfg GOINSECURE GOMOD GOMODCACHE go env ExpressionCompiledOutput3860004314/001 GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD 6419654/b007/sym-unreachable=false 64/pkg/tool/linu/tmp/go-build3463787163/b113/vet.cfg ache�� 1327050833/.github/workflows GO111MODULE ache/go/1.25.8/x64/pkg/tool/linu-lang=go1.25 GOINSECURE g/x/net/http/httrev-parse GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-dwarf=false (http block)
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE 6419654/b029/emprev-parse ache/go/1.25.8/x--show-toplevel 64/pkg/tool/linux_amd64/vet env 6419654/b140/_pkg_.a GO111MODULE x_amd64/compile GOINSECURE contextprotocol//tmp/js-hash-test-812843248/test-hash.js GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name GO111MODULE .cfg GOINSECURE GOMOD GOMODCACHE go env ExpressionCompiledOutput3860004314/001 GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/link GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linutest@example.com (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 1327050833 fWCy/na03iXLzDBM34i--fWCy ache/go/1.25.8/x64/pkg/tool/linu-buildmode=exe GOINSECURE b/gh-aw/pkg/semvrev-parse GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linuconfig (http block)
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 .cfg 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 6419654/b235/_pkg_.a Kv-X/SrddFjc3EqPBzwz7Kv-X k GOINSECURE osh-tekuri/jsonsrev-parse GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linurev-parse (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name GO111MODULE 39975e9439e75d81e661fd17cc1fbde44eb3393c441943b04ccd3a90f0eb532a-d GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/github/gh-aw/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path -c=4 -nolocalimports -importcfg /tmp/go-build3463787163/b419/importcfg -pack /home/REDACTED/work/gh-aw/gh-aw/pkg/fileutil/fileutil.go /home/REDACTED/work/gh-aw/gh-aw/pkg/fileutil/tar.go env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 GOMOD GOMODCACHE x_amd64/vet env o actions/setup-cli/install.sh..." GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 GOMOD GOMODCACHE x_amd64/compile env til.go o x_amd64/link GOINSECURE fips140/hkdf 6419654/b078/sym--show-toplevel x_amd64/link (http block)
  • https://api.github.com/repos/github/gh-aw/contents/.github/workflows/shared/reporting.md
    • Triggering command: /tmp/go-build3463787163/b404/cli.test /tmp/go-build3463787163/b404/cli.test -test.testlogfile=/tmp/go-build3463787163/b404/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /tmp/go-build2382362822/b404/cli.test /tmp/go-build2382362822/b404/cli.test -test.testlogfile=/tmp/go-build2382362822/b404/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v0.47.4
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq [.object.sha, .object.type] | @tsv --show-toplevel ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /usr/bin/git se 3787163/b189/vetrev-parse ache/go/1.25.8/x--show-toplevel git rev-�� --show-toplevel ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /usr/bin/git 938057016 3787163/b070/_te-lh /opt/hostedtoolc/tmp/gh-aw/aw-feature-branch.patch git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq [.object.sha, .object.type] | @tsv --show-toplevel go /usr/bin/git vaScript20121541git GO111MODULE ache/go/1.25.8/x--show-toplevel git rev-�� --show-toplevel go /usr/bin/git 1904-66305/test-ls GO111MODULE ache/go/1.25.8/x/tmp/gh-aw/aw-feature-branch.patch git (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv se 3787163/b028/vet.cfg ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv k/gh-aw/gh-aw/.github/workflows forks.js yml l 0c49b377 es/.bin/node infocmp -1 k/gh-aw/gh-aw k/gh-aw/gh-aw/ac/home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/suppress-warnrev-parse x_amd64/compile HEAD 0c49b377 1/x64/bin/node x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv ithub/workflows git er.lock.yml --count st/suppress-warn-V=full odules/npm/node_modules/@npmcli/run-script/lib/n/home/REDACTED/work/gh-aw/gh-aw/.github/workflows git -C k/gh-aw/gh-aw/.github/workflows rev-parse piler-quality.lock.yml --verify 0c49b377 DiscussionsEnabl--show-toplevel git (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv adata/main.go GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE SLlQ1ZG/V_z3kiodtest@example.com (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv /var/log GOPROXY 64/bin/go GOSUMDB GOWORK 64/bin/go git conf�� extensions.objectformat node 64/bin/go --write ../../../**/*.jsrev-parse 64/bin/go go (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v2.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet env g_.a GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/vet GOINSECURE GOMOD sm_wasm.s x_amd64/vet env g_.a GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv "prettier" --che-errorsas GOPROXY 64/bin/go GOSUMDB GOWORK 64/bin/go git cat-�� --end-of-options blob 64/bin/go --write ../../../**/*.jsconfig 64/bin/go go (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v3.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet env Gitmain_branch414766131/001' Gitmain_branch414766131/001' x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv "prettier" --cheGOSUMDB GOPROXY 64/bin/go GOSUMDB GOWORK run-script/lib/n--show-toplevel /opt/hostedtoolcache/go/1.25.8/xGO111MODULE -V=f�� Gitmaster_branch667773653/001' Gitmaster_branch667773653/001' 64/bin/go --write ../../../**/*.jsremote 64/bin/go go (http block)
  • https://api.github.com/repos/githubnext/this-repo-definitely-does-not-exist-12345
    • Triggering command: /tmp/go-build1353670171/b001/workflow.test /tmp/go-build1353670171/b001/workflow.test -test.testlogfile=/tmp/go-build1353670171/b001/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=8 -test.timeout=10m0s -test.skip=TestCompile|TestWorkflow|TestGenerate|TestParse|TestMCP|TestTool|TestSkill|TestPlaywright|TestFirewall|TestValidat|TestLock|TestError|TestWarning|SafeOutputs|CreatePullRequest|OutputLabel|HasSafeOutputs|GitHub|Git|PushToPullRequest|BuildFromAll kflows/daily-security-red-team.lock.yml -d ings.cjs k/gh-aw/node_modules/.bin/git git -C ithub/workflows config (http block)
  • https://api.github.com/repos/my-org/secrets-action/git/ref/tags/v2
    • Triggering command: /usr/bin/gh gh api /repos/my-org/secrets-action/git/ref/tags/v2 --jq [.object.sha, .object.type] | @tsv ithub/workflows config x_amd64/cgo remote.origin.urgit 0c49b377 _modules/.bin/gi--show-toplevel x_amd64/cgo s,Em�� ithub/workflows 1/x64/bin/node (http block)
    • Triggering command: /usr/bin/gh gh api /repos/my-org/secrets-action/git/ref/tags/v2 --jq [.object.sha, .object.type] | @tsv ithub/workflows st/dist/workers//home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/suppress-warnrev-parse x_amd64/asm HEAD 0c49b377 tions/setup/js/n--show-toplevel x_amd64/asm -C ithub/workflows show /usr/bin/git --verify 9b8fa0a26ae1a186rev-parse $name) { has--show-toplevel git (http block)
  • https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq [.object.sha, .object.type] | @tsv g_.a 3787163/b025/vet.cfg k GOINSECURE ole GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-importcfg sRem�� 1773/001/stability-test.md 3787163/b084/vet.cfg ache/go/1.25.8/x64/pkg/tool/linu-buildmode=exe -I /tmp/go-build291remote -I ortcfg (http block)
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq [.object.sha, .object.type] | @tsv -json e 64/bin/go GOINSECURE GOMOD GOMODCACHE go env LsRemoteWithRealGitmaster_branch667773653/001' LsRemoteWithRealGitmaster_branch667773653/001' 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/nonexistent/repo/actions/runs/12345
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE e/jsonschema-go/rev-parse GOMODCACHE 64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x^remote\..*\.gh-resolved$ env FieldEnforcement2296426368/001 GO111MODULE /opt/hostedtoolcache/go/1.25.8/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/owner/repo/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json age.go x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh workflow list --repo owner/repo --json name,path,state ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE l 6419654/b092/sym--show-toplevel ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
  • https://api.github.com/repos/test-owner/test-repo/actions/secrets
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json gset/set.go x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE node (http block)
  • https://api.github.com/repos/test/repo
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch sm-opt >/dev/null 2>&1; then \ echo "Running wasm-opt -Oz (size optimization)..."; \ BEFORE=$(docker GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch xterm-color -tests /usr/bin/git -json GO111MODULE 64/bin/go git -C /tmp/TestGuardPolicyTrustedUsersExpressionCompiledOutput3860004314/001 remote mple.com/org/repo.git -json GO111MODULE 64/bin/go git (http block)
  • invalid.example.invalid
    • Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin https://invalid.example.invalid/nonexistent-repo.git git conf�� --local --get ode_modules/.bin/git cal/bin/git git /git git add . git tions/setup/node_modules/.bin/git -M main bin/git git (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@github-actions
Copy link
Copy Markdown
Contributor

Hey @Copilot 👋 — thanks for picking up the failing Integration: Workflow Misc Part 2 workflow! The task checklist is a great starting point, but a few things will be needed before this can land:

  • Add a description — the PR body is currently a task checklist without context. Once the root cause is identified, please add a short summary explaining what is broken and why the chosen fix addresses it. This helps reviewers and future readers understand the change without digging through CI logs.
  • Include tests — the checklist already calls this out ("Add or adjust focused tests for the regression"), but the diff is currently empty. Make sure regression tests land alongside the fix so the failure can't silently reappear.

When you're ready to move beyond the WIP stage, here's a prompt you can use to drive the next steps:

You are working on PR #27676 in github/gh-aw, which fixes the failing CI job "Integration: Workflow Misc Part 2".

Steps to complete:
1. Inspect the latest failing CI run for "Integration: Workflow Misc Part 2" and identify the root cause (parser error, validation path, test regression, etc.).
2. Implement the minimal fix in the relevant source file(s).
3. Add or adjust focused unit/integration tests that reproduce the failure and confirm the fix.
4. Run `make agent-finish` to validate all checks pass locally.
5. Update the PR body with a plain-English description: what was broken, why it broke, and what the fix does.
6. Push the changes and mark the PR as ready for review.

Generated by Contribution Check · ● 1.5M ·

…ork.firewall

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/07f1ceb0-ceab-47ee-a71d-5f84a5f6979a

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix the failing GitHub Actions workflow Integration: Workflow Misc Part 2 Fix Integration “Workflow Misc Part 2” failures by removing deprecated network.firewall test fixtures Apr 21, 2026
Copilot AI requested a review from pelikhan April 21, 2026 21:27
@pelikhan pelikhan marked this pull request as ready for review April 21, 2026 21:33
Copilot AI review requested due to automatic review settings April 21, 2026 21:33
@pelikhan pelikhan merged commit 457b09d into main Apr 21, 2026
5 checks passed
@pelikhan pelikhan deleted the copilot/fix-github-actions-workflow-failure branch April 21, 2026 21:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates integration test fixtures to remove deprecated network.firewall frontmatter usage so the Integration: Workflow Misc Part 2 suite compiles and runs against the current schema.

Changes:

  • Removed network.firewall: true from integration fixtures that already rely on default firewall behavior.
  • Migrated the “firewall disabled” fixture from network.firewall: false to sandbox.agent: false.
Show a summary per file
File Description
pkg/workflow/step_summary_test.go Drops deprecated network.firewall from the workflow overview fixture while keeping network allowlist intact.
pkg/workflow/blocked_domains_integration_test.go Removes deprecated network.firewall from multiple blocked-domains integration fixtures.
pkg/workflow/aw_info_steps_test.go Removes deprecated network.firewall usage and switches the disabled case to sandbox.agent: false.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/3 changed files
  • Comments generated: 0

@github-actions github-actions Bot mentioned this pull request Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🧪 Test Quality Sentinel Report

Test Quality Score: 100/100

Excellent test quality

Metric Value
New/modified tests analyzed 3
✅ Design tests (behavioral contracts) 3 (100%)
⚠️ Implementation tests (low value) 0 (0%)
Tests with error/edge cases 3 (100%)
Duplicate test clusters 0
Test inflation detected No (net -12 lines in test files, 0 in production files)
🚨 Coding-guideline violations None

What Changed

This PR contains no new test functions. All three modified test files received only fixture-data changes — the embedded workflow YAML strings inside existing test cases were updated to remove the deprecated network.firewall field:

  • aw_info_steps_test.go: Removed network.firewall: true from the "firewall enabled" fixture; replaced network.firewall: false with sandbox.agent: false in the "firewall disabled" fixture.
  • blocked_domains_integration_test.go: Removed firewall: true from 5 sub-test workflow fixtures.
  • step_summary_test.go: Removed firewall: true from the workflow overview fixture.

The test logic, assertions, and structure are completely unchanged.


Test Classification Details

View Test Classifications
Test File Classification Notes
TestAwInfoStepsFirewall pkg/workflow/aw_info_steps_test.go ✅ Design Table-driven; verifies GH_AW_INFO_FIREWALL_TYPE env var in compiled output for enabled/disabled/default cases
TestBlockedDomainsIntegration pkg/workflow/blocked_domains_integration_test.go ✅ Design 5 sub-tests; verifies --block-domains presence/absence across copilot, claude, codex engines
TestStepSummaryIncludesWorkflowOverview pkg/workflow/step_summary_test.go ✅ Design Table-driven; verifies env vars, step ordering, and step structure in compiled YAML

All three are integration tests (//go:build integration) that compile real workflows and assert on the compiled YAML output — a behavioral contract for the compiler.


Language Support

Tests analyzed:

  • 🐹 Go (*_test.go): 3 tests — integration (//go:build integration)
  • 🟨 JavaScript (*.test.cjs, *.test.js): 0 tests

Verdict

Check passed. 0% of modified tests are implementation tests (threshold: 30%). The changes are purely maintenance fixes removing deprecated network.firewall configuration from test fixtures. No behavioral coverage was reduced.


📖 Understanding Test Classifications

Design Tests (High Value) verify what the system does:

  • Assert on observable outputs, return values, or state changes
  • Cover error paths and boundary conditions
  • Would catch a behavioral regression if deleted
  • Remain valid even after internal refactoring

Implementation Tests (Low Value) verify how the system does it:

  • Assert on internal function calls (mocking internals)
  • Only test the happy path with typical inputs
  • Break during legitimate refactoring even when behavior is correct
  • Give false assurance: they pass even when the system is wrong

Goal: Shift toward tests that describe the system's behavioral contract — the promises it makes to its users and collaborators.

References: §24747554885

🧪 Test quality analysis by Test Quality Sentinel · ● 932.8K ·

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Test Quality Sentinel: 100/100. Test quality is excellent — 0% of modified tests are implementation tests (threshold: 30%). Changes are purely fixture maintenance (removing deprecated network.firewall field); no test logic was altered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants