Add smoke-ci coverage for cache/repo memory and update safe outputs#27683
Add smoke-ci coverage for cache/repo memory and update safe outputs#27683
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/09db4881-b2ff-48bc-b8d1-f5286e247905 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/09db4881-b2ff-48bc-b8d1-f5286e247905 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... |
|
🚀 Smoke OpenCode MISSION COMPLETE! OpenCode delivered. 🔥 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
|
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
|
Agent Container Tool Check
Result: 11/12 tools available — FAIL (dotnet missing)
|
There was a problem hiding this comment.
Pull request overview
Expands the smoke-ci workflow to exercise additional agent tools (cache/repo memory) and safe-output capabilities across both PR-triggered and scheduled runs.
Changes:
- Add
cache-memoryandrepo-memorytools plus updated prompt instructions to use them. - Add safe outputs for
create-issue,update-issue, andupdate-pull-request, and extend the run flow to exercise them. - Switch to
schedule: dailyin the source workflow and recompile the generated lock workflow (including repo-memory push plumbing).
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/smoke-ci.md | Adds schedule trigger, enables cache/repo memory tools, and extends safe-outputs + instructions to exercise new behaviors. |
| .github/workflows/smoke-ci.lock.yml | Recompiled workflow reflecting new tools, safe outputs, caching setup, and repo-memory push job. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (2)
.github/workflows/smoke-ci.md:59
- The instructions for step 3 say to call
create_issueand include the run URL in the body, butcreate_issuealso requires atitle. Without explicitly instructing a title, the agent may emit an invalid safe output and fail validation. Update the instruction to specify a concrete title format (it will still be prefixed by[smoke-ci]via config).
2. Use `repo-memory` to write a short markdown run note.
3. Use `create_issue` with temporary ID `aw_smokeci` and include the run URL in the body.
4. Use `update_issue` targeting `aw_smokeci` with `operation: "append"` to add a second line confirming the update succeeded.
.github/workflows/smoke-ci.md:66
update-pull-requestis configured withtarget: "*", which means the tool call must includepull_request_number(oritem_number). The instructions for pull_request events say to update the triggering PR, but they don't explicitly require including the PR number, so the agent could omit it and the handler will fail with "Target is '*' but no ... specified". Adjust the instruction to requirepull_request_number(e.g., from the triggering PR context) on PR events as well.
For pull_request events, then call these safe output tools in this exact order:
1. `add_comment` with a short smoke-ci message that includes the run URL.
2. `add_labels` with exactly `["ai-generated"]`.
3. `remove_labels` with exactly `["ai-generated"]`.
4. `update_pull_request` on the triggering pull request with `operation: "append"` and a short body line including the run URL.
- Files reviewed: 2/2 changed files
- Comments generated: 1
| allowed: [ai-generated] | ||
| update-issue: | ||
| body: | ||
| max: 1 |
There was a problem hiding this comment.
update-issue safe-output is missing a target: "*" (or explicit number). With the current default target of triggering, the handler will skip updates when the workflow runs in pull_request or schedule context, so step 4 in the instructions (updating the issue created in step 3) will never execute. Configure update-issue.target: "*" so the agent can provide issue_number (including a temporary ID) and update the created issue in non-issue events.
This issue also appears in the following locations of the same file:
- line 57
- line 61
| max: 1 | |
| max: 1 | |
| target: "*" |
|
💥 Smoke Test Run §24747405793 — PARTIAL
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal! (Run 24747405793)
💥 [THE END] — Illustrated by Smoke Claude · ● 202.4K
| on: | ||
| push: | ||
| branches: [main] | ||
| schedule: daily |
There was a problem hiding this comment.
🔍 Smoke test review comment #1 (Run 24747405793): The schedule: daily trigger looks good — using the shorthand syntax correctly. This will run the workflow once per day on the schedule defined in the compiled lock file.
| pull-requests: read | ||
| engine: copilot | ||
| tools: | ||
| cache-memory: true |
There was a problem hiding this comment.
🔍 Smoke test review comment #2 (Run 24747405793): Adding cache-memory: true and repo-memory configuration here enables persistent storage across workflow runs — great addition for the smoke CI to track historical run data.
|
Smoke Test 24747405891 —
Overall: PASS
|
Comment Memory# Smoke Test NotesTests run, code compiled clean,
|
There was a problem hiding this comment.
Smoke test review of PR #27683. The expanded smoke-ci workflow looks good — adds useful coverage for cache-memory, repo-memory, create_issue, update_issue, and update_pull_request. Left 2 inline comments on notable details.
📰 BREAKING: Report filed by Smoke Copilot · ● 3.4M
| update-pull-request: | ||
| body: true | ||
| max: 1 | ||
| target: "*" |
There was a problem hiding this comment.
The target: "*" setting for update-pull-request allows the agent to target any PR — this is intentional for the scheduled run path, but it's worth documenting that this gives the agent broad write access to PR bodies across the repository.
| 1. Use `cache-memory` to write a short JSON record for this run. | ||
| 2. Use `repo-memory` to write a short markdown run note. | ||
| 3. Use `create_issue` with temporary ID `aw_smokeci` and include the run URL in the body. | ||
| 4. Use `update_issue` targeting `aw_smokeci` with `operation: "append"` to add a second line confirming the update succeeded. |
There was a problem hiding this comment.
Good pattern using aw_smokeci as a temporary ID to chain create_issue → update_issue. This validates the cross-reference mechanism nicely.
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Summary
smoke-cito exercise additional capabilities from both PR and scheduled runscache-memoryandrepo-memorytools to the workflowupdate-issueandupdate-pull-requestsafe outputs (pluscreate-issueto reliably driveupdate-issue)dailyand recompiled lock outputFiles changed
.github/workflows/smoke-ci.md.github/workflows/smoke-ci.lock.ymlValidation
make recompile✅make agent-finish❌ (fails due pre-existing repo-widesecurity-gosecfindings unrelated to this change)✨ PR Review Safe Output Test - Run 24747405793