Fix smoke-ci safe_outputs failure on schedule-triggered runs#27705
Merged
Fix smoke-ci safe_outputs failure on schedule-triggered runs#27705
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/6f825f54-3a6d-4339-ae36-bbca5982821d Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 21, 2026 22:29
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes smoke-ci scheduled runs failing in the safe_outputs job by ensuring update-issue doesn’t default to target: triggering (which requires an issue-event context).
Changes:
- Set
safe-outputs.update-issue.target: "*"in.github/workflows/smoke-ci.md. - Regenerated
.github/workflows/smoke-ci.lock.ymlso the compiled safe-outputs handler config and tool constraints include the newupdate_issuetarget behavior.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/smoke-ci.md |
Updates the safe-outputs update-issue configuration to work outside issue-event contexts (e.g., schedule). |
.github/workflows/smoke-ci.lock.yml |
Propagates the updated safe-outputs configuration into the compiled/locked workflow. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
| update-issue: | ||
| body: | ||
| max: 1 | ||
| target: "*" |
There was a problem hiding this comment.
Setting target: "*" means update-issue can update any issue number in the repo. To keep this workflow least-privileged (and scoped to issues it creates), add an update-issue.title-prefix: "[smoke-ci] " (and/or a required label) so the handler rejects updates to unrelated issues if the agent outputs an incorrect issue_number/temporary id.
Suggested change
| target: "*" | |
| target: "*" | |
| title-prefix: "[smoke-ci] " |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
safe_outputsjob insmoke-cifailed on scheduled runs becauseupdate_issuedefaulted totarget: triggering, which requires issue-event context. In schedule context, this caused a skippedupdate_issueto be treated as a failed safe-output message.Root cause
update_issuewas configured without an explicit target, so it resolved totriggering.Target is "triggering" but not running in issue context, skipping update_issueConfiguration change
.github/workflows/smoke-ci.md:safe-outputs.update-issue.target: "*"update_issueresolve the issue number from payload fields / temporary-id resolution instead of relying on issue-event context.Compiled workflow update
.github/workflows/smoke-ci.lock.ymlto propagate the new safe-output handler config and tool constraints forupdate_issue.