Skip to content

Fix smoke-ci safe_outputs failure on schedule-triggered runs#27705

Merged
pelikhan merged 1 commit intomainfrom
copilot/fix-safe-outputs-workflow
Apr 21, 2026
Merged

Fix smoke-ci safe_outputs failure on schedule-triggered runs#27705
pelikhan merged 1 commit intomainfrom
copilot/fix-safe-outputs-workflow

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 21, 2026

The safe_outputs job in smoke-ci failed on scheduled runs because update_issue defaulted to target: triggering, which requires issue-event context. In schedule context, this caused a skipped update_issue to be treated as a failed safe-output message.

  • Root cause

    • update_issue was configured without an explicit target, so it resolved to triggering.
    • Scheduled runs do not have a triggering issue payload, producing:
      • Target is "triggering" but not running in issue context, skipping update_issue
  • Configuration change

    • Updated .github/workflows/smoke-ci.md:
      • safe-outputs.update-issue.target: "*"
    • This makes update_issue resolve the issue number from payload fields / temporary-id resolution instead of relying on issue-event context.
  • Compiled workflow update

    • Regenerated .github/workflows/smoke-ci.lock.yml to propagate the new safe-output handler config and tool constraints for update_issue.
safe-outputs:
  update-issue:
    body:
    max: 1
    target: "*"

@pelikhan pelikhan marked this pull request as ready for review April 21, 2026 22:30
Copilot AI review requested due to automatic review settings April 21, 2026 22:30
@pelikhan pelikhan merged commit dc48e4b into main Apr 21, 2026
5 checks passed
@pelikhan pelikhan deleted the copilot/fix-safe-outputs-workflow branch April 21, 2026 22:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes smoke-ci scheduled runs failing in the safe_outputs job by ensuring update-issue doesn’t default to target: triggering (which requires an issue-event context).

Changes:

  • Set safe-outputs.update-issue.target: "*" in .github/workflows/smoke-ci.md.
  • Regenerated .github/workflows/smoke-ci.lock.yml so the compiled safe-outputs handler config and tool constraints include the new update_issue target behavior.
Show a summary per file
File Description
.github/workflows/smoke-ci.md Updates the safe-outputs update-issue configuration to work outside issue-event contexts (e.g., schedule).
.github/workflows/smoke-ci.lock.yml Propagates the updated safe-outputs configuration into the compiled/locked workflow.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 1

update-issue:
body:
max: 1
target: "*"
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting target: "*" means update-issue can update any issue number in the repo. To keep this workflow least-privileged (and scoped to issues it creates), add an update-issue.title-prefix: "[smoke-ci] " (and/or a required label) so the handler rejects updates to unrelated issues if the agent outputs an incorrect issue_number/temporary id.

Suggested change
target: "*"
target: "*"
title-prefix: "[smoke-ci] "

Copilot uses AI. Check for mistakes.
@github-actions github-actions Bot mentioned this pull request Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants