Conversation
Add missing coverage for the comment-memory safe output type: - pkg/cli/workflows/test-copilot-comment-memory.md: new test workflow - pkg/workflow/compiler_safe_outputs_config_test.go: new comment_memory config test case Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
@copilot comment-memory is now under tools.comment-memory. Update specification. |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/55a8e8f0-8cd3-499b-86ea-a6b58638d081 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Updated in 2443f45: Screenshot: N/A (no UI changes). Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safe Output Test Coverage
This PR adds test workflow and Go compiler test for the one safe-output type that lacked test coverage.
Analysis
Scanned all 43 safe-output types from
SafeOutputsConfiginpkg/workflow/compiler_types.goagainst:pkg/cli/workflows/(101 files withsafe-outputs:)pkg/workflow/compiler_safe_outputs_config_test.go(44 test cases)Only
comment-memorywas missing coverage — all other types were already covered.New Test Workflow Added
pkg/cli/workflows/test-copilot-comment-memory.md— tests thecomment_memorysafe output type with the Copilot engine, usingmemory-idconfigurationGo Test Added
Added
comment_memory configtest case toTestAddHandlerManagerConfigEnvVarinpkg/workflow/compiler_safe_outputs_config_test.go, verifying thatCommentMemoryConfig(withMemoryID) correctly generates theGH_AW_SAFE_OUTPUTS_HANDLER_CONFIGenv var with keycomment_memory.Summary
All 43 safe-output types now have test workflows and Go compiler test coverage (previously 42/43 covered, now 43/43).