Skip to content

Update smoke-ci haiku cache-memory behavior and issue body count#27849

Merged
pelikhan merged 2 commits intomainfrom
copilot/update-smoke-ci-haiku-cache
Apr 22, 2026
Merged

Update smoke-ci haiku cache-memory behavior and issue body count#27849
pelikhan merged 2 commits intomainfrom
copilot/update-smoke-ci-haiku-cache

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 22, 2026

Summary

Update the smoke-ci workflow instructions so each run:

  • counts how many haiku records already exist in cache-memory
  • writes a new haiku JSON record to cache-memory
  • includes the run URL, generated haiku text, and existing haiku count in the created issue body

Validation

  • Ran make recompile
  • Ran make agent-finish (fails due to pre-existing testifylint issues in pkg/agentdrain/spec_test.go unrelated to this change)
  • Ran parallel validation (Code Review + CodeQL) after final update

Copilot AI and others added 2 commits April 22, 2026 14:01
@pelikhan pelikhan marked this pull request as ready for review April 22, 2026 14:47
Copilot AI review requested due to automatic review settings April 22, 2026 14:47
@pelikhan pelikhan merged commit 6213c7f into main Apr 22, 2026
83 of 86 checks passed
@pelikhan pelikhan deleted the copilot/update-smoke-ci-haiku-cache branch April 22, 2026 14:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Smoke CI workflow instructions to persist and report haiku-related cache state across runs.

Changes:

  • Add a cache-memory inspection step to compute existing_haiku_count before writing a new record.
  • Persist a new per-run haiku JSON record using a filesystem-safe timestamp filename.
  • Expand the created issue body requirements to include the run URL, haiku text, and existing record count.
Show a summary per file
File Description
.github/workflows/smoke-ci.md Adjusts the prescribed tool-call sequence to count existing haiku cache entries, write a new haiku record, and include the count + haiku in the issue body.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 2

Comment on lines +57 to +58
1. Use `cache-memory` to inspect `/tmp/gh-aw/cache-memory/smoke-ci-haiku/`, count how many haiku records already exist, then save that count as `existing_haiku_count`.
2. Create a new haiku for this run and use `cache-memory` to save it as a JSON record in `/tmp/gh-aw/cache-memory/smoke-ci-haiku/` with a filesystem-safe timestamp filename in `YYYY-MM-DD-HH-MM-SS-sss` format (no `:`).
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 1 assumes /tmp/gh-aw/cache-memory/smoke-ci-haiku/ already exists. On a first run (or after cache eviction), inspecting/listing this directory may fail and break the workflow. Please clarify that if the directory is missing, existing_haiku_count must be set to 0 and the directory should be created before writing the new record.

Suggested change
1. Use `cache-memory` to inspect `/tmp/gh-aw/cache-memory/smoke-ci-haiku/`, count how many haiku records already exist, then save that count as `existing_haiku_count`.
2. Create a new haiku for this run and use `cache-memory` to save it as a JSON record in `/tmp/gh-aw/cache-memory/smoke-ci-haiku/` with a filesystem-safe timestamp filename in `YYYY-MM-DD-HH-MM-SS-sss` format (no `:`).
1. Use `cache-memory` to inspect `/tmp/gh-aw/cache-memory/smoke-ci-haiku/` and count how many haiku records already exist; if the directory is missing, set `existing_haiku_count` to `0`.
2. Create a new haiku for this run and use `cache-memory` to save it as a JSON record in `/tmp/gh-aw/cache-memory/smoke-ci-haiku/`, creating that directory first if it does not already exist, with a filesystem-safe timestamp filename in `YYYY-MM-DD-HH-MM-SS-sss` format (no `:`).

Copilot uses AI. Check for mistakes.
Comment on lines +57 to +58
1. Use `cache-memory` to inspect `/tmp/gh-aw/cache-memory/smoke-ci-haiku/`, count how many haiku records already exist, then save that count as `existing_haiku_count`.
2. Create a new haiku for this run and use `cache-memory` to save it as a JSON record in `/tmp/gh-aw/cache-memory/smoke-ci-haiku/` with a filesystem-safe timestamp filename in `YYYY-MM-DD-HH-MM-SS-sss` format (no `:`).
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new JSON record format is underspecified: it doesn’t say what fields must be included (e.g., run URL, haiku text, timestamp, existing count) or even whether the filename should end in .json. Without a defined schema/extension, future reads and the file-counting logic can become inconsistent. Please specify the required JSON keys and a consistent filename pattern (including extension).

Suggested change
1. Use `cache-memory` to inspect `/tmp/gh-aw/cache-memory/smoke-ci-haiku/`, count how many haiku records already exist, then save that count as `existing_haiku_count`.
2. Create a new haiku for this run and use `cache-memory` to save it as a JSON record in `/tmp/gh-aw/cache-memory/smoke-ci-haiku/` with a filesystem-safe timestamp filename in `YYYY-MM-DD-HH-MM-SS-sss` format (no `:`).
1. Use `cache-memory` to inspect `/tmp/gh-aw/cache-memory/smoke-ci-haiku/`, count how many existing haiku record files match `*.json`, then save that count as `existing_haiku_count`.
2. Create a new haiku for this run and use `cache-memory` to save it in `/tmp/gh-aw/cache-memory/smoke-ci-haiku/` as a JSON object with exactly these required keys: `run_url`, `haiku_text`, `timestamp`, and `existing_haiku_count`. Use the consistent filename pattern `YYYY-MM-DD-HH-MM-SS-sss.json` (filesystem-safe, no `:`).

Copilot uses AI. Check for mistakes.
@github-actions github-actions Bot mentioned this pull request Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants