[log] feat(logging): add dedicated debug loggers to 5 pkg files#27904
Merged
[log] feat(logging): add dedicated debug loggers to 5 pkg files#27904
Conversation
Adds per-file named loggers to replace the shared package-level `log`
variable (labeled "workflow:compiler") that several workflow files
were incorrectly inheriting. This ensures DEBUG filtering by component
name works correctly (e.g. DEBUG=workflow:runtime_deduplication).
- runtime_deduplication.go: runtimeDeduplicationLog ("workflow:runtime_deduplication")
- mcp_playwright_config.go: playwrightConfigLog ("workflow:mcp_playwright")
- prompts.go: promptsLog ("workflow:prompts")
- compiler_safe_outputs_builder.go: safeOutputsBuilderLog ("workflow:safe_outputs_builder")
- stringutil/ansi.go: ansiLog ("stringutil:ansi") with entry-point logging
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds per-file named loggers to files that were incorrectly inheriting the shared
logvariable fromcompiler.go(labeled"workflow:compiler"). Without this fix, enablingDEBUG=workflow:runtime_deduplicationproduces no output because the underlying logger is named"workflow:compiler".Changes
pkg/workflow/runtime_deduplication.go—runtimeDeduplicationLog("workflow:runtime_deduplication")pkg/workflow/mcp_playwright_config.go—playwrightConfigLog("workflow:mcp_playwright")pkg/workflow/prompts.go—promptsLog("workflow:prompts")pkg/workflow/compiler_safe_outputs_builder.go—safeOutputsBuilderLog("workflow:safe_outputs_builder") with log calls ingetEffectiveFooterForTemplatableandgetEffectiveFooterStringpkg/stringutil/ansi.go—ansiLog("stringutil:ansi") with entry-point log inStripANSITest plan
make buildpassesmake test-unit(Go toolchain version mismatch in CI environment — changes are purely additive: no logic altered, only variable name substitutions and new log declarations)