test: satisfy testifylint assertions in agentdrain spec test

[Copilot]

Summary

• Replace two assertion patterns in pkg/agentdrain/spec_test.go with testifylint-preferred forms
• Change assert.Equal(t, 0, len(...)) to assert.Empty(...)
• Change assert.Equal(t, 1, len(...)) to assert.Len(..., 1)

Why

• Improves test quality/style consistency
• Removes existing lint failures in the touched test area
• Keeps behavior unchanged while aligning with repository lint expectations

Validation

• make fmt
• go test -v -run "TestSpec_PublicAPI_Miner_ClusterCount_SPEC_MISMATCH" ./pkg/agentdrain
• make golint
• make agent-finish (fails in this environment at make recompile due an existing workflow compilation issue: Successfully compiled 196 out of 197 workflow files)
• parallel_validation (Code Review + CodeQL)

[Copilot]

Pull request overview

Updates pkg/agentdrain/spec_test.go assertions to satisfy testifylint by using assert.Empty / assert.Len instead of comparing len(...) to numeric literals.

Changes:

• Replaced assert.Equal(t, 0, len(...)) with assert.Empty(...)
• Replaced assert.Equal(t, 1, len(...)) with assert.Len(..., 1)

Show a summary per file

File	Description
pkg/agentdrain/spec_test.go	Adjusts assertions in the miner cluster-count spec mismatch test to align with testifylint-preferred patterns.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0

[github-actions]

🧪 Test Quality Sentinel Report

Test Quality Score: 100/100

✅ Excellent test quality

Metric	Value
New/modified tests analyzed	1
✅ Design tests (behavioral contracts)	1 (100%)
⚠️ Implementation tests (low value)	0 (0%)
Tests with error/edge cases	1 (100%)
Duplicate test clusters	0
Test inflation detected	No
🚨 Coding-guideline violations	None

---

Test Classification Details

Test	File	Classification	Issues Detected
TestSpec_PublicAPI_Miner_ClusterCount_SPEC_MISMATCH	pkg/agentdrain/spec_test.go:485	✅ Design	None

---

What Changed

This PR replaces two assert.Equal(t, N, len(x), ...) assertions with their idiomatic testify equivalents to satisfy testifylint:

• assert.Equal(t, 0, len(miner.Clusters()), ...) → assert.Empty(t, miner.Clusters(), ...)
• assert.Equal(t, 1, len(miner.Clusters()), ...) → assert.Len(t, miner.Clusters(), 1, ...)

The behavioral contract being tested is identical — only the assertion style changed. The test continues to verify:

1. Cluster count is zero before any training (initial state contract)
2. Cluster count becomes 1 after training one unique event (state-transition contract)

Both assertion messages are preserved and descriptive.

---

Language Support

Tests analyzed:

• 🐹 Go (*_test.go): 1 test — unit (//go:build !integration)
• 🟨 JavaScript (*.test.cjs, *.test.js): 0 tests

---

Verdict

✅ Check passed. 0% of new tests are implementation tests (threshold: 30%). No coding-guideline violations detected. The change is a pure linter-compliance improvement with no reduction in behavioral coverage.

---

📖 Understanding Test Classifications

Design Tests (High Value) verify what the system does:

• Assert on observable outputs, return values, or state changes
• Cover error paths and boundary conditions
• Would catch a behavioral regression if deleted
• Remain valid even after internal refactoring

Implementation Tests (Low Value) verify how the system does it:

• Assert on internal function calls (mocking internals)
• Only test the happy path with typical inputs
• Break during legitimate refactoring even when behavior is correct
• Give false assurance: they pass even when the system is wrong

Goal: Shift toward tests that describe the system's behavioral contract — the promises it makes to its users and collaborators.

References: §24806767912

🧪 Test quality analysis by Test Quality Sentinel · ● 573.4K · ◷

[github-actions]

✅ Test Quality Sentinel: 100/100. Test quality is excellent — 0% of new tests are implementation tests (threshold: 30%). This PR makes a pure testifylint compliance improvement, replacing assert.Equal(t, N, len(x)) with the idiomatic assert.Empty/assert.Len equivalents. No behavioral coverage was reduced.