-
Notifications
You must be signed in to change notification settings - Fork 359
Fix Codex TOML provider ordering so model_provider stays root-level under firewall mode
#27959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -125,10 +125,10 @@ func (e *CodexEngine) RenderMCPConfig(yaml *strings.Builder, tools map[string]an | |
|
|
||
| shellPolicyDelimiter := GenerateHeredocDelimiterFromSeed("CODEX_SHELL_POLICY", workflowData.FrontmatterHash) | ||
| yaml.WriteString(" cat > \"/tmp/gh-aw/mcp-config/config.toml\" << " + shellPolicyDelimiter + "\n") | ||
| e.renderShellEnvironmentPolicyToml(yaml, tools, mcpTools, " ") | ||
| if isFirewallEnabled(workflowData) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The reordering of |
||
| e.renderOpenAIProxyProviderToml(yaml, " ") | ||
| } | ||
| e.renderShellEnvironmentPolicyToml(yaml, tools, mcpTools, " ") | ||
| yaml.WriteString(" " + shellPolicyDelimiter + "\n") | ||
| if isFirewallEnabled(workflowData) { | ||
| e.renderAppendConvertedConfigWithoutOpenAIProxy(yaml) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good defensive test: verifying that
model_providerindex comes before[shell_environment_policy]index in the sync block directly encodes the TOML ordering contract. This prevents future regressions if someone reorders the render calls again.