[fp-enhancer] refactor(actionpins): use slices/maps stdlib for declarative transformations

[github-actions]

Summary

Applied moderate functional/immutability improvements to pkg/actionpins (round-robin pass 1/22).

Changes in pkg/actionpins/actionpins.go:

1. Declarative map-to-slice conversion

Replaced an imperative make + append loop with slices.Collect(maps.Values(...)):

// Before
pins := make([]ActionPin, 0, len(data.Entries))
for _, pin := range data.Entries {
    pins = append(pins, pin)
}

// After
pins := slices.Collect(maps.Values(data.Entries))

2. slices.SortFunc with cmp.Compare (two call sites)

Replaced sort.Slice (index-based closure) with slices.SortFunc (value-based closure) for cleaner, safer comparisons:

// Before
sort.Slice(pins, func(i, j int) bool {
    if pins[i].Version != pins[j].Version {
        return pins[i].Version > pins[j].Version
    }
    return pins[i].Repo < pins[j].Repo
})

// After
slices.SortFunc(pins, func(a, b ActionPin) int {
    if a.Version != b.Version {
        return cmp.Compare(b.Version, a.Version)
    }
    return cmp.Compare(a.Repo, b.Repo)
})

3. Idiomatic nil-check for container pins

Simplified the if/else nil-guard to a positive-first pattern:

// Before
if data.Containers == nil {
    cachedContainerPins = make(map[string]ContainerPin)
} else {
    cachedContainerPins = data.Containers
}

// After
cachedContainerPins = data.Containers
if cachedContainerPins == nil {
    cachedContainerPins = make(map[string]ContainerPin)
}

Benefits

• Clarity: slices.SortFunc receives values directly (not indices), making comparisons easier to read and review
• Safety: Eliminates accidental index-capture bugs in sort closures
• Consistency: Aligns with existing maps.Copy, slices.Collect, maps.Keys usage elsewhere in the codebase

Testing

• ✅ All pkg/actionpins tests pass
• ✅ go vet clean
• ✅ go build ./pkg/actionpins/ succeeds
• ✅ No behavior changes

Round-Robin Progress

• Processed: pkg/actionpins (1 of 22 packages)
• Next run: pkg/agentdrain

References: §24828978425

Generated by Functional Pragmatist · ● 1.8M · ◷

• expires on Apr 24, 2026, 10:09 AM UTC

[Copilot]

Pull request overview

Refactors pkg/actionpins to use newer Go stdlib maps/slices helpers for more declarative transformations and sorting, without intended behavior changes.

Changes:

• Replace imperative map-to-slice loop with slices.Collect(maps.Values(...)).
• Replace sort.Slice comparators with slices.SortFunc + cmp.Compare (including semver-descending sort).
• Simplify container pin nil initialization logic.

Show a summary per file

File	Description
pkg/actionpins/actionpins.go	Refactors pin collection and sorting to maps/slices/cmp, plus minor nil-guard simplification.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0