[spec-enforcer] Enforce specifications for actionpins, cli#28026
Merged
[spec-enforcer] Enforce specifications for actionpins, cli#28026
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
/q fix round robin logic m, the cache-memory should not have been empty |
Contributor
Author
|
🎩 Mission equipment ready! Q has optimized your workflow. Use wisely, 007! 🔫 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specification Test Enforcement
This PR adds specification-driven tests for the following packages:
actionpinsGetContainerPin), Types (ContainerPin)cliValidateWorkflowIntent), Design DecisionsTest Derivation
All tests are derived from README.md specifications, not from implementation source code.
pkg/actionpinsTestSpec_PublicAPI_GetContainerPin— validatesGetContainerPin(image string) (ContainerPin, bool)returnsfalsefor unknown images, as documentedTestSpec_Types_ContainerPin— validates the documentedContainerPinstruct fields (Image,Digest,PinnedImage)pkg/cliTestSpec_PublicAPI_ValidateWorkflowIntent— validates empty/short/valid intent strings as documentedTestSpec_PublicAPI_UpdateFieldInFrontmatter— validates field update/add in frontmatter YAMLTestSpec_PublicAPI_SetFieldInOnTrigger— validates setting fields inside theon:trigger blockTestSpec_PublicAPI_RemoveFieldFromOnTrigger— validates removing fields from theon:trigger blockTestSpec_PublicAPI_UpdateScheduleInOnBlock— validates cron schedule update in theon:blockSpec-Implementation Notes
UpdateFieldInFrontmatter(SPEC_AMBIGUITY): The README says "Sets a field in frontmatter YAML" without specifying behavior for content with no existing frontmatter. The implementation creates a new frontmatter block rather than returning an error. Test marked withSPEC_AMBIGUITYcomment.Round-Robin State
actionpins,cliagentdrain,console,constantsReferences:
Auto-generated by Package Specification Enforcer workflow