Skip to content

[spec-enforcer] Enforce specifications for actionpins, cli#28026

Merged
pelikhan merged 1 commit intomainfrom
spec-enforcer/actionpins-cli-2026-04-23-2cd5e039499ff08f
Apr 23, 2026
Merged

[spec-enforcer] Enforce specifications for actionpins, cli#28026
pelikhan merged 1 commit intomainfrom
spec-enforcer/actionpins-cli-2026-04-23-2cd5e039499ff08f

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Specification Test Enforcement

This PR adds specification-driven tests for the following packages:

Package Tests Added Tests Passing Spec Sections Covered
actionpins 2 2 Public API (GetContainerPin), Types (ContainerPin)
cli 5 5 Public API (frontmatter editors, ValidateWorkflowIntent), Design Decisions

Test Derivation

All tests are derived from README.md specifications, not from implementation source code.

pkg/actionpins

  • TestSpec_PublicAPI_GetContainerPin — validates GetContainerPin(image string) (ContainerPin, bool) returns false for unknown images, as documented
  • TestSpec_Types_ContainerPin — validates the documented ContainerPin struct fields (Image, Digest, PinnedImage)

pkg/cli

  • TestSpec_PublicAPI_ValidateWorkflowIntent — validates empty/short/valid intent strings as documented
  • TestSpec_PublicAPI_UpdateFieldInFrontmatter — validates field update/add in frontmatter YAML
  • TestSpec_PublicAPI_SetFieldInOnTrigger — validates setting fields inside the on: trigger block
  • TestSpec_PublicAPI_RemoveFieldFromOnTrigger — validates removing fields from the on: trigger block
  • TestSpec_PublicAPI_UpdateScheduleInOnBlock — validates cron schedule update in the on: block

Spec-Implementation Notes

  • UpdateFieldInFrontmatter (SPEC_AMBIGUITY): The README says "Sets a field in frontmatter YAML" without specifying behavior for content with no existing frontmatter. The implementation creates a new frontmatter block rather than returning an error. Test marked with SPEC_AMBIGUITY comment.

Round-Robin State

  • Packages processed this run: actionpins, cli
  • Next packages in rotation: agentdrain, console, constants
  • Total eligible packages: 22 (with README.md)

References:


Auto-generated by Package Specification Enforcer workflow

Generated by Package Specification Enforcer · ● 365.5K ·

  • expires on Apr 26, 2026, 10:58 AM UTC

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@pelikhan
Copy link
Copy Markdown
Collaborator

/q fix round robin logic m, the cache-memory should not have been empty

@pelikhan pelikhan merged commit 9fe34ab into main Apr 23, 2026
@pelikhan pelikhan deleted the spec-enforcer/actionpins-cli-2026-04-23-2cd5e039499ff08f branch April 23, 2026 12:09
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions Bot commented Apr 23, 2026

🎩 Mission equipment ready! Q has optimized your workflow. Use wisely, 007! 🔫

@github-actions
Copy link
Copy Markdown
Contributor Author

Issue created: #28072

🎩 Equipped by Q

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant